{"id":27483,"url":"https://patchwork.libcamera.org/api/patches/27483/?format=json","web_url":"https://patchwork.libcamera.org/patch/27483/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260723154327.1357866-35-barnabas.pocze@ideasonboard.com>","date":"2026-07-23T15:43:17","name":"[RFC,v2,34/43] ipa: simple: agc: Simplify min gain step handling","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"023988f41a9f7d8f4a6da46c471df2f9759b94fa","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27483/mbox/","series":[{"id":6075,"url":"https://patchwork.libcamera.org/api/series/6075/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6075","date":"2026-07-23T15:42:43","name":"ipa: libipa: agc rework","version":2,"mbox":"https://patchwork.libcamera.org/series/6075/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27483/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27483/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6F49C3336\n\tfor ;\n\tThu, 23 Jul 2026 15:44:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8466967F72;\n\tThu, 23 Jul 2026 17:44:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2EFFE67EE3\n\tfor ;\n\tThu, 23 Jul 2026 17:43:39 +0200 (CEST)","from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57ADF1F0F\n\tfor ;\n\tThu, 23 Jul 2026 17:42:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BnFNrcsh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821358;\n\tbh=3VJsg23vpRZkimnUndQSKOVsX62mssI5yD3j+TV5wQ0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BnFNrcshFN6lndTC1F/GE1P9qhYwd3yJ5r8UxfH7TIpT6O1qahQl/GBf3y8TiRlqX\n\twPMQpQfsLDcekbMZnqdBEl3Rk7CDo4SW5nKcQcXKhwcNzgh6YvrOFk5HKa+uDLh1LW\n\taPEAXF9FVuB0X0TCd0TI2rheBHyGaS8XQV8Z1JE8=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 34/43] ipa: simple: agc: Simplify min gain step\n\thandling","Date":"Thu, 23 Jul 2026 17:43:17 +0200","Message-ID":"<20260723154327.1357866-35-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use `std::{min,max}()` just like it is done for the exposure.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/simple/algorithms/agc.cpp | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex f959abeba5..b25c303835 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -130,19 +130,13 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n \t\t\texposure = std::max(next, exposure + 1);\n \t\t} else {\n \t\t\tdouble next = again * factor;\n-\t\t\tif (next - again < context.configuration.agc.againMinStep)\n-\t\t\t\tagain += context.configuration.agc.againMinStep;\n-\t\t\telse\n-\t\t\t\tagain = next;\n+\t\t\tagain = std::max(next, again + context.configuration.agc.againMinStep);\n \t\t}\n \t} else {\n \t\t/* Scene too bright: decrease gain first, then exposure. */\n \t\tif (again > context.configuration.agc.again10) {\n \t\t\tdouble next = again * factor;\n-\t\t\tif (again - next < context.configuration.agc.againMinStep)\n-\t\t\t\tagain -= context.configuration.agc.againMinStep;\n-\t\t\telse\n-\t\t\t\tagain = next;\n+\t\t\tagain = std::max(next, again - context.configuration.agc.againMinStep);\n \t\t} else {\n \t\t\tuint32_t next = exposure * factor;\n \t\t\texposure = std::min(next, exposure - 1);\n","prefixes":["RFC","v2","34/43"]}