{"id":27480,"url":"https://patchwork.libcamera.org/api/patches/27480/?format=json","web_url":"https://patchwork.libcamera.org/patch/27480/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260723154327.1357866-33-barnabas.pocze@ideasonboard.com>","date":"2026-07-23T15:43:15","name":"[RFC,v2,32/43] ipa: simple: Store exposure as `uint32_t`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d14297cdb9084a1aa1c58424921b72f88c86bb52","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27480/mbox/","series":[{"id":6075,"url":"https://patchwork.libcamera.org/api/series/6075/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6075","date":"2026-07-23T15:42:43","name":"ipa: libipa: agc rework","version":2,"mbox":"https://patchwork.libcamera.org/series/6075/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27480/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27480/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CD78C3334\n\tfor ;\n\tThu, 23 Jul 2026 15:44:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6E2E67F40;\n\tThu, 23 Jul 2026 17:44:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B912067EF8\n\tfor ;\n\tThu, 23 Jul 2026 17:43:38 +0200 (CEST)","from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCB881F0F\n\tfor ;\n\tThu, 23 Jul 2026 17:42:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lYZCtDss\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821358;\n\tbh=XWYl5QGq6gBfqtoA0bh8WYysMWXQrmWXfdW7cIDgIR0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=lYZCtDss/aoR6YW2ny0k1i/NNa1UeYQanr9ST3cUgduy092nJXWBQajYRqgiB/IKa\n\tZL9F3EdSuM2xEbBAOzH64n+WkIhEtEWmhRNI5LrS8sp/e6LqYB0dyi3SqWzAUQ8WHY\n\tdGEEsL6xW+J4ZrkcBpJERbCB7qEEKFMkw44Zokng=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 32/43] ipa: simple: Store exposure as `uint32_t`","Date":"Thu, 23 Jul 2026 17:43:15 +0200","Message-ID":"<20260723154327.1357866-33-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Every other IPA module does that, so switch to `uint32_t` here as well.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/simple/algorithms/agc.cpp | 6 +++---\n src/ipa/simple/ipa_context.h | 10 +++++-----\n 2 files changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex e9bcb2c032..93505f7665 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -67,7 +67,7 @@ Agc::Agc()\n \n void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, double exposureMSV)\n {\n-\tint32_t exposure = frameContext.sensor.exposure;\n+\tuint32_t exposure = frameContext.sensor.exposure;\n \tdouble again = frameContext.sensor.gain;\n \n \tdouble error = kExposureOptimal - exposureMSV;\n@@ -87,7 +87,7 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n \tif (factor > 1.0f) {\n \t\t/* Scene too dark: increase exposure first, then gain. */\n \t\tif (exposure < context.configuration.agc.exposureMax) {\n-\t\t\tint32_t next = static_cast(exposure * factor);\n+\t\t\tuint32_t next = exposure * factor;\n \t\t\texposure = std::max(next, exposure + 1);\n \t\t} else {\n \t\t\tdouble next = again * factor;\n@@ -105,7 +105,7 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n \t\t\telse\n \t\t\t\tagain = next;\n \t\t} else {\n-\t\t\tint32_t next = static_cast(exposure * factor);\n+\t\t\tuint32_t next = exposure * factor;\n \t\t\texposure = std::min(next, exposure - 1);\n \t\t}\n \t}\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex d35fb1e91d..980dc93cc4 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -26,7 +26,7 @@ namespace ipa::soft {\n \n struct IPASessionConfiguration {\n \tstruct {\n-\t\tint32_t exposureMin, exposureMax;\n+\t\tuint32_t exposureMin, exposureMax;\n \t\tdouble againMin, againMax, again10, againMinStep;\n \t\tutils::Duration lineDuration;\n \t} agc;\n@@ -37,14 +37,14 @@ struct IPASessionConfiguration {\n \n struct IPAActiveState {\n \tstruct {\n-\t\tint32_t exposure;\n+\t\tuint32_t exposure;\n \t\tdouble again;\n \t\tbool valid;\n \t} agc;\n \n \tstruct {\n \t\tuint8_t level;\n-\t\tint32_t lastExposure;\n+\t\tuint32_t lastExposure;\n \t\tdouble lastGain;\n \t} blc;\n \n@@ -67,12 +67,12 @@ struct IPAFrameContext : public FrameContext {\n \tMatrix ccm;\n \n \tstruct {\n-\t\tint32_t exposure;\n+\t\tuint32_t exposure;\n \t\tdouble gain;\n \t} agc;\n \n \tstruct {\n-\t\tint32_t exposure;\n+\t\tuint32_t exposure;\n \t\tdouble gain;\n \t} sensor;\n \n","prefixes":["RFC","v2","32/43"]}