[{"id":39884,"web_url":"https://patchwork.libcamera.org/comment/39884/","msgid":"","date":"2026-07-27T15:00:14","subject":"Re: [RFC PATCH v2 30/43] ipa: libipa: histogram: total(): Use\n\t`back()`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Reviewed-by: Jacopo Mondi \n\nOn Thu, Jul 23, 2026 at 05:43:13PM +0200, Barnabás Pőcze wrote:\n> Use the back method of `std::vector` to get the last element\n> instead of indexing; this is clearer.\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/ipa/libipa/histogram.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index 8cf8bb6d16..0c02dda2ba 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -37,7 +37,7 @@ public:\n>\n> \tsize_t bins() const { return cumulative_.size() - 1; }\n> \tSpan data() const { return cumulative_; }\n> -\tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n> +\tuint64_t total() const { return cumulative_.back(); }\n> \tuint64_t cumulativeFrequency(double bin) const;\n> \tdouble quantile(double q, uint32_t first = 0, uint32_t last = UINT_MAX) const;\n> \tdouble interQuantileMean(double lowQuantile, double hiQuantile) const;\n> --\n> 2.55.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B4D9BDE4C\n\tfor ;\n\tMon, 27 Jul 2026 15:00:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2356E67F8D;\n\tMon, 27 Jul 2026 17:00:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8FDF67F7E\n\tfor ;\n\tMon, 27 Jul 2026 17:00:17 +0200 (CEST)","from ideasonboard.com (mob-5-90-50-102.net.vodafone.it\n\t[5.90.50.102])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CD543A4;\n\tMon, 27 Jul 2026 16:59:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lEEqLHSC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785164354;\n\tbh=oBFGPAbEAI2GctQhogoC6y/LlEhhBTviBNf3ue9cdlY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lEEqLHSCryLfYBLPqOLYvsTfLMeUiI24453evh7scHYALdos8NVEi45ygfLgPc0va\n\twXaamds7J53qx7pphGcOmL0h4pyZxUFbCQBEJ12WtpPcFvvn1sN80Ke9ylxKzDJ0cN\n\tn3mZE2Z3Mg3DZsp/w5BKr90lIVq+fNqI5/8VsHxE=","Date":"Mon, 27 Jul 2026 17:00:14 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 30/43] ipa: libipa: histogram: total(): Use\n\t`back()`","Message-ID":"","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>\n\t<20260723154327.1357866-31-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260723154327.1357866-31-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]