{"id":27474,"url":"https://patchwork.libcamera.org/api/patches/27474/?format=json","web_url":"https://patchwork.libcamera.org/patch/27474/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260723154327.1357866-26-barnabas.pocze@ideasonboard.com>","date":"2026-07-23T15:43:08","name":"[RFC,v2,25/43] ipa: libipa: agc: Use default exposure","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"abc4a39fbd77bafaeee8bd07756edd3699ae24dd","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27474/mbox/","series":[{"id":6075,"url":"https://patchwork.libcamera.org/api/series/6075/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6075","date":"2026-07-23T15:42:43","name":"ipa: libipa: agc rework","version":2,"mbox":"https://patchwork.libcamera.org/series/6075/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27474/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27474/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E44DC330A\n\tfor ;\n\tThu, 23 Jul 2026 15:44:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9626067F4B;\n\tThu, 23 Jul 2026 17:44:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9556C67ED4\n\tfor ;\n\tThu, 23 Jul 2026 17:43:36 +0200 (CEST)","from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD8FA2C0B\n\tfor ;\n\tThu, 23 Jul 2026 17:42:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fUaOkXbB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821355;\n\tbh=Wi9xjYH957JYDQ4WTv72x9XHTABa+6xnKJ3UAIcFj0o=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fUaOkXbBREX2wEJKXhLpkqrD9n5Fd5O0KrLskP9NCo6z0VM6relXw5b4dn+/N7pma\n\tZjnVkgGYiaHX7bj3S1HLojiGHFtRJieIwT50nYfyYQR/nOBiSaaOJGBz35zJYiYH4j\n\txmP17NsATI9JaXxTcNonQ2ic9ZKWbowcSy5Gt+BI=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 25/43] ipa: libipa: agc: Use default exposure","Date":"Thu, 23 Jul 2026 17:43:08 +0200","Message-ID":"<20260723154327.1357866-26-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of hard-coding 10ms, just use the default exposure time\nas determined by the V4L2 control. This ensures that the advertised\ndefault in the `ControlInfo` matches what actually happens.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/libipa/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\nindex edcbab1e0b..54c5c6c349 100644\n--- a/src/ipa/libipa/agc.cpp\n+++ b/src/ipa/libipa/agc.cpp\n@@ -355,7 +355,7 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, cons\n \t/* Configure the default exposure and gain. */\n \tstate = {};\n \tstate.automatic.gain = session.minAnalogueGain;\n-\tstate.automatic.exposure = clampExposure(10ms, session);\n+\tstate.automatic.exposure = clampExposure(defExposure * session.lineDuration, session);\n \tstate.automatic.quantizationGain = 1;\n \tstate.automatic.yTarget = impl_.effectiveYTarget(0, 1);\n \tstate.manual.gain = state.automatic.gain;\n","prefixes":["RFC","v2","25/43"]}