[{"id":39875,"web_url":"https://patchwork.libcamera.org/comment/39875/","msgid":"","date":"2026-07-27T13:58:10","subject":"Re: [RFC PATCH v2 24/43] ipa: libipa: agc: Use full range as default\n\t`FrameDurationLimits`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"On Thu, Jul 23, 2026 at 05:43:07PM +0200, Barnabás Pőcze wrote:\n> Currently the default value for `FrameDurationLimits` is meaningless\n> because the full range is used by default. So advertise the full range.\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/ipa/libipa/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp\n> index 49b3034746..edcbab1e0b 100644\n> --- a/src/ipa/libipa/agc.cpp\n> +++ b/src/ipa/libipa/agc.cpp\n> @@ -326,7 +326,7 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, cons\n> \tconfig.ctrlMap[&controls::FrameDurationLimits] = ControlInfo{\n> \t\tframeDurations[0],\n> \t\tframeDurations[1],\n> -\t\tSpan{ { frameDurations[2], frameDurations[2] } },\n> +\t\tSpan{ { frameDurations[0], frameDurations[1] } },\n\ntrue, we should probably report frameDurations[2] in metadata, but the\nlimits should indeed be full range\n\nReviewed-by: Jacopo Mondi \n\n> \t};\n>\n> \tsession.minFrameDuration = std::chrono::microseconds(frameDurations[0]);\n> --\n> 2.55.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EFB4BE080\n\tfor ;\n\tMon, 27 Jul 2026 13:58:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38AD067F7D;\n\tMon, 27 Jul 2026 15:58:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF91F67EB2\n\tfor ;\n\tMon, 27 Jul 2026 15:58:13 +0200 (CEST)","from ideasonboard.com (mob-5-90-50-102.net.vodafone.it\n\t[5.90.50.102])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17860492;\n\tMon, 27 Jul 2026 15:57:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K6XgIKcP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1785160630;\n\tbh=cEzgWtQbgVayAlYLG8gmAvzv74vRIzhWmSaLGZDQo1A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=K6XgIKcPQ0gF/IIBUyAYXUJFLiq59Xye4r5IWaHdWehsUbr3eEguOcw6B7GRJMlt4\n\toOgPani2gw3MVZwC9rJmRr/3/MihzRV9RgaDVmBIIKYeyDrEJYdJWJnXB5sq5hcLvs\n\tvICZNiB4jWoLLQZlhk2gGTJNV61TVqeVDmClRc0A=","Date":"Mon, 27 Jul 2026 15:58:10 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 24/43] ipa: libipa: agc: Use full range as default\n\t`FrameDurationLimits`","Message-ID":"","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>\n\t<20260723154327.1357866-25-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260723154327.1357866-25-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]