[{"id":3596,"web_url":"https://patchwork.libcamera.org/comment/3596/","msgid":"","date":"2020-01-29T12:35:49","subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn 29/01/2020 03:32, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> Prior to sending caps, we need to send a stream-start event. This requires\n> generating a stream and a group id. The stream id is random for live sources and\n> the group id is shared across all pads.\n\nInterestingly, I can compile against gstreamer1.0 1.14 up until this\npatch, but then I hit another dependency.\n\nThe target I'm building on has glib-2.0 version 2.59, and\nGRecMutexLocker was introduced in 2.60 :S\n\n\nPerhaps this patch might also need to add something like the (untested)\nfollowing:\n\ndiff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\nindex 9d273437..58cf0009 100644\n--- a/src/gstreamer/meson.build\n+++ b/src/gstreamer/meson.build\n@@ -11,6 +11,9 @@ libcamera_gst_c_args = [\n '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n ]\n\n+glib_dep = dependency('glib-2.0', version : '>=2.60',\n+ required : get_option('gstreamer'))\n+\n gst_dep = dependency('gstreamer-video-1.0', version : '>=1.14',\n required : get_option('gstreamer'))\n\n\n> Signed-off-by: Nicolas Dufresne \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index be32a11..b1a21dc 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -18,6 +18,8 @@ using namespace libcamera;\n> GST_DEBUG_CATEGORY_STATIC(source_debug);\n> #define GST_CAT_DEFAULT source_debug\n> \n> +#define STREAM_LOCKER(obj) g_autoptr(GRecMutexLocker) stream_locker = g_rec_mutex_locker_new(&GST_LIBCAMERA_SRC(obj)->stream_lock)\n> +\n> /* Used for C++ object with destructors */\n> struct GstLibcameraSrcState {\n> \tstd::shared_ptr cm;\n> @@ -127,9 +129,20 @@ gst_libcamera_src_task_run(gpointer user_data)\n> static void\n> gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n> {\n> +\tSTREAM_LOCKER(user_data);\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> +\tGstLibcameraSrcState *state = self->state;\n> \n> \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n> +\n> +\tguint group_id = gst_util_group_id_next();\n> +\tfor (GstPad *srcpad : state->srcpads) {\n> +\t\t/* Create stream-id and push stream-start */\n> +\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), nullptr);\n> +\t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n> +\t\tgst_event_set_group_id(event, group_id);\n> +\t\tgst_pad_push_event(srcpad, event);\n> +\t}\n> }\n> \n> static void\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DC08608C6\n\tfor ;\n\tWed, 29 Jan 2020 13:35:54 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA725516;\n\tWed, 29 Jan 2020 13:35:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580301353;\n\tbh=tUNEbDohKzNla9bP0Aug1O4zKhDYt8JyEZ5qYEC5Pgo=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=r88RHP9nfjB96RbZh/VDupoeUyeBwQ77U8xKnYGvmbTjiTLfnaMoo89Cx1T8S6iBG\n\tcxFCnDNQGx2MCA/6DozpoNI8R4J7kGzClDzAcP8pb2O5hWGKw3XNtM2zX5Yffs7T9b\n\t5rppSYE14dUmOXHoWfN0oM+km4i9nw8zPBs3E+OQ=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Nicolas Dufresne ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-14-nicolas@ndufresne.ca>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 29 Jan 2020 12:35:49 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200129033210.278800-14-nicolas@ndufresne.ca>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Jan 2020 12:35:54 -0000"}},{"id":3597,"web_url":"https://patchwork.libcamera.org/comment/3597/","msgid":"","date":"2020-01-29T13:19:57","subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hello again :-)\n\nOn 29/01/2020 12:35, Kieran Bingham wrote:\n> Hi Nicolas,\n> \n> On 29/01/2020 03:32, Nicolas Dufresne wrote:\n>> From: Nicolas Dufresne \n>>\n>> Prior to sending caps, we need to send a stream-start event. This requires\n>> generating a stream and a group id. The stream id is random for live sources and\n>> the group id is shared across all pads.\n> \n> Interestingly, I can compile against gstreamer1.0 1.14 up until this\n> patch, but then I hit another dependency.\n> \n> The target I'm building on has glib-2.0 version 2.59, and\n> GRecMutexLocker was introduced in 2.60 :S\n> \n\nHrm, ok so my rootfs is Debian 10 stable (\"Buster\"), which is probably a\nreasonable target to aim to support:\n\nWith Buster:\nlibglib-2.0 - 2.58 https://packages.debian.org/buster/libglib2.0-0\nGstreamer - 1.14.4 https://packages.debian.org/buster/libgstreamer1.0-0\n\n\nI wonder if this can be worked around easily to define the functionality\nneeded when it's not in glib. It would be a pain to have to rewrite\nsomething ...\n\n--\nKieran\n\n\n> Perhaps this patch might also need to add something like the (untested)\n> following:\n> \n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index 9d273437..58cf0009 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -11,6 +11,9 @@ libcamera_gst_c_args = [\n> '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n> ]\n> \n> +glib_dep = dependency('glib-2.0', version : '>=2.60',\n> + required : get_option('gstreamer'))\n> +\n> gst_dep = dependency('gstreamer-video-1.0', version : '>=1.14',\n> required : get_option('gstreamer'))\n> \n> \n>> Signed-off-by: Nicolas Dufresne \n>> ---\n>> src/gstreamer/gstlibcamerasrc.cpp | 13 +++++++++++++\n>> 1 file changed, 13 insertions(+)\n>>\n>> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n>> index be32a11..b1a21dc 100644\n>> --- a/src/gstreamer/gstlibcamerasrc.cpp\n>> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n>> @@ -18,6 +18,8 @@ using namespace libcamera;\n>> GST_DEBUG_CATEGORY_STATIC(source_debug);\n>> #define GST_CAT_DEFAULT source_debug\n>> \n>> +#define STREAM_LOCKER(obj) g_autoptr(GRecMutexLocker) stream_locker = g_rec_mutex_locker_new(&GST_LIBCAMERA_SRC(obj)->stream_lock)\n>> +\n>> /* Used for C++ object with destructors */\n>> struct GstLibcameraSrcState {\n>> \tstd::shared_ptr cm;\n>> @@ -127,9 +129,20 @@ gst_libcamera_src_task_run(gpointer user_data)\n>> static void\n>> gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n>> {\n>> +\tSTREAM_LOCKER(user_data);\n>> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n>> +\tGstLibcameraSrcState *state = self->state;\n>> \n>> \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n>> +\n>> +\tguint group_id = gst_util_group_id_next();\n>> +\tfor (GstPad *srcpad : state->srcpads) {\n>> +\t\t/* Create stream-id and push stream-start */\n>> +\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), nullptr);\n>> +\t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n>> +\t\tgst_event_set_group_id(event, group_id);\n>> +\t\tgst_pad_push_event(srcpad, event);\n>> +\t}\n>> }\n>> \n>> static void\n>>\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3FC4608C6\n\tfor ;\n\tWed, 29 Jan 2020 14:20:00 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 345E5516;\n\tWed, 29 Jan 2020 14:20:00 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1580304000;\n\tbh=MuY4I4kuGXlfcQDukbvYJfd/X+6oiGhUi5671Ticl2w=;\n\th=Reply-To:Subject:From:To:Cc:References:Date:In-Reply-To:From;\n\tb=OWyf+z7tPP/Ulvj4ncXDzZ/qaYOqwUZU3+5+2R6GXVRwEJPFx429/FwYOwxYzFOLd\n\tMx3pUMSRRY/4aNauxMW7csv8DasK2EIenz82/sYASaGX2LRoF/BP6buQBncvagEeHL\n\tequbtN4HfZ5LXr4r1zTlBdgsqK/s94TFux5YrsYA=","Reply-To":"kieran.bingham@ideasonboard.com","From":"Kieran Bingham ","To":"Nicolas Dufresne ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-14-nicolas@ndufresne.ca>\n\t","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 29 Jan 2020 13:19:57 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Jan 2020 13:20:01 -0000"}},{"id":3598,"web_url":"https://patchwork.libcamera.org/comment/3598/","msgid":"","date":"2020-01-29T18:11:50","subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mercredi 29 janvier 2020 à 12:35 +0000, Kieran Bingham a écrit :\n> Hi Nicolas,\n> \n> On 29/01/2020 03:32, Nicolas Dufresne wrote:\n> > From: Nicolas Dufresne \n> > \n> > Prior to sending caps, we need to send a stream-start event. This requires\n> > generating a stream and a group id. The stream id is random for live sources\n> > and\n> > the group id is shared across all pads.\n> \n> Interestingly, I can compile against gstreamer1.0 1.14 up until this\n> patch, but then I hit another dependency.\n> \n> The target I'm building on has glib-2.0 version 2.59, and\n> GRecMutexLocker was introduced in 2.60 :S\n\nGood catch, 2.60 is a bit aggressive. I have considered just implementing my own\nlocker in C++, since this is trivial, no I have a rationale to do so. With C++ I\ncan use the same locker for Mutex and RecMutex.\n\n> \n> Perhaps this patch might also need to add something like the (untested)\n> following:\n> \n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index 9d273437..58cf0009 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -11,6 +11,9 @@ libcamera_gst_c_args = [\n> '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n> ]\n> \n> +glib_dep = dependency('glib-2.0', version : '>=2.60',\n> + required : get_option('gstreamer'))\n> +\n\nI wanted to rely on GStreamer own restriction, to keep things simplier. So I'll\ncheck what 1.14 requires, and craft a test with such an old GLib.\n\n> gst_dep = dependency('gstreamer-video-1.0', version : '>=1.14',\n> required : get_option('gstreamer'))\n> \n> \n> > Signed-off-by: Nicolas Dufresne \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 13 +++++++++++++\n> > 1 file changed, 13 insertions(+)\n> > \n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> > b/src/gstreamer/gstlibcamerasrc.cpp\n> > index be32a11..b1a21dc 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -18,6 +18,8 @@ using namespace libcamera;\n> > GST_DEBUG_CATEGORY_STATIC(source_debug);\n> > #define GST_CAT_DEFAULT source_debug\n> > \n> > +#define STREAM_LOCKER(obj) g_autoptr(GRecMutexLocker) stream_locker =\n> > g_rec_mutex_locker_new(&GST_LIBCAMERA_SRC(obj)->stream_lock)\n> > +\n> > /* Used for C++ object with destructors */\n> > struct GstLibcameraSrcState {\n> > \tstd::shared_ptr cm;\n> > @@ -127,9 +129,20 @@ gst_libcamera_src_task_run(gpointer user_data)\n> > static void\n> > gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer\n> > user_data)\n> > {\n> > +\tSTREAM_LOCKER(user_data);\n> > \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> > +\tGstLibcameraSrcState *state = self->state;\n> > \n> > \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n> > +\n> > +\tguint group_id = gst_util_group_id_next();\n> > +\tfor (GstPad *srcpad : state->srcpads) {\n> > +\t\t/* Create stream-id and push stream-start */\n> > +\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad,\n> > GST_ELEMENT(self), nullptr);\n> > +\t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n> > +\t\tgst_event_set_group_id(event, group_id);\n> > +\t\tgst_pad_push_event(srcpad, event);\n> > +\t}\n> > }\n> > \n> > static void\n> >","headers":{"Return-Path":"","Received":["from mail-qt1-x843.google.com (mail-qt1-x843.google.com\n\t[IPv6:2607:f8b0:4864:20::843])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61552608C6\n\tfor ;\n\tWed, 29 Jan 2020 19:11:54 +0100 (CET)","by mail-qt1-x843.google.com with SMTP id t8so232084qtr.2\n\tfor ;\n\tWed, 29 Jan 2020 10:11:54 -0800 (PST)","from nicolas-tpx395.localdomain ([2610:98:8005::527])\n\tby smtp.gmail.com with ESMTPSA id\n\tt29sm1340411qkm.27.2020.01.29.10.11.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 29 Jan 2020 10:11:52 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=1PplzbFXQrvey6e+4+LiSHCUxjmQFx3Wh0qpuIrMsxw=;\n\tb=VScJ4D20h0Zu7kEJHUCydVjpwpRiwbl45a6ZMsV7XRfc/A2q5anR28caH5xrqpPI1j\n\tDwql3UilB3QLXnWEcGQ5uata+aCP9palgb3Y/jjgFGTEgj8OkJtY4EYWDD2UVKRsjIXC\n\tAkRF5IKedzTqakYNJhHKc802AHpfa81Jb0VUETv86dsZ6h97jPcXlMg3e2Ip6NaJdNYH\n\taUZWsnO62vIxYJorw1HGESi9rVZZ5AoQ11dL7m/9MIi7SI5T5/8abMfPgnNShDPIXMUv\n\tXxXis6mLqnlldiYa4RWkYVnd2NFR2FPhcoNYfB6f2ySeJKlQNNUz7qIDYjVbRxtqRGG+\n\tZnEg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=1PplzbFXQrvey6e+4+LiSHCUxjmQFx3Wh0qpuIrMsxw=;\n\tb=bGkYq38k9aaASIlTQhwSETzpiLycMgizyWxIKHZ1I+S0uqa6yD/yoGA4JHeAxCQlMt\n\tPzzHgtWq4RkAKKUA2Pe5Csjl3XpGWgZvx7cryfR+UKQP1Ce7GjN8AUWuDGsGRmNO1oJG\n\tVL9RkmikUuL2Yh2/kE398lS90PhrZZSJTK2vBhYJH56LfwdbDEvZJmshTu4EGznVy5/T\n\t2ATtbq3UonKjaAOTSEqM7IUUxMfCH8I8HIp4Hz73uHpWwbLMmDMUCXbRi1y0RcQGKc2Q\n\tQsBOeSMRSwgRjwx6hpim2dIoaydMdDPVYj4YGWWKGkRD48wA1S89uWGKCUaylxI3Budw\n\tsajg==","X-Gm-Message-State":"APjAAAWNm1+sJXSYK+2peHJEnLHftCHrcy8w3ukohJ8E5OHX7lL5XaQz\n\tdLyJfaVvctMSLLOAx7xCtgTffj7d/UM=","X-Google-Smtp-Source":"APXvYqwgNcGrey0jbQgGBolx0hqZ71LvW9tl4aqR72xLNgpsrZwIGyk5aZlcfZEQ/LFz+N5XSUsxmA==","X-Received":"by 2002:ac8:3f88:: with SMTP id d8mr458224qtk.382.1580321512684; \n\tWed, 29 Jan 2020 10:11:52 -0800 (PST)","Message-ID":"","From":"Nicolas Dufresne ","To":"kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org","Date":"Wed, 29 Jan 2020 13:11:50 -0500","In-Reply-To":"","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-14-nicolas@ndufresne.ca>\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.34.3 (3.34.3-1.fc31) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Jan 2020 18:11:54 -0000"}},{"id":3679,"web_url":"https://patchwork.libcamera.org/comment/3679/","msgid":"<20200211232117.GM20823@pendragon.ideasonboard.com>","date":"2020-02-11T23:21:17","subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Tue, Jan 28, 2020 at 10:32:00PM -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> Prior to sending caps, we need to send a stream-start event. This requires\n> generating a stream and a group id. The stream id is random for live sources and\n> the group id is shared across all pads.\n\nApart from the GRecMutexLocker issue pointed out by Kieran,\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Nicolas Dufresne \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index be32a11..b1a21dc 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -18,6 +18,8 @@ using namespace libcamera;\n> GST_DEBUG_CATEGORY_STATIC(source_debug);\n> #define GST_CAT_DEFAULT source_debug\n> \n> +#define STREAM_LOCKER(obj) g_autoptr(GRecMutexLocker) stream_locker = g_rec_mutex_locker_new(&GST_LIBCAMERA_SRC(obj)->stream_lock)\n> +\n> /* Used for C++ object with destructors */\n> struct GstLibcameraSrcState {\n> \tstd::shared_ptr cm;\n> @@ -127,9 +129,20 @@ gst_libcamera_src_task_run(gpointer user_data)\n> static void\n> gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n> {\n> +\tSTREAM_LOCKER(user_data);\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> +\tGstLibcameraSrcState *state = self->state;\n> \n> \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n> +\n> +\tguint group_id = gst_util_group_id_next();\n> +\tfor (GstPad *srcpad : state->srcpads) {\n> +\t\t/* Create stream-id and push stream-start */\n> +\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), nullptr);\n> +\t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n> +\t\tgst_event_set_group_id(event, group_id);\n> +\t\tgst_pad_push_event(srcpad, event);\n> +\t}\n> }\n> \n> static void","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 829D560990\n\tfor ;\n\tWed, 12 Feb 2020 00:21:32 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E97939DA;\n\tWed, 12 Feb 2020 00:21:31 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581463292;\n\tbh=w3j0NAmQGlLl/EMhpQ2WoQLK5pDzbUe3F/+ej5MKEqo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jYiqVnqYq1mcDl2Q+WeVEf0fEIUJp9LPn/vhduwosOmn0+3u+wG2iT7/o5ZoeUM1L\n\tRFFdvCKE7hPU+6jmD2pJWSa6yD4fMMST8/q2/hL92Xi/GGDzv9bb+qPEuYDL70EsEy\n\t3jQb4hEYqTdCBM92q5sGFI1eqYLF6HVJqQLCkxtE=","Date":"Wed, 12 Feb 2020 01:21:17 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Message-ID":"<20200211232117.GM20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-14-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200129033210.278800-14-nicolas@ndufresne.ca>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v1 13/23] gst: libcamerasrc: Send\n\tstream start event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 23:21:32 -0000"}}]