{"id":27463,"url":"https://patchwork.libcamera.org/api/patches/27463/?format=json","web_url":"https://patchwork.libcamera.org/patch/27463/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260723154327.1357866-16-barnabas.pocze@ideasonboard.com>","date":"2026-07-23T15:42:58","name":"[RFC,v2,15/43] ipa: libipa: agc_mean_luminance: constraintClampGain(): Mark `const`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0350dbf8ee6419bd2efd7bc852d27e42b38d7dc3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27463/mbox/","series":[{"id":6075,"url":"https://patchwork.libcamera.org/api/series/6075/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6075","date":"2026-07-23T15:42:43","name":"ipa: libipa: agc rework","version":2,"mbox":"https://patchwork.libcamera.org/series/6075/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27463/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27463/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BD18C328C\n\tfor ;\n\tThu, 23 Jul 2026 15:43:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4610467F2F;\n\tThu, 23 Jul 2026 17:43:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31F7667EC4\n\tfor ;\n\tThu, 23 Jul 2026 17:43:34 +0200 (CEST)","from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5ADFE2C09\n\tfor ;\n\tThu, 23 Jul 2026 17:42:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rr2/GhWE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821353;\n\tbh=z+VGiYwJlanVxNn7nc8MSGI0IQTD/fuduwGKRZO9HXY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rr2/GhWE+NL1cxfNKZVkOE2/8Hy4rLwPDtooXzeRy5lj0x0EfY0s8YLE+KqjZ/qHx\n\tA/nhpTTzn4MuSVKbRA4hJc45k74pGmarGuK2r5fHkj44nw6gMQCwxLKvWLytSRfOw3\n\t/R/R+qcixOfG2ryUwfzQOCr6Bc/ypFvl+ElSMh+0=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 15/43] ipa: libipa: agc_mean_luminance:\n\tconstraintClampGain(): Mark `const`","Date":"Thu, 23 Jul 2026 17:42:58 +0200","Message-ID":"<20260723154327.1357866-16-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no reason not to have this member function as `const`. Change the\nmap lookup to use `at()` just like it is done for `calculateNewEv()`, with\nthe same requirement that validation is the job of the caller.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/libipa/agc_mean_luminance.cpp | 4 ++--\n src/ipa/libipa/agc_mean_luminance.h | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex 083d67eb70..e8679c66be 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -539,7 +539,7 @@ double AgcMeanLuminance::estimateInitialGain(const Traits &traits) const\n */\n double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \t\t\t\t\t const Histogram &hist,\n-\t\t\t\t\t double gain)\n+\t\t\t\t\t double gain) const\n {\n \tauto applyConstraint = [this, &gain, &hist](const AgcConstraint &constraint) {\n \t\tdouble lux = lux_;\n@@ -569,7 +569,7 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \t\t}\n \t};\n \n-\tstd::vector &constraints = constraintModes_[constraintModeIndex];\n+\tconst std::vector &constraints = constraintModes_.at(constraintModeIndex);\n \tstd::for_each(constraints.begin(), constraints.end(), applyConstraint);\n \n \tstd::for_each(additionalConstraints_.begin(), additionalConstraints_.end(), applyConstraint);\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex eb9d6fec2b..9b82d97ab6 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -105,7 +105,7 @@ private:\n \tdouble estimateInitialGain(const Traits &traits) const;\n \tdouble constraintClampGain(uint32_t constraintModeIndex,\n \t\t\t\t const Histogram &hist,\n-\t\t\t\t double gain);\n+\t\t\t\t double gain) const;\n \tutils::Duration filterExposure(utils::Duration exposureValue);\n \n \tutils::Duration filteredExposure_;\n","prefixes":["RFC","v2","15/43"]}