[{"id":3676,"web_url":"https://patchwork.libcamera.org/comment/3676/","msgid":"<20200211231500.GK20823@pendragon.ideasonboard.com>","date":"2020-02-11T23:15:00","subject":"Re: [libcamera-devel] [PATCH v1 12/23] gst: libcamerasrc: Store the\n\tsrcpad in a vector","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Tue, Jan 28, 2020 at 10:31:59PM -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> This will allow implementing generic algorithm even if we cannot\n> request pads yet.\n> \n> Signed-off-by: Nicolas Dufresne \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 4d0c7d0..be32a11 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -22,6 +22,7 @@ GST_DEBUG_CATEGORY_STATIC(source_debug);\n> struct GstLibcameraSrcState {\n> \tstd::shared_ptr cm;\n> \tstd::shared_ptr cam;\n> +\tstd::vector srcpads;\n\nCould you include , and generally, any C++ headers that is\nrequired by std:: symbols that you use ? They're currently included\nindirectly, but to avoid future compilation issues if headers get\nrefactored, including the dependencies explicitly is best.\n\nReviewed-by: Laurent Pinchart \n\n> };\n> \n> struct _GstLibcameraSrc {\n> @@ -29,7 +30,6 @@ struct _GstLibcameraSrc {\n> \n> \tGRecMutex stream_lock;\n> \tGstTask *task;\n> -\tGstPad *srcpad;\n> \n> \tgchar *camera_name;\n> \n> @@ -258,8 +258,8 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n> \tgst_task_set_leave_callback(self->task, gst_libcamera_src_task_leave, self, nullptr);\n> \tgst_task_set_lock(self->task, &self->stream_lock);\n> \n> -\tself->srcpad = gst_pad_new_from_template(templ, \"src\");\n> -\tgst_element_add_pad(GST_ELEMENT(self), self->srcpad);\n> +\tstate->srcpads.push_back(gst_pad_new_from_template(templ, \"src\"));\n> +\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads[0]);\n> \tself->state = state;\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22CC160990\n\tfor ;\n\tWed, 12 Feb 2020 00:15:16 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DA829DA;\n\tWed, 12 Feb 2020 00:15:15 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581462915;\n\tbh=3YfbQvyg0cLsJmu7qIMCV/W0E6RDcX1L+d0tD1njGco=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I+VqqSuV0km6OvrGjQdYY3x0v+rmNHzGnQrBi56mdLDnh1+tvADtbXt2RxCiCGpe/\n\tdK0z+fOq//FJ5koDDaA4Prko0yIsdMgyGFAHRV6DIz9HSTSSHXRkbNYK0biN2MhyGM\n\tEz3jWftRJLNOpvtJTsrM/+pte/IBlYPsa+MUmCUc=","Date":"Wed, 12 Feb 2020 01:15:00 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Message-ID":"<20200211231500.GK20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-13-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200129033210.278800-13-nicolas@ndufresne.ca>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v1 12/23] gst: libcamerasrc: Store the\n\tsrcpad in a vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 23:15:16 -0000"}}]