{"id":2746,"url":"https://patchwork.libcamera.org/api/patches/2746/?format=json","web_url":"https://patchwork.libcamera.org/patch/2746/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200129033210.278800-13-nicolas@ndufresne.ca>","date":"2020-01-29T03:31:59","name":"[libcamera-devel,v1,12/23] gst: libcamerasrc: Store the srcpad in a vector","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5b3c302c8da71b0103d738cba659a2630c0689c1","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2746/mbox/","series":[{"id":648,"url":"https://patchwork.libcamera.org/api/series/648/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=648","date":"2020-01-29T03:31:47","name":"GStreamer Element for libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/648/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2746/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2746/checks/","tags":{},"headers":{"Return-Path":"<nicolas@ndufresne.ca>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C907608CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Jan 2020 04:35:32 +0100 (CET)","from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 286C128EA9F;\n\tWed, 29 Jan 2020 03:35:30 +0000 (GMT)"],"From":"Nicolas Dufresne <nicolas@ndufresne.ca>","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Date":"Tue, 28 Jan 2020 22:31:59 -0500","Message-Id":"<20200129033210.278800-13-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200129033210.278800-1-nicolas@ndufresne.ca>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 12/23] gst: libcamerasrc: Store the\n\tsrcpad in a vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 29 Jan 2020 03:35:32 -0000"},"content":"From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThis will allow implementing generic algorithm even if we cannot\nrequest pads yet.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 4d0c7d0..be32a11 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -22,6 +22,7 @@ GST_DEBUG_CATEGORY_STATIC(source_debug);\n struct GstLibcameraSrcState {\n \tstd::shared_ptr<CameraManager> cm;\n \tstd::shared_ptr<Camera> cam;\n+\tstd::vector<GstPad *> srcpads;\n };\n \n struct _GstLibcameraSrc {\n@@ -29,7 +30,6 @@ struct _GstLibcameraSrc {\n \n \tGRecMutex stream_lock;\n \tGstTask *task;\n-\tGstPad *srcpad;\n \n \tgchar *camera_name;\n \n@@ -258,8 +258,8 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \tgst_task_set_leave_callback(self->task, gst_libcamera_src_task_leave, self, nullptr);\n \tgst_task_set_lock(self->task, &self->stream_lock);\n \n-\tself->srcpad = gst_pad_new_from_template(templ, \"src\");\n-\tgst_element_add_pad(GST_ELEMENT(self), self->srcpad);\n+\tstate->srcpads.push_back(gst_pad_new_from_template(templ, \"src\"));\n+\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads[0]);\n \tself->state = state;\n }\n \n","prefixes":["libcamera-devel","v1","12/23"]}