{"id":27453,"url":"https://patchwork.libcamera.org/api/patches/27453/?format=json","web_url":"https://patchwork.libcamera.org/patch/27453/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260723154327.1357866-5-barnabas.pocze@ideasonboard.com>","date":"2026-07-23T15:42:47","name":"[RFC,v2,04/43] ipa: rkisp1: Remove `IPASessionConfiguration::sensor.defVBlank`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b954834f92bba7df426bfc1ebc320829721beffe","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27453/mbox/","series":[{"id":6075,"url":"https://patchwork.libcamera.org/api/series/6075/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6075","date":"2026-07-23T15:42:43","name":"ipa: libipa: agc rework","version":2,"mbox":"https://patchwork.libcamera.org/series/6075/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27453/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27453/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A12B6BE080\n\tfor ;\n\tThu, 23 Jul 2026 15:43:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C50A67EEB;\n\tThu, 23 Jul 2026 17:43:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2071267EC2\n\tfor ;\n\tThu, 23 Jul 2026 17:43:31 +0200 (CEST)","from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38FCD1C37;\n\tThu, 23 Jul 2026 17:42:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qVgxpy4e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821350;\n\tbh=3lbD0y7TasQbBIsv1vAEgxYhoxV5nBo9rr2AsWiEjaQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qVgxpy4e10m1T3ZVqDB91YiYKIvoNqQYdg+4mTn19gJ+7gu7bq+PSQG+R/5aaZPc7\n\tTFPVraDrrWo8irigKKt591X7wnd+sgOB5uoCR12bwsk8Aka7Zo1i9OuK41Q1uTLRWq\n\tvkYMJFIq64RCNFwIPYthl1wUlh2+wMa47WpZs0+o=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tJacopo Mondi ","Subject":"[RFC PATCH v2 04/43] ipa: rkisp1: Remove\n\t`IPASessionConfiguration::sensor.defVBlank`","Date":"Thu, 23 Jul 2026 17:42:47 +0200","Message-ID":"<20260723154327.1357866-5-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","References":"<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It is not used, so remove it.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \n---\n src/ipa/rkisp1/ipa_context.cpp | 3 ---\n src/ipa/rkisp1/ipa_context.h | 1 -\n src/ipa/rkisp1/rkisp1.cpp | 2 --\n 3 files changed, 6 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex f9d0aff058..302b4cfd70 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -98,9 +98,6 @@ namespace libcamera::ipa::rkisp1 {\n * \\var IPASessionConfiguration::sensor.maxAnalogueGain\n * \\brief Maximum analogue gain supported with the sensor\n *\n- * \\var IPASessionConfiguration::sensor.defVBlank\n- * \\brief The default vblank value of the sensor\n- *\n * \\var IPASessionConfiguration::sensor.lineDuration\n * \\brief Line duration in microseconds\n *\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex e5f70d934d..9a4e0f12c6 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -68,7 +68,6 @@ struct IPASessionConfiguration {\n \t\tdouble minAnalogueGain;\n \t\tdouble maxAnalogueGain;\n \n-\t\tint32_t defVBlank;\n \t\tutils::Duration lineDuration;\n \t\tSize size;\n \t} sensor;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 58ef163d85..273540a330 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -249,8 +249,6 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,\n \tcontext_.configuration.paramFormat = ipaConfig.paramFormat;\n \n \tconst IPACameraSensorInfo &info = ipaConfig.sensorInfo;\n-\tconst ControlInfo vBlank = sensorControls_.find(V4L2_CID_VBLANK)->second;\n-\tcontext_.configuration.sensor.defVBlank = vBlank.def().get();\n \tcontext_.configuration.sensor.size = info.outputSize;\n \tcontext_.configuration.sensor.lineDuration = info.minLineLength * 1.0s / info.pixelRate;\n \n","prefixes":["RFC","v2","04/43"]}