[{"id":3668,"web_url":"https://patchwork.libcamera.org/comment/3668/","msgid":"<20200211195200.GG20823@pendragon.ideasonboard.com>","date":"2020-02-11T19:52:00","subject":"Re: [libcamera-devel] [PATCH v1 11/23] gst: libcamerapad: Add a\n\tmethod to access the role","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Tue, Jan 28, 2020 at 10:31:58PM -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n\nMaybe a commit message ? (This comments applies to the other patches\ntoo, I won't repeat it).\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Nicolas Dufresne \n> ---\n> src/gstreamer/gstlibcamerapad.cpp | 8 ++++++++\n> src/gstreamer/gstlibcamerapad.h | 2 ++\n> 2 files changed, 10 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\n> index c6c22e4..b18584c 100644\n> --- a/src/gstreamer/gstlibcamerapad.cpp\n> +++ b/src/gstreamer/gstlibcamerapad.cpp\n> @@ -99,3 +99,11 @@ gst_libcamera_pad_class_init(GstLibcameraPadClass *klass)\n> \t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n> \tg_object_class_install_property(object_class, PROP_STREAM_ROLE, spec);\n> }\n> +\n> +StreamRole\n> +gst_libcamera_pad_get_role(GstPad *pad)\n> +{\n> +\tauto *self = GST_LIBCAMERA_PAD(pad);\n> +\tGST_OBJECT_LOCKER(self);\n> +\treturn self->role;\n> +}\n> diff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\n> index 2e745f1..3dea0e7 100644\n> --- a/src/gstreamer/gstlibcamerapad.h\n> +++ b/src/gstreamer/gstlibcamerapad.h\n> @@ -7,6 +7,7 @@\n> */\n> \n> #include \n> +#include \n> \n> #ifndef __GST_LIBCAMERA_PAD_H__\n> #define __GST_LIBCAMERA_PAD_H__\n> @@ -15,5 +16,6 @@\n> G_DECLARE_FINAL_TYPE(GstLibcameraPad, gst_libcamera_pad,\n> \t\t GST_LIBCAMERA, PAD, GstPad)\n> \n> +libcamera::StreamRole gst_libcamera_pad_get_role(GstPad *pad);\n> \n> #endif /* __GST_LIBCAMERA_PAD_H__ */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95E9160F3C\n\tfor ;\n\tTue, 11 Feb 2020 20:52:15 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 302199DA;\n\tTue, 11 Feb 2020 20:52:15 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581450735;\n\tbh=KHA0c+Jx6w2l5SWTIyQg9MvYEenxAoTQ5vPGCSwT5Bk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AjCc5oy7WryCu5wDwW5wsXnBHuqZOVoAYe2xkgfQN0vwH8LrHDssLhLtCzE7fOAyl\n\tpmmvsgDOkfLtPH+RbHBIdjaP6YlciWcbS5JxO3hII2mruf0tkLSUwaqN9Or2H3NfZg\n\t8fKqPipOXC8VQ84GugEOicO00fWFN1cAXnZI9AtI=","Date":"Tue, 11 Feb 2020 21:52:00 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Message-ID":"<20200211195200.GG20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-12-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200129033210.278800-12-nicolas@ndufresne.ca>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v1 11/23] gst: libcamerapad: Add a\n\tmethod to access the role","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 19:52:15 -0000"}}]