{"id":27436,"url":"https://patchwork.libcamera.org/api/patches/27436/?format=json","web_url":"https://patchwork.libcamera.org/patch/27436/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260722-pi4-upstream-v2-1-eb44d3c6fd92@ideasonboard.com>","date":"2026-07-22T11:23:17","name":"[v2,1/8] ipa: rpi: Drop unused params argument from platformPrepareIsp()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cc71ecfd65824798e10472227206a904e449b45e","submitter":{"id":223,"url":"https://patchwork.libcamera.org/api/people/223/?format=json","name":"Jai Luthra","email":"jai.luthra@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27436/mbox/","series":[{"id":6072,"url":"https://patchwork.libcamera.org/api/series/6072/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6072","date":"2026-07-22T11:23:16","name":"Raspberry Pi: Update VC4 pipeline for mainline","version":2,"mbox":"https://patchwork.libcamera.org/series/6072/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27436/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27436/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2809BDE17\n\tfor ;\n\tWed, 22 Jul 2026 11:24:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A323967E8A;\n\tWed, 22 Jul 2026 13:24:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99FDC67E8A\n\tfor ;\n\tWed, 22 Jul 2026 13:24:43 +0200 (CEST)","from mail.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1c68:25d4:fa24:78d1:31:7a56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B9D0227;\n\tWed, 22 Jul 2026 13:23:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a6c9/H1P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784719423;\n\tbh=lxR3DJXyq6m0F90hz/jSuiaOQi61Nmv7gwuhz0/38h8=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=a6c9/H1PMc1EIGL6sYp+M6GJGukdp+ThsI834XyV9RY2T7IIYQZeRjSRW+FYDVY3I\n\tQ5H1Rhfr90ypFqURGqBjTnTw6O32VfWryrKZalqp8eOb0OQ2y1JMqn/CgeNG7MY3Ni\n\tAOegbwBwi3grMY2wzRPfZJxTMBvV+3rkG3BggP04=","From":"Jai Luthra ","Date":"Wed, 22 Jul 2026 16:53:17 +0530","Subject":"[PATCH v2 1/8] ipa: rpi: Drop unused params argument from\n\tplatformPrepareIsp()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260722-pi4-upstream-v2-1-eb44d3c6fd92@ideasonboard.com>","References":"<20260722-pi4-upstream-v2-0-eb44d3c6fd92@ideasonboard.com>","In-Reply-To":"<20260722-pi4-upstream-v2-0-eb44d3c6fd92@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck , \n\tDavid Plowman , \n\tLaurent Pinchart , \n\tKieran Bingham , \n\tJacopo Mondi , \n\tDaniel Scally , \n\tJai Luthra ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3922;\n\ti=jai.luthra@ideasonboard.com; h=from:subject:message-id;\n\tbh=lxR3DJXyq6m0F90hz/jSuiaOQi61Nmv7gwuhz0/38h8=;\n\tb=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBqYKhojL1BhHXdBTLlF13U5w/Ztw4lL0WL33mEZ\n\tBzoJXfQS3mJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCamCoaAAKCRBD3pH5JJpx\n\tRTxKEACj11Oz7P9paHbrInOQaRItIPackj34ewWIhn4TD11GOK7aiUfOujwIfG3sPZLBhN9a/Ui\n\tPTqLOJhiySqxqstJUzYL6WDKk6T9CvrJqvOcBTjl6GlmYMEtXrZinKyOD3CO10ClIuwINQkjUOD\n\tUCL1vqZMJZ0a9Qy0wIVSYOm6v2IJFOS6f48mQlv8CkbpDvb56npjjKYZ7EN2E1xttYWzDCMZsEi\n\tLjrHqEznVTbY+W/RdzIxkvAeqWj5nFUStJFUlBhwo1Agtozv3Ez9Li0EG+8uE9SvMFoFGJ+uNx+\n\tuB4uNd9IieqEa0A7sNNPfdL0Wg8vFrmzWCI/vA7s5P6T8OHmn4Xe70jdQZYqnV4ypXf4XgxqNUe\n\tgrP0LTLEuao38WvCv4W09rrvZizdWzhXPLW/DzcBe6RelOegLXZH++B54mDoCEGbVUvLZvQgSe+\n\tsWSGkJIzimoZSWNHCBgMyfdm8XkRxIw9wYvoXNYJHknBWOxX6260zBk/nAGfj+X/rFYZl4weYYs\n\tI3GzpE7tJMKbf8lGsXjaZUytxkItfYIdJeSyI5KCXSID6nVQUrorVF3GPkT8nF9STuwFRI74MwD\n\tN0gjO3x8gOPm5qCVrAJxZK89WWtrfTvXw4iihJsGS3yO00MWl4mPh4RSeQ6uxFc8jG95CVdYRpH\n\t/4pNPFyhBGyNaOw==","X-Developer-Key":"i=jai.luthra@ideasonboard.com; a=openpgp;\n\tfpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In IPABase::platformPrepareIsp() we pass PrepareParams but none of the\nIPAs (vc4 and pisp) use them. So drop it.\n\nSigned-off-by: Jai Luthra \n---\n src/ipa/rpi/common/ipa_base.cpp | 2 +-\n src/ipa/rpi/common/ipa_base.h | 3 +--\n src/ipa/rpi/pisp/pisp.cpp | 6 ++----\n src/ipa/rpi/vc4/vc4.cpp | 5 ++---\n 4 files changed, 6 insertions(+), 10 deletions(-)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex dacafa578..e3f7b99a8 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -507,7 +507,7 @@ void IpaBase::prepareIsp(const PrepareParams ¶ms)\n \tif (processPending_) {\n \t\tcontroller_.prepare(&rpiMetadata);\n \t\t/* Actually prepare the ISP parameters for the frame. */\n-\t\tplatformPrepareIsp(params, rpiMetadata);\n+\t\tplatformPrepareIsp(rpiMetadata);\n \t\tplatformPrepareAgc(rpiMetadata);\n \t} else\n \t\tplatformPrepareAgc(rpiMetadata);\ndiff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 90f018b28..f4157e9ec 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -87,8 +87,7 @@ private:\n \tvirtual int32_t platformStart(const ControlList &controls, StartResult *result) = 0;\n \tvirtual int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) = 0;\n \n-\tvirtual void platformPrepareIsp(const PrepareParams ¶ms,\n-\t\t\t\t\tRPiController::Metadata &rpiMetadata) = 0;\n+\tvirtual void platformPrepareIsp(RPiController::Metadata &rpiMetadata) = 0;\n \tvirtual void platformPrepareAgc(RPiController::Metadata &rpiMetadata) = 0;\n \tvirtual RPiController::StatisticsPtr platformProcessStats(Span mem) = 0;\n \ndiff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp\nindex fd28fc385..025103808 100644\n--- a/src/ipa/rpi/pisp/pisp.cpp\n+++ b/src/ipa/rpi/pisp/pisp.cpp\n@@ -232,8 +232,7 @@ private:\n \tint32_t platformStart(const ControlList &controls, StartResult *result) override;\n \tint32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override;\n \n-\tvoid platformPrepareIsp(const PrepareParams ¶ms,\n-\t\t\t\tRPiController::Metadata &rpiMetadata) override;\n+\tvoid platformPrepareIsp(RPiController::Metadata &rpiMetadata) override;\n \tvoid platformPrepareAgc(RPiController::Metadata &rpiMetadata) override;\n \tRPiController::StatisticsPtr platformProcessStats(Span mem) override;\n \n@@ -354,8 +353,7 @@ int32_t IpaPiSP::platformConfigure([[maybe_unused]] const ConfigParams ¶ms,\n \treturn 0;\n }\n \n-void IpaPiSP::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms,\n-\t\t\t\t RPiController::Metadata &rpiMetadata)\n+void IpaPiSP::platformPrepareIsp(RPiController::Metadata &rpiMetadata)\n {\n \tstd::scoped_lock l(rpiMetadata);\n \ndiff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\nindex b6ca44e7a..052204d25 100644\n--- a/src/ipa/rpi/vc4/vc4.cpp\n+++ b/src/ipa/rpi/vc4/vc4.cpp\n@@ -59,7 +59,7 @@ private:\n \tint32_t platformStart(const ControlList &controls, StartResult *result) override;\n \tint32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override;\n \n-\tvoid platformPrepareIsp(const PrepareParams ¶ms, RPiController::Metadata &rpiMetadata) override;\n+\tvoid platformPrepareIsp(RPiController::Metadata &rpiMetadata) override;\n \tvoid platformPrepareAgc([[maybe_unused]] RPiController::Metadata &rpiMetadata) override;\n \tRPiController::StatisticsPtr platformProcessStats(Span mem) override;\n \n@@ -144,8 +144,7 @@ int32_t IpaVc4::platformConfigure(const ConfigParams ¶ms, [[maybe_unused]] C\n \treturn 0;\n }\n \n-void IpaVc4::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms,\n-\t\t\t\tRPiController::Metadata &rpiMetadata)\n+void IpaVc4::platformPrepareIsp(RPiController::Metadata &rpiMetadata)\n {\n \tControlList &ctrls = ctrls_;\n \n","prefixes":["v2","1/8"]}