{"id":27433,"url":"https://patchwork.libcamera.org/api/patches/27433/?format=json","web_url":"https://patchwork.libcamera.org/patch/27433/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260721145958.68489-3-johannes.goede@oss.qualcomm.com>","date":"2026-07-21T14:59:52","name":"[v2,2/7] software_isp: Rename simple IPA setIspParams signal to paramsComputed","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c945f3426346af2ba3a0ff1e1f4c3407d2357b01","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/?format=json","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27433/mbox/","series":[{"id":6070,"url":"https://patchwork.libcamera.org/api/series/6070/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6070","date":"2026-07-21T14:59:50","name":"camss: Add CAMSS pipeline handler","version":2,"mbox":"https://patchwork.libcamera.org/series/6070/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27433/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27433/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9315BDE4C\n\tfor ;\n\tTue, 21 Jul 2026 15:00:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55D6C67E63;\n\tTue, 21 Jul 2026 17:00:55 +0200 (CEST)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E04167E67\n\tfor ;\n\tTue, 21 Jul 2026 17:00:53 +0200 (CEST)","from pps.filterd (m0279868.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t66LDg8hu1842122 for ;\n\tTue, 21 Jul 2026 15:00:52 GMT","from mail-qt1-f197.google.com (mail-qt1-f197.google.com\n\t[209.85.160.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1se2vn4-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tTue, 21 Jul 2026 15:00:51 +0000 (GMT)","by mail-qt1-f197.google.com with SMTP id\n\td75a77b69052e-5276aa86d00so4061101cf.2\n\tfor ;\n\tTue, 21 Jul 2026 08:00:51 -0700 (PDT)","from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-c1712a5f837sm615968066b.32.2026.07.21.08.00.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 21 Jul 2026 08:00:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"gq7l7GNi\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"DINaFbK1\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=+3RCnHl3qpA\n\tursGcygSIZTEW6IU52Xet4/q1mpbNFAA=; b=gq7l7GNi/vHxkVkDkLjGyLqv/mX\n\t4Fu0iAdLfnq+NwcAwoeG+nMhexLAflo4Sc8GB5oTA54k+g6gr9v9YeYKcbb6KM4w\n\tpQRLIckQhfqY1rfUwQ08Tc/CSpjC7salj9RvkdUrkyiEkCqqkLrhCyB53Z6DITID\n\t15SMA4LyBFRgarL9YR60DOWGeA7Z+ljk7h0r4rkAShyIk6aaShp+6FgJdTrIyafQ\n\tQFuz8RXnucPQVwkScIYgXnpuQtp41YOmlfoA49cUM91cpKEa3k8xEJn8Pdm02Thh\n\tNquKhhcO11MYKTEVG/bmuWhvKLGkjTtX023CgOR9xtAPgkP2eyd4aS3Xm3w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1784646051; x=1785250851;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to:content-type;\n\tbh=+3RCnHl3qpAursGcygSIZTEW6IU52Xet4/q1mpbNFAA=;\n\tb=DINaFbK1rpZe9x26LpB9+/tB/9HdxnTZ7PRwb/gc2xj0la5qKlrtk18TxnlERZXt0g\n\tGe+lnMdjBmH2+l1fM69iCWuBMnz48OrvzLqqgc7t/zUqmHd5Fuh7NlYjdza/95+t6Xju\n\tAUEQ09GITU8n2YS9bkBjJiCVsRecUTPjTMocoho8vI3kvwnUCjMUzO1kmONo8aLPL8W5\n\tyvUOTi1Z3LPYJxpfUWWvKEYi47wDTgPH8RO/kSdDgQgZ3LAtEM4pYqKuZrgXOU6vFKLN\n\tXsm0fsLTh6MpxdeAK8s9vrpfa596RyQ7ZZQgZzHYHI4cQ9vk5iZp66SdyNy3xBHsrdAw\n\tQOIA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1784646051; x=1785250851;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to:content-type;\n\tbh=+3RCnHl3qpAursGcygSIZTEW6IU52Xet4/q1mpbNFAA=;\n\tb=jDWV2MJxUHO5CNmtyva9NmGnOddOu0oY9B/P2l5sO/ipDmM0MIZTt0w1GzSnrSZhS9\n\tgkXg1GXicWKCwkcmySAz6SHWrQiRDX7NTNDyHyG1tsCsqh0jfPQxUYt/CkIZvairKsLH\n\thL6U09gWx1WTuKeV/SGnsRsmSZunY4lKwN4NtJT0zYFiGSrOlDUYlqpnIMWn/EjsjlCF\n\tmg4iVCXWbQOb+tsZAkhmf+WMipxosJ/L3HpxtaXUB6/GiZUBoikdYO8F3FwhzHMFNQDo\n\tgR4jEmpywvcg9q8YBDAX8fVmk3G6pzQNuBqUYUb5Owyr38SFQZBlw0EM/Gl2ERkIEapg\n\tB1Sw==","X-Gm-Message-State":"AOJu0YzOmQF19sNE3lwopoD6IjDUgklj00LCZvn7fXuip1cJFrb6JZCK\n\taJN2FUFYPlVcSPTeCoHG6WcEODH1RGpbBam+C0pv2s5gXOOI0aHnSEGUN8N8FgKJAx6XNdfxe3b\n\tKyfhm/KTqNmzJY4T3l/1RO6KmMEfpMkSfMb1r0wLlauj1tuIP7RWOZ2vYzBrog/wfFa1hswPET+\n\tTcN/J7TTNN","X-Gm-Gg":"AfdE7clnN3l0EgjPjYEY9kD/1cIatFQyYVSNzYDV7W5gztQBmx8Aq6hFHZhzUb6VwpE\n\t6bpiMus4HC09S92nJjyMbt+SoR7ChMtmy4aSP0H/WUpgYQG7R8r8oUevZDQOoNabvZk1ChlbX6m\n\t0NddSquErzG3RxiGJzWMggR5W+T4ZuuFKQb6AmRT1yDxczn7vsiCqnWLYC8Q6cViPXTB45Ac8XC\n\tdZOwML/tJHlU8NSrgYg6cpVOBMPRsPeFtMFEyG4B5FOFDA/spUs44vhUU6HjqYUb+96xnXUp++W\n\tyt+m1hurJQb0ohj7aToEdd9upDQNBNXljPm5klOKyApu0U8pUU1nhn7V7eOKcoEHC/lx0EA2Qf9\n\t22nf8EXxaogellHGSYSwstyQM+Ssv1OR9HbEmDnnq/ioNAJraMtKyi/0R/nddcFJfnfew/yA8Bh\n\tX6+Wzolo47hNOSFnM=","X-Received":["by 2002:ac8:5809:0:b0:51c:709:b81c with SMTP id\n\td75a77b69052e-5213b1494c9mr180953511cf.32.1784646011114; \n\tTue, 21 Jul 2026 08:00:11 -0700 (PDT)","by 2002:ac8:5809:0:b0:51c:709:b81c with SMTP id\n\td75a77b69052e-5213b1494c9mr180943681cf.32.1784646002810; \n\tTue, 21 Jul 2026 08:00:02 -0700 (PDT)"],"From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Loic Poulain ,\n\tHans de Goede ","Subject":"[PATCH v2 2/7] software_isp: Rename simple IPA setIspParams signal\n\tto paramsComputed","Date":"Tue, 21 Jul 2026 16:59:52 +0200","Message-ID":"<20260721145958.68489-3-johannes.goede@oss.qualcomm.com>","X-Mailer":"git-send-email 2.55.0","In-Reply-To":"<20260721145958.68489-1-johannes.goede@oss.qualcomm.com>","References":"<20260721145958.68489-1-johannes.goede@oss.qualcomm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"93kTLbL8m6XAGgDP2kxfeS8uhjPH4WM5","X-Authority-Analysis":"v=2.4 cv=TIZ1jVla c=1 sm=1 tr=0 ts=6a5f89a3 cx=c_pps\n\ta=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=RAioF0-LDSMA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=X9iWcBBwFAc5_HUTaPUA:9\n\ta=a_PwQJl-kcHnX1M80qC6:22","X-Proofpoint-Spam-Info":"AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfXwiTmHttPCHYp\n\t4xKK8CU84VPkRCbmPHvuMoNa9eRX06yxjOMxKLl+D4otauRrbS9ZA3TMANjs4Dhpm6dIa7CrgfC\n\tpRq1WwgCP4IYNfeyp2N136CoK+BaoNg=","X-Proofpoint-GUID":"93kTLbL8m6XAGgDP2kxfeS8uhjPH4WM5","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX1M+j7yefVhNl\n\tXHcHD+VFwCICO+I8qcQFioODBfmVuTZVYZwUjG7sOVkwpBpBcZtCL0tYoltyUXnqRW2qtiVob2X\n\tYEH+EcJlD6ZUaUB+PIvyXeNEb78xpd4U1xzy3VIawkzWI34zjQhwxF8xwPVuPafBNv2eL2HDSR/\n\twbAtJWwgh9ZlaxOlRSHmBOY9JSbzwK9gOBFNSuv4IQVg5uWmc8Lu/wGLKR9wx16FAqI8/XCvGLH\n\t3S4948wtnGg3LvEY1nvEGL/qnetecYpjgg0J5Yvg3UoPgozc90PG2XEsZ8alU+Vq1kaK0S4emWY\n\tm7KwSk+3LhjkCWrj3na1N/lNUBSsviph/TFh7Udu/NGLtji5XVjL2hO0q9DIyoy2l6kthiviz8B\n\tUbx4sIEXUDZOQcSTOWrYiO0izXuxzIaJXhyUZM4LVE9ht7S+qrSwkOo6v8YIZLks+9ngKngWsq+\n\tOSVRtKBpjkt8TOzwbfw==","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.134,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-07-21_03,2026-07-20_03,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tlowpriorityscore=0 impostorscore=0 priorityscore=1501 spamscore=0\n\tclxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0\n\tphishscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n\troute=outbound adjust=0 reason=mlx scancount=1\n\tengine=8.22.0-2606150000\n\tdefinitions=main-2607210158","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename the simple IPA setIspParams signal to paramsComputed and pass\nthe frame-number as argument to make the simple IPA behavior consistent\nwith other IPA implementations.\n\nSigned-off-by: Hans de Goede \n---\n include/libcamera/internal/software_isp/software_isp.h | 2 +-\n include/libcamera/ipa/soft.mojom | 2 +-\n src/ipa/simple/soft_simple.cpp | 2 +-\n src/libcamera/software_isp/software_isp.cpp | 4 ++--\n 4 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 4f72dce9b..58353301f 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -89,7 +89,7 @@ public:\n \tSignal setSensorControls;\n \n private:\n-\tvoid saveIspParams();\n+\tvoid saveIspParams(uint32_t frame);\n \tvoid setSensorCtrls(const ControlList &sensorControls);\n \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n \tvoid inputReady(FrameBuffer *input);\ndiff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..55a00b598 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -33,6 +33,6 @@ interface IPASoftInterface {\n \n interface IPASoftEventInterface {\n \tsetSensorControls(libcamera.ControlList sensorControls);\n-\tsetIspParams();\n+\tparamsComputed(uint32 frame);\n \tmetadataReady(uint32 frame, libcamera.ControlList metadata);\n };\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex d4ab91e30..3ee7b0d65 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -292,7 +292,7 @@ void IPASoftSimple::computeParams(const uint32_t frame)\n \t\talgo->prepare(context_, frame, frameContext, params_);\n \tparams_->combinedMatrix = context_.activeState.combinedMatrix;\n \n-\tsetIspParams.emit();\n+\tparamsComputed.emit(frame);\n }\n \n void IPASoftSimple::processStats(const uint32_t frame,\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 137341fe2..7efd5cf4c 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -170,7 +170,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\treturn;\n \t}\n \n-\tipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams);\n+\tipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams);\n \tipa_->metadataReady.connect(this,\n \t\t\t\t [this](uint32_t frame, const ControlList &metadata) {\n \t\t\t\t\t metadataReady.emit(frame, metadata);\n@@ -431,7 +431,7 @@ void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *outpu\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n-void SoftwareIsp::saveIspParams()\n+void SoftwareIsp::saveIspParams([[maybe_unused]] uint32_t frame)\n {\n \tdebayerParams_ = *sharedParams_;\n }\n","prefixes":["v2","2/7"]}