[{"id":39791,"web_url":"https://patchwork.libcamera.org/comment/39791/","msgid":"<56a32e5a-ffce-4bb7-afe6-f5b3742ff0ce@nxsw.ie>","date":"2026-07-22T09:24:10","subject":"Re: [PATCH v2 3/7] camss: Add cammss utility functions","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 21/07/2026 15:59, Hans de Goede wrote:\n> Add camss_util.[h|cpp] files with some small helper functions shared\n> between Camss* classes.\n> \n> Signed-off-by: Hans de Goede \n\n:g/cammss/s//camss/g\n\n> ---\n> src/libcamera/pipeline/camss/camss_util.cpp | 39 +++++++++++++++++++++\n> src/libcamera/pipeline/camss/camss_util.h | 19 ++++++++++\n> 2 files changed, 58 insertions(+)\n> create mode 100644 src/libcamera/pipeline/camss/camss_util.cpp\n> create mode 100644 src/libcamera/pipeline/camss/camss_util.h\n> \n> diff --git a/src/libcamera/pipeline/camss/camss_util.cpp b/src/libcamera/pipeline/camss/camss_util.cpp\n> new file mode 100644\n> index 000000000..96b1bbc72\n> --- /dev/null\n> +++ b/src/libcamera/pipeline/camss/camss_util.cpp\n> @@ -0,0 +1,39 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Qualcomm CAMSS utility functions\n> + *\n> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n> + */\n> +\n> +#include \"camss_util.h\"\n> +\n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/v4l2_videodevice.h\"\n> +\n> +namespace libcamera {\n> +\n> +LOG_DECLARE_CATEGORY(Camss)\n> +\n> +bool camssV4L2DeviceFormatMatchesStreamConfig(const V4L2DeviceFormat &fmt,\n> +\t\t\t\t\t const StreamConfiguration &cfg,\n> +\t\t\t\t\t const char *msgPrefix)\n> +{\n> +\tif (cfg.pixelFormat != fmt.fourcc.toPixelFormat(false) || cfg.size != fmt.size ||\n> +\t cfg.stride != fmt.planes[0].bpl) {\n> +\t\tLOG(Camss, Error)\n> +\t\t\t<< msgPrefix\n> +\t\t\t<< \" StreamConfiguration vs V4L2DeviceFormat mismatch\"\n> +\t\t\t<< \" pixelFormat \" << cfg.pixelFormat << \", \" << fmt.fourcc.toPixelFormat(false)\n> +\t\t\t<< \" size \" << cfg.size << \", \" << fmt.size\n> +\t\t\t<< \" stride \" << cfg.stride << \", \" << fmt.planes[0].bpl\n> +\t\t\t<< \" frameSize \" << cfg.frameSize << \", \" << fmt.planes[0].size;\n> +\t\treturn false;\n> +\t}\n> +\n> +\treturn true;\n> +}\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/camss/camss_util.h b/src/libcamera/pipeline/camss/camss_util.h\n> new file mode 100644\n> index 000000000..111c305aa\n> --- /dev/null\n> +++ b/src/libcamera/pipeline/camss/camss_util.h\n> @@ -0,0 +1,19 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Qualcomm CAMSS utility functions\n> + *\n> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n> + */\n> +\n> +#pragma once\n> +\n> +namespace libcamera {\n> +\n> +struct StreamConfiguration;\n> +class V4L2DeviceFormat;\n> +\n> +bool camssV4L2DeviceFormatMatchesStreamConfig(const V4L2DeviceFormat &fmt,\n> +\t\t\t\t\t const StreamConfiguration &cfg,\n> +\t\t\t\t\t const char *msgPrefix);\n> +\n> +} /* namespace libcamera */\n> --\n> 2.55.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A063BDE4C\n\tfor ;\n\tWed, 22 Jul 2026 09:24:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90F7367E87;\n\tWed, 22 Jul 2026 11:24:20 +0200 (CEST)","from mail-4318.protonmail.ch (mail-4318.protonmail.ch\n\t[185.70.43.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1619C61451\n\tfor ;\n\tWed, 22 Jul 2026 11:24:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxsw.ie header.i=@nxsw.ie header.b=\"Ln+PJxEw\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxsw.ie;\n\ts=protonmail; t=1784712254; x=1784971454;\n\tbh=xGQhmi4NF/AkEGYJd6NBzEii6RZitcO0kkQrjMDCc0E=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=Ln+PJxEwA5UeIczhFR68yqhxiiK7zugUDCCcxnBcdUx9saOVzoirj4nYFSeZcwvuX\n\tRP6qwEgnNVdeTkr6Tl4BsnxFZ65WTKuOm+lE+94NTv77000TGzVXVh06jkVDBix4ev\n\tUeL32M7SXEkAqHyCWFkm5cPwo/GPGlk5iL3hGjdM95Z5zX3krfyIRk3DGRTTapC+FR\n\tL21yau48YQvn12gKPREBD8d1Yh0LzUoEKx+RJlT6P3Gn0pY/b84jFRAvA4Mg5u6Du3\n\tYXgMSoNaJyQVIQLlu5pSqX1oslmkCREERYnK36YqlYW8/5gfJAJhNzSqM5RNsEnIzV\n\tgO0QlOpJD4rmQ==","Date":"Wed, 22 Jul 2026 09:24:10 +0000","To":"Hans de Goede ,\n\tlibcamera-devel@lists.libcamera.org","From":"Bryan O'Donoghue ","Cc":"Loic Poulain ","Subject":"Re: [PATCH v2 3/7] camss: Add cammss utility functions","Message-ID":"<56a32e5a-ffce-4bb7-afe6-f5b3742ff0ce@nxsw.ie>","In-Reply-To":"<20260721145958.68489-4-johannes.goede@oss.qualcomm.com>","References":"<20260721145958.68489-1-johannes.goede@oss.qualcomm.com>\n\t<20260721145958.68489-4-johannes.goede@oss.qualcomm.com>","Feedback-ID":"136405006:user:proton","X-Pm-Message-ID":"b4a2611f589cd054fb5c660a3b3f268c50010d41","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]