[{"id":3665,"web_url":"https://patchwork.libcamera.org/comment/3665/","msgid":"<20200211192927.GD20823@pendragon.ideasonboard.com>","date":"2020-02-11T19:29:27","subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Tue, Jan 28, 2020 at 10:31:55PM -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne \n> \n> This will allow selecting libcamerasrc traces with the following\n> environment:\n> \n> GST_DEBUG=libcamerasrc:7\n> \n> Or all libcamera GStreamer element traces using\n> \n> GST_DEBUG=\"libcamera*:7\"\n> \n> Signed-off-by: Nicolas Dufresne \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 74e1d7e..2177a8d 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -10,6 +10,9 @@\n> #include \"gstlibcamerapad.h\"\n> #include \"gstlibcamera-utils.h\"\n> \n> +GST_DEBUG_CATEGORY_STATIC(source_debug);\n> +#define GST_CAT_DEFAULT source_debug\n> +\n> struct _GstLibcameraSrc {\n> \tGstElement parent;\n> \tGstPad *srcpad;\n> @@ -21,7 +24,9 @@ enum {\n> \tPROP_CAMERA_NAME\n> };\n> \n> -G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);\n> +G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n> +\t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n> +\t\t\t\t\t\t\"LibCamera Source\"));\n\ns/LibCamera/libcamera/ (see branding comment in a previous patch).\n\n\nReviewed-by: Laurent Pinchart \n\n> \n> #define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw;image/jpeg\")\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1FBD60F3C\n\tfor ;\n\tTue, 11 Feb 2020 20:29:42 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A1429DA;\n\tTue, 11 Feb 2020 20:29:42 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581449382;\n\tbh=4AqzLwaJNqv3XmzEQDWyssdgm4MEm/e0eDK0f9kDoOY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OZlkspKT76+Iq50Yb+FoPpOEy25ecjtP0nkRP6R+KvrhU+Pcq4ltFXggL/hNiKkeV\n\tVXdE4RM5KlOHxymvhhMc/1UFCNW27xhMpc/ILm8TqL52EK6RWu6wRl9jdkKlbK3d6/\n\tG1zf6FOhq8fc1AM6AMglYOFy828jyA4aTP7D4fdI=","Date":"Tue, 11 Feb 2020 21:29:27 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne ","Message-ID":"<20200211192927.GD20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-9-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200129033210.278800-9-nicolas@ndufresne.ca>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 19:29:43 -0000"}},{"id":3671,"web_url":"https://patchwork.libcamera.org/comment/3671/","msgid":"","date":"2020-02-11T21:57:28","subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"On mar, 2020-02-11 at 21:29 +0200, Laurent Pinchart wrote:\n> Hi Nicolas,\n> \n> Thank you for the patch.\n> \n> On Tue, Jan 28, 2020 at 10:31:55PM -0500, Nicolas Dufresne wrote:\n> > From: Nicolas Dufresne \n> > \n> > This will allow selecting libcamerasrc traces with the following\n> > environment:\n> > \n> > GST_DEBUG=libcamerasrc:7\n> > \n> > Or all libcamera GStreamer element traces using\n> > \n> > GST_DEBUG=\"libcamera*:7\"\n> > \n> > Signed-off-by: Nicolas Dufresne \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 7 ++++++-\n> > 1 file changed, 6 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> > b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 74e1d7e..2177a8d 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -10,6 +10,9 @@\n> > #include \"gstlibcamerapad.h\"\n> > #include \"gstlibcamera-utils.h\"\n> > \n> > +GST_DEBUG_CATEGORY_STATIC(source_debug);\n> > +#define GST_CAT_DEFAULT source_debug\n> > +\n> > struct _GstLibcameraSrc {\n> > \tGstElement parent;\n> > \tGstPad *srcpad;\n> > @@ -21,7 +24,9 @@ enum {\n> > \tPROP_CAMERA_NAME\n> > };\n> > \n> > -G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);\n> > +G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src,\n> > GST_TYPE_ELEMENT,\n> > +\t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n> > +\t\t\t\t\t\t\"LibCamera Source\"));\n> \n> s/LibCamera/libcamera/ (see branding comment in a previous patch).\n\nAs per GStreamer style, I would need to use snake gst_lib_camera_ then, are you\nok with that change ? I'm still wondering if I should try and find a nickname,\nbut haven't really found a good one, or any guidelines.\n\n> \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > \n> > #define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw;image/jpeg\")\n> >","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3677A60F3C\n\tfor ;\n\tTue, 11 Feb 2020 22:57:38 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9211728B90C;\n\tTue, 11 Feb 2020 21:57:37 +0000 (GMT)"],"Message-ID":"","From":"Nicolas Dufresne ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Date":"Tue, 11 Feb 2020 16:57:28 -0500","In-Reply-To":"<20200211192927.GD20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-9-nicolas@ndufresne.ca>\n\t<20200211192927.GD20823@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.34.3 (3.34.3-1.fc31) ","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 21:57:38 -0000"}},{"id":3675,"web_url":"https://patchwork.libcamera.org/comment/3675/","msgid":"<20200211230957.GJ20823@pendragon.ideasonboard.com>","date":"2020-02-11T23:09:57","subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn Tue, Feb 11, 2020 at 04:57:28PM -0500, Nicolas Dufresne wrote:\n> On mar, 2020-02-11 at 21:29 +0200, Laurent Pinchart wrote:\n> > On Tue, Jan 28, 2020 at 10:31:55PM -0500, Nicolas Dufresne wrote:\n> > > From: Nicolas Dufresne \n> > > \n> > > This will allow selecting libcamerasrc traces with the following\n> > > environment:\n> > > \n> > > GST_DEBUG=libcamerasrc:7\n> > > \n> > > Or all libcamera GStreamer element traces using\n> > > \n> > > GST_DEBUG=\"libcamera*:7\"\n> > > \n> > > Signed-off-by: Nicolas Dufresne \n> > > ---\n> > > src/gstreamer/gstlibcamerasrc.cpp | 7 ++++++-\n> > > 1 file changed, 6 insertions(+), 1 deletion(-)\n> > > \n> > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> > > b/src/gstreamer/gstlibcamerasrc.cpp\n> > > index 74e1d7e..2177a8d 100644\n> > > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > > @@ -10,6 +10,9 @@\n> > > #include \"gstlibcamerapad.h\"\n> > > #include \"gstlibcamera-utils.h\"\n> > > \n> > > +GST_DEBUG_CATEGORY_STATIC(source_debug);\n> > > +#define GST_CAT_DEFAULT source_debug\n> > > +\n> > > struct _GstLibcameraSrc {\n> > > \tGstElement parent;\n> > > \tGstPad *srcpad;\n> > > @@ -21,7 +24,9 @@ enum {\n> > > \tPROP_CAMERA_NAME\n> > > };\n> > > \n> > > -G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);\n> > > +G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src,\n> > > GST_TYPE_ELEMENT,\n> > > +\t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n> > > +\t\t\t\t\t\t\"LibCamera Source\"));\n> > \n> > s/LibCamera/libcamera/ (see branding comment in a previous patch).\n> \n> As per GStreamer style, I would need to use snake gst_lib_camera_ then, are you\n> ok with that change ?\n\nEven for the last string (that would become \"libcamera Source\") ?\nLibcamera with a capital L is fine in class names such as\nGstLibcameraSrc, it's in user-visible text that we try to keep it\nlower-case (and in documentation, comments, commit messages, ...).\n\n> I'm still wondering if I should try and find a nickname,\n> but haven't really found a good one, or any guidelines.\n\nI haven't really found one either, but haven't spent too much time on\nit. The libcamera namespace prefix, in particular, is a bit long.\nAbbreviating it to libc isn't a very good idea :-)\n\n> > Reviewed-by: Laurent Pinchart \n> > \n> > > #define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw;image/jpeg\")","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9753160990\n\tfor ;\n\tWed, 12 Feb 2020 00:10:13 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D19E9DA;\n\tWed, 12 Feb 2020 00:10:12 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581462613;\n\tbh=EzNzSdO1ERfCYZIhdqnrVbIi9JZyu7KYPe84MCaXrBg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EPs0UqRJRga2WSVm7gXb2VH3tdoy4mQPsIjG8pgfwFQyo2YPpcXhhGncaPpJb/GL+\n\tEpSlQ+vOfHkI3+QCmafkr/SDGMPN7CIoeAedIY0eEP2psABa4XjKBqdxLImAzom5sF\n\twBdTqvOolNOtjEJE/AX1N1d4HS8pC6JVxm3doT9k=","Date":"Wed, 12 Feb 2020 01:09:57 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200211230957.GJ20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-9-nicolas@ndufresne.ca>\n\t<20200211192927.GD20823@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 23:10:13 -0000"}},{"id":3677,"web_url":"https://patchwork.libcamera.org/comment/3677/","msgid":"<159c8f43e91d1aecd724fbb4a3c42a2b09a1697c.camel@collabora.com>","date":"2020-02-11T23:15:35","subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"On mer, 2020-02-12 at 01:09 +0200, Laurent Pinchart wrote:\n> Hi Nicolas,\n> \n> On Tue, Feb 11, 2020 at 04:57:28PM -0500, Nicolas Dufresne wrote:\n> > On mar, 2020-02-11 at 21:29 +0200, Laurent Pinchart wrote:\n> > > On Tue, Jan 28, 2020 at 10:31:55PM -0500, Nicolas Dufresne wrote:\n> > > > From: Nicolas Dufresne \n> > > > \n> > > > This will allow selecting libcamerasrc traces with the following\n> > > > environment:\n> > > > \n> > > > GST_DEBUG=libcamerasrc:7\n> > > > \n> > > > Or all libcamera GStreamer element traces using\n> > > > \n> > > > GST_DEBUG=\"libcamera*:7\"\n> > > > \n> > > > Signed-off-by: Nicolas Dufresne \n> > > > ---\n> > > > src/gstreamer/gstlibcamerasrc.cpp | 7 ++++++-\n> > > > 1 file changed, 6 insertions(+), 1 deletion(-)\n> > > > \n> > > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> > > > b/src/gstreamer/gstlibcamerasrc.cpp\n> > > > index 74e1d7e..2177a8d 100644\n> > > > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > > > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > > > @@ -10,6 +10,9 @@\n> > > > #include \"gstlibcamerapad.h\"\n> > > > #include \"gstlibcamera-utils.h\"\n> > > > \n> > > > +GST_DEBUG_CATEGORY_STATIC(source_debug);\n> > > > +#define GST_CAT_DEFAULT source_debug\n> > > > +\n> > > > struct _GstLibcameraSrc {\n> > > > \tGstElement parent;\n> > > > \tGstPad *srcpad;\n> > > > @@ -21,7 +24,9 @@ enum {\n> > > > \tPROP_CAMERA_NAME\n> > > > };\n> > > > \n> > > > -G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);\n> > > > +G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src,\n> > > > GST_TYPE_ELEMENT,\n> > > > +\t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n> > > > +\t\t\t\t\t\t\"LibCamera Source\"));\n> > > \n> > > s/LibCamera/libcamera/ (see branding comment in a previous patch).\n> > \n> > As per GStreamer style, I would need to use snake gst_lib_camera_ then, are you\n> > ok with that change ?\n> \n> Even for the last string (that would become \"libcamera Source\") ?\n> Libcamera with a capital L is fine in class names such as\n> GstLibcameraSrc, it's in user-visible text that we try to keep it\n> lower-case (and in documentation, comments, commit messages, ...).\n\n /o\\ Got it. I miss-read, and didn't realized you mean the other way around. Ok,\nI'll fix the debug category descriprion. I'll check the element meta just to\nmake sure.\n\n> \n> > I'm still wondering if I should try and find a nickname,\n> > but haven't really found a good one, or any guidelines.\n> \n> I haven't really found one either, but haven't spent too much time on\n> it. The libcamera namespace prefix, in particular, is a bit long.\n> Abbreviating it to libc isn't a very good idea :-)\n\nLol, would be rather confusing. For the element name, I also considered\ncamerasrc, but that felt a bit pretentious even if the name is free. It might\nwould be confusing with camerasrcwrapper and camerasrcbin though (the Nokia\nGStreamer API for cameras, with the GstPhotography interface).\n\n> \n> > > Reviewed-by: Laurent Pinchart \n> > > \n> > > > #define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw;image/jpeg\")","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFEED60990\n\tfor ;\n\tWed, 12 Feb 2020 00:15:44 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 200532933EC;\n\tTue, 11 Feb 2020 23:15:44 +0000 (GMT)"],"Message-ID":"<159c8f43e91d1aecd724fbb4a3c42a2b09a1697c.camel@collabora.com>","From":"Nicolas Dufresne ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Date":"Tue, 11 Feb 2020 18:15:35 -0500","In-Reply-To":"<20200211230957.GJ20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-9-nicolas@ndufresne.ca>\n\t<20200211192927.GD20823@pendragon.ideasonboard.com>\n\t\n\t<20200211230957.GJ20823@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.34.3 (3.34.3-1.fc31) ","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 08/23] gst: libcamerasrc: Add a\n\tdebug category","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 11 Feb 2020 23:15:44 -0000"}}]