{"id":27403,"url":"https://patchwork.libcamera.org/api/patches/27403/?format=json","web_url":"https://patchwork.libcamera.org/patch/27403/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260720-libipa-algorithms-v6-11-ececb73f97cb@ideasonboard.com>","date":"2026-07-20T14:59:29","name":"[v6,11/31] ipa: libipa: lsc_polynomial: Fix polynomial parsing error","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ea3fe6daf01db745db5a4b35986ba7698397b649","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27403/mbox/","series":[{"id":6067,"url":"https://patchwork.libcamera.org/api/series/6067/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6067","date":"2026-07-20T14:59:18","name":"ipa: libipa: Introduce libipa algorithms","version":6,"mbox":"https://patchwork.libcamera.org/series/6067/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27403/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27403/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADC6CC3301\n\tfor ;\n\tMon, 20 Jul 2026 15:00:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 426C767E7A;\n\tMon, 20 Jul 2026 17:00:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 723F867E59\n\tfor ;\n\tMon, 20 Jul 2026 16:59:47 +0200 (CEST)","from [192.168.1.106] (mob-5-90-63-152.net.vodafone.it\n\t[5.90.63.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C4BA1CE4;\n\tMon, 20 Jul 2026 16:58:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cL2KVdYI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784559528;\n\tbh=iym+xPwKbdXJhKWKBEgCczMlRqIVu/lwQ9sWa5xwMiM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=cL2KVdYIt30MwF0jOEgPhbi7x7dsYAW1Dz6uGTE0rxTepJ9XG+gdsi0w25vxc4O6p\n\tWtpda0W7yeVcqSx8lqDkBlwZ25T4myBZOYlXHKFwnCI/i6/ZhG+RweAqbqB5MzAhj+\n\tIpPVEZFzP3rI/GwMwa0JkZs8FZODwqluq793OzcA=","From":"Jacopo Mondi ","Date":"Mon, 20 Jul 2026 16:59:29 +0200","Subject":"[PATCH v6 11/31] ipa: libipa: lsc_polynomial: Fix polynomial\n\tparsing error","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260720-libipa-algorithms-v6-11-ececb73f97cb@ideasonboard.com>","References":"<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>","In-Reply-To":"<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug , \n\tMilan Zamazal ","Cc":"Jacopo Mondi , \n\tKieran Bingham ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1449;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=iym+xPwKbdXJhKWKBEgCczMlRqIVu/lwQ9sWa5xwMiM=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqXjfVuoMw8MRDh/cnraXJOFEmNhkcJcRwMRPsk\n\tCBp7O1J3taJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCal431QAKCRByNAaPFqFW\n\tPEy/D/4/AIUX6KFle4czQIDfm0NkpWcaMEwb3dYYERR+JPf6t8MlqWLwgO7U9zLNU3wVEO+V5Yv\n\txkUPzV+Fo5xqmS/dC/NSjbut47I1UopGPIVmEk2tmEI8LBY7RgoWOUbh5Jf0O//UUpbrjxNXzRS\n\tSy5p0ZvvYp+wYnCb4b1Ss59rG9GQSih/NCQR+znbEmimAqVypIJTlM3goAGgBOHdFHo2/PWLC+0\n\t6EGyCtXPQezdBiJB3r0Nx8RIm3f60+j7OjL6KHK7Kdsyvk/BPLN3fW85l1JaDIUamwX4NJp5x+s\n\tUynqejYe9Hm4JmKumwhxUd/r32Kn/dAic17yOy2+0YVps5Z/1EWpLkaoCrffc1YRdizJoTwXis+\n\tmURYwShrtNwL/HML82dhJkGCtC82GE/VCS83KT/SkmkLzU79Au68UeilQLAEyDYfAIQl/GrArtQ\n\tiPNK5xhnZa7TuEynjacaBmUAAwacncsEbTKUTUoiei8YD4q05K9uMvB8AU41ur+lNGQ2R4MDU3Y\n\tlixiz5KCMMbJX8PeoEVw9UD5ualni5nkWEgA69nL+FiY00bCvNhR8Go5zo+OsJLrp945VLrExij\n\tr2sz7gg1C6kilfRcjXL7mwM3zFbqSTs/S3Xwq+SNxZmgQArfWb6pt4dzXte/zrtJgFFsteM2hom\n\tAgV8pjcGXkMHnlw==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If any of the polynomial component is missing in the tuning file the\nValueNode::Accessor specialization emits an\nerror message but continues and dereferences a potentially\ninvalid object.\n\nFix it by returning std::nullopt if a polynomial component is missing.\n\nThe caller already checks if the returned value is valid or not, causing\nthe algorithm initialization to fail if the tuning file is invalid.\n\nSuggested-by: Milan Zamazal \nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \nReviewed-by: Stefan Klug \n---\n src/ipa/libipa/lsc_polynomial.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex d7d9ae42e360..a0d27c4b21d6 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -94,9 +94,11 @@ struct ValueNode::Accessor {\n \t\tstd::optional k3 = obj[\"k3\"].get();\n \t\tstd::optional k4 = obj[\"k4\"].get();\n \n-\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n+\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n \t\t\tLOG(LscPolynomial, Error)\n \t\t\t\t<< \"Polynomial is missing a parameter\";\n+\t\t\treturn std::nullopt;\n+\t\t}\n \n \t\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n \t}\n","prefixes":["v6","11/31"]}