[{"id":3663,"web_url":"https://patchwork.libcamera.org/comment/3663/","msgid":"<20200211192415.GB20823@pendragon.ideasonboard.com>","date":"2020-02-11T19:24:16","subject":"Re: [libcamera-devel] [PATCH v1 06/23] gst: libcamerasrc: Allocate\n\tand add static pad","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Tue, Jan 28, 2020 at 10:31:53PM -0500, Nicolas Dufresne wrote:\n> From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nA commit message could be nice. Apart from that,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n> ---\n>  src/gstreamer/gstlibcamerasrc.cpp | 5 +++++\n>  1 file changed, 5 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index a8bcede..50bba39 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -11,6 +11,7 @@\n>  \n>  struct _GstLibcameraSrc {\n>  \tGstElement parent;\n> +\tGstPad *srcpad;\n>  };\n>  \n>  G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);\n> @@ -30,6 +31,10 @@ GstStaticPadTemplate request_src_template = {\n>  static void\n>  gst_libcamera_src_init(GstLibcameraSrc *self)\n>  {\n> +\tGstPadTemplate *templ = gst_element_get_pad_template(GST_ELEMENT(self), \"src\");\n> +\n> +\tself->srcpad = gst_pad_new_from_template(templ, \"src\");\n> +\tgst_element_add_pad(GST_ELEMENT(self), self->srcpad);\n>  }\n>  \n>  static void","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C64C960F3C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Feb 2020 20:24:32 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D7EE9DA;\n\tTue, 11 Feb 2020 20:24:31 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1581449072;\n\tbh=Nk/Hd0aVkoG0ijXoESDMn2vLROFL7ttuic8zn0Qs5AY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sSTj6WVCVbOQuybfMRzcoO+cbUdI6lvv5vyUq2lx8n6N7ftgyR0aqAxzARxGDseCC\n\t5aCLmln+7wmguiZnve5bw5TyNbpN/s8uwLrPOSLi8B7h6uXDT2gOIIVWCpFtcc0+L9\n\t8+pb/GeMsVanLJZCiSVcMkmx56jAV6ypQgpkmbjE=","Date":"Tue, 11 Feb 2020 21:24:16 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Nicolas Dufresne <nicolas@ndufresne.ca>","Cc":"libcamera-devel@lists.libcamera.org,\n\tNicolas Dufresne <nicolas.dufresne@collabora.com>","Message-ID":"<20200211192415.GB20823@pendragon.ideasonboard.com>","References":"<20200129033210.278800-1-nicolas@ndufresne.ca>\n\t<20200129033210.278800-7-nicolas@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200129033210.278800-7-nicolas@ndufresne.ca>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v1 06/23] gst: libcamerasrc: Allocate\n\tand add static pad","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 11 Feb 2020 19:24:33 -0000"}}]