[{"id":39787,"web_url":"https://patchwork.libcamera.org/comment/39787/","msgid":"<178471070253.2174993.2670786109586127032@ping.linuxembedded.co.uk>","date":"2026-07-22T08:58:22","subject":"Re: [PATCH v1 1/2] libcamera: camera_sensor: Add Sony IMX662 sensor\n\tproperties and helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2026-07-20 14:07:55)\n> Add the camera sensor properties and camera helper entry for the Sony\n> IMX662 sensor.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 10 ++++++++++\n> 2 files changed, 22 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 54a88c55bc2d..14d9690c1864 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -642,6 +642,18 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> \n> +class CameraSensorHelperImx662 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperImx662()\n> + {\n> + /* From datasheet: 0xc8 at 12bits. */\n> + blackLevel_ = 3200;\n> + gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };\n\nMatches what I interpret:\n\nReviewed-by: Kieran Bingham \n\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx662\", CameraSensorHelperImx662)\n> +\n> class CameraSensorHelperImx678 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 7685524ad189..3672e8f0d79b 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -309,6 +309,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .hblankDelay = 3\n> },\n> } },\n> + { \"imx662\", {\n> + .unitCellSize = { 2900, 2900 },\n> + .testPatternModes = {},\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n\nThe timing diagram on page 9 looks like it's only a gainDelay of 1 ? But\nI never understand the real timings here, and I still want a tool that\nwill just measure the reality!\n\n\n\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> { \"imx678\", {\n> .unitCellSize = { 2000, 2000 },\n> .testPatternModes = {},\n> -- \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E974BDE17\n\tfor ;\n\tWed, 22 Jul 2026 08:58:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C05767E8A;\n\tWed, 22 Jul 2026 10:58:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACDE561451\n\tfor ;\n\tWed, 22 Jul 2026 10:58:25 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B17C447;\n\tWed, 22 Jul 2026 10:57:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fcn9qoTC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784710645;\n\tbh=HGf+nNqhZeIQE2Z6z6r0qB76CvoyPd6NDqMGNnaZBJk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Fcn9qoTCRjulzjbEpqz/XVSrq855UNyhogsWdlx37vAfpt+kU1qmMMkIWp6ydTJip\n\tidqUaNHjFZO/9rDnjNffA6/b6xra3c37EHF4uIQjm3w0Jpx5DglSOPbK/kGwJcsTTn\n\tjNhjKFDSSY9dNgWcjKe1IOqEO/sj9+3baMOfD72s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260720131047.2749510-2-naush@raspberrypi.com>","References":"<20260720131047.2749510-1-naush@raspberrypi.com>\n\t<20260720131047.2749510-2-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 1/2] libcamera: camera_sensor: Add Sony IMX662 sensor\n\tproperties and helper","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 22 Jul 2026 09:58:22 +0100","Message-ID":"<178471070253.2174993.2670786109586127032@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39789,"web_url":"https://patchwork.libcamera.org/comment/39789/","msgid":"","date":"2026-07-22T09:10:06","subject":"Re: [PATCH v1 1/2] libcamera: camera_sensor: Add Sony IMX662 sensor\n\tproperties and helper","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nOn Wed, 22 Jul 2026 at 09:58, Kieran Bingham\n wrote:\n>\n> Quoting Naushir Patuck (2026-07-20 14:07:55)\n> > Add the camera sensor properties and camera helper entry for the Sony\n> > IMX662 sensor.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n> > src/libcamera/sensor/camera_sensor_properties.cpp | 10 ++++++++++\n> > 2 files changed, 22 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index 54a88c55bc2d..14d9690c1864 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -642,6 +642,18 @@ public:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> >\n> > +class CameraSensorHelperImx662 : public CameraSensorHelper\n> > +{\n> > +public:\n> > + CameraSensorHelperImx662()\n> > + {\n> > + /* From datasheet: 0xc8 at 12bits. */\n> > + blackLevel_ = 3200;\n> > + gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };\n>\n> Matches what I interpret:\n>\n> Reviewed-by: Kieran Bingham \n>\n> > + }\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"imx662\", CameraSensorHelperImx662)\n> > +\n> > class CameraSensorHelperImx678 : public CameraSensorHelper\n> > {\n> > public:\n> > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > index 7685524ad189..3672e8f0d79b 100644\n> > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > @@ -309,6 +309,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > .hblankDelay = 3\n> > },\n> > } },\n> > + { \"imx662\", {\n> > + .unitCellSize = { 2900, 2900 },\n> > + .testPatternModes = {},\n> > + .sensorDelays = {\n> > + .exposureDelay = 2,\n> > + .gainDelay = 2,\n>\n> The timing diagram on page 9 looks like it's only a gainDelay of 1 ? But\n> I never understand the real timings here, and I still want a tool that\n> will just measure the reality!\n>\n>\n>\n> > + .vblankDelay = 2,\n> > + .hblankDelay = 2\n> > + },\n> > + } },\n> > { \"imx678\", {\n> > .unitCellSize = { 2000, 2000 },\n> > .testPatternModes = {},\n> > --\n> >\n\nReviewed-by: David Plowman \n\nThanks!\n\nDavid","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D562EBDE17\n\tfor ;\n\tWed, 22 Jul 2026 09:10:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA12B67E86;\n\tWed, 22 Jul 2026 11:10:19 +0200 (CEST)","from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10D6761451\n\tfor ;\n\tWed, 22 Jul 2026 11:10:19 +0200 (CEST)","by mail-ed1-x52d.google.com with SMTP id\n\t4fb4d7f45d1cf-69e54d9c8c6so4743587a12.0\n\tfor ;\n\tWed, 22 Jul 2026 02:10:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"GTZrt2Jc\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1784711418; cv=none;\n\td=google.com; s=arc-20260327;\n\tb=l6W0enux+jOJOH3Zj7eepRKYO3ZKIMWeKKxYUCsPDeSEKwL+/7J0y3Mpc2qupMxmOD\n\t+Nv2U2lp5cImVtdXu85PhedI3EyIpc+u2cig0dKBvZLUP/XizX0AyIm8NTzwwdAeyxmm\n\tdV57otd+9aui5MVumqoraaez7vlVv+0tZMoJpTpAEsWjaxwROuCEChxUP4wL5+/YTedt\n\tjuauWHpmlw9ayrEV6dRlRPUm5u/ixseeGHMf7fNqQHpGpoeZbQi/WuJ2tJkhFXLnaIT0\n\tx2BZaVcmr9nG00M7u7EQ9IcMt5IZf7r/AknYkdpQZSC3+OanUxgLRMjcF6ZcMEmtlGsY\n\tzxBA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20260327; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=7h/cFCRf1OW8r/UlTiLohEDN5OECfQp/sdTEf6aqDlQ=;\n\tfh=aFRl9KeXi22JLsoJRhLPmdAlZYQe2WzM/QHnGJZnnJ0=;\n\tb=U2MwrErWJY93SzTyiZrzFI29U59iHSRyhrhRNygILoy487IH8h3OsOLpQppxFYEnHR\n\tQtLkaG/uvIB4o1prp4wJWeutm9OPs7mCN2lc9Urnbey+gIap6duOLHxp2l5UDKgs9YBU\n\t9EIqae6ZWn9Nqz83j4b9Q8y+xq/X80j2CACZc2Ozxhoy9KIDlGTda9+OjwlyGcNp2Ag+\n\tzXVVBBdWLAZKZAlwuk1SZb+o2Q6RPqrMcYFquVpKrUAZFIxfMMU1zbGUGPtYACJHDilw\n\tDVJLbWH5bj+gqbADU4lCozDm07eZLU99OGjNuHSg72N1RPUGm3QstpZJWBKNzHA2SNmH\n\tQEtw==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1784711418; x=1785316218;\n\tdarn=lists.libcamera.org; \n\th=content-type:cc:to:subject:message-id:date:from:in-reply-to\n\t:references:mime-version:from:to:cc:subject:date:message-id:reply-to\n\t:content-type; bh=7h/cFCRf1OW8r/UlTiLohEDN5OECfQp/sdTEf6aqDlQ=;\n\tb=GTZrt2JcKoB81SYrV3gtvb+ZLLHvvo24WEI8kgkF7u21zNPlIiwpHYeco9X9Q2/FyZ\n\td7l1pvYikip99Wpkf6RoIj3i7boDL8N5zOrNJZTZUAiH05kgKDJFu13iELwviKNLirsq\n\t+s+7d82bVB1MTH09AVp1gCOgBoU2WuqZZc7MxMHoyfvi8iAiSh6D39DJHY3Jls1/pwgc\n\tr3AEfJAfDrQ8LK2+vHn10xFbQ3ZcxWGtyZviyQj2oYcy1RXKCefBdJO2Kpr3J1s6KPJ0\n\tLvfoSdtBfUuO5Pg+U9UnoXLmodk8UvRcTo7bHiqOF0+clXDM9gfXI3Ic/BQ7RgsilkDa\n\t0Qdw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1784711418; x=1785316218;\n\th=content-type:cc:to:subject:message-id:date:from:in-reply-to\n\t:references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to:content-type;\n\tbh=7h/cFCRf1OW8r/UlTiLohEDN5OECfQp/sdTEf6aqDlQ=;\n\tb=mGFYQkjT8GXYPxjNjPKiGbKGrVT42KMLdw/8JMeGWiNr4jK3vv33rQ9JJfBEergwSp\n\tXIJGHwrj4OVcJBY4oMQLbVWb4q9JOfhSSbmZvKycNwkU1PQsd0Kx+9GYuO7bG4H+DcnE\n\tdiWD42kUYiZwtvIMgBGIlXDLqQVJ+qIbCkpnOg1mDWOzmu22sn0+kaYfkIB58ld0QtL5\n\tbzsYo2+9J4ECjkuqzeINeV+J1ETx4JiYeERfqfuBreLtbvU80lqogoXOs31IPzO3dlFo\n\t8diCNXSGFkEUB7aNH54mafF1fEqYSS+lhozttBpL6HrtmkRif9qaCnB0t5M5oH9f4aUp\n\t318g==","X-Forwarded-Encrypted":"i=1;\n\tAHgh+RrgH7zgZeyeNOVxhINJEmuMqFUhnUvOg/RNB+WUFqmtzxQMaN3ahOhJbYFSQe+kk6FaFVZwkRo0hrFQDrg78/0=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxwMndyMpQxpJRiLicjKRN51K1hTuG1gaSExqXK/S5UAV5ahRHv\n\tOuH+5SGrcglYkYVhCGMrelXzJg89MN/xN8diCrYqy9ixIGR8fpP8BKMtgpaeRAQeQSuru0PD6VH\n\tQ5mZW+004flFP15Oh6S2MU35jLxmI41QGLis+RT+YJA==","X-Gm-Gg":"AR+sD10ag9eZ7j59Hwr7oCVw18X586YM/rh4y5YKvWygZenq8VQFSD8CQg6NiAa+9TZ\n\tBL9Nz84C2Eekw0Ic6ZYaNpHIFyXDpRx4QdGK9CqqOHDWwxKnb4KY5xySPfji6zZjfsMHuBPb5Qu\n\t7ige4Po10RyD+aZauxWq4PAgkUscnGcp9j5O4fRmgjIs0mjq91SxWHFhJTJRRvrlQoCwDqK0dmV\n\t6vWcjvZzqKIn4IRX14lsvylcyRIZ7LRf5ciIjrLOF8z30jhAiSot6Dm4OzLnGuJTBWlUcCvGVs3\n\tl5NcFBaBaV4c7I6ENLg4eiDcFW69phpJiLvfJ3atZr5UFGmIAUG8q08EQk7ZQg8M6xsSrQaRw71\n\tpIrbDR1BOPfGD","X-Received":"by 2002:a05:6402:2353:b0:697:daf8:6090 with SMTP id\n\t4fb4d7f45d1cf-69e65240470mr8244849a12.15.1784711418314;\n\tWed, 22 Jul 2026 02:10:18 -0700 (PDT)","MIME-Version":"1.0","References":"<20260720131047.2749510-1-naush@raspberrypi.com>\n\t<20260720131047.2749510-2-naush@raspberrypi.com>\n\t<178471070253.2174993.2670786109586127032@ping.linuxembedded.co.uk>","In-Reply-To":"<178471070253.2174993.2670786109586127032@ping.linuxembedded.co.uk>","From":"David Plowman ","Date":"Wed, 22 Jul 2026 10:10:06 +0100","X-Gm-Features":"AUfX_mz1soQ5HAay44xdkGI8jfbiqTlP4OcUizWmzgWoR7z629gZp6ry7s_lGFo","Message-ID":"","Subject":"Re: [PATCH v1 1/2] libcamera: camera_sensor: Add Sony IMX662 sensor\n\tproperties and helper","To":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]