[{"id":39693,"web_url":"https://patchwork.libcamera.org/comment/39693/","msgid":"<20260714081426.GL1127719@killaraus.ideasonboard.com>","date":"2026-07-14T08:14:26","subject":"Re: [PATCH] libcamera: camera_sensor: Add IMX335 test pattern sensor\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jul 14, 2026 at 12:08:43PM +0900, Paul Elder wrote:\n> Add sensor properties for the IMX335 for the test pattern mode.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index b18524d85b37..91e2ce628794 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -117,7 +117,11 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t} },\n> \t\t{ \"imx335\", {\n> \t\t\t.unitCellSize = { 2000, 2000 },\n> -\t\t\t.testPatternModes = {},\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeSolidColor, 4 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 12}\n\nMissing space before } and trailing comma.\n\n> +\t\t\t},\n> \t\t} },\n> \t\t{ \"imx415\", {\n> \t\t\t.unitCellSize = { 1450, 1450 },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDBBAC328C\n\tfor ;\n\tTue, 14 Jul 2026 08:14:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEF9366135;\n\tTue, 14 Jul 2026 10:14:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9449A660AE\n\tfor ;\n\tTue, 14 Jul 2026 10:14:27 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DB3D6AF;\n\tTue, 14 Jul 2026 10:13:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eRZKyiaW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784016813;\n\tbh=PGgwQyNyNbUOfofjjS7ISvvRA8AqR7OTHfAgqOxyue0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eRZKyiaWtrPBj1wq7anSryQcwb4B8acIklnhuPVUl0teYk8M6/R4qVLsj9q89Q2Me\n\tZaWd3To/flOAq1ChwoiVMxv6El+XNpqZRba8sYkJqjuujfR2KQ67L7xmVfegir7zeX\n\tSm87T69PZQhpkz1NVjE0D5mmlJuf+QSJjUBpYmcU=","Date":"Tue, 14 Jul 2026 11:14:26 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: camera_sensor: Add IMX335 test pattern sensor\n\tproperties","Message-ID":"<20260714081426.GL1127719@killaraus.ideasonboard.com>","References":"<20260714030843.1191059-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260714030843.1191059-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]