{"id":27355,"url":"https://patchwork.libcamera.org/api/patches/27355/?format=json","web_url":"https://patchwork.libcamera.org/patch/27355/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260709-ov5693-v1-1-a17e72273f43@ideasonboard.com>","date":"2026-07-09T11:30:55","name":"ipa: camera_sensor_helper: Add black levels for OV5693","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b0aba1e75c5c42bb732185084e20d529a3d239a6","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27355/mbox/","series":[{"id":6053,"url":"https://patchwork.libcamera.org/api/series/6053/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6053","date":"2026-07-09T11:30:55","name":"ipa: camera_sensor_helper: Add black levels for OV5693","version":1,"mbox":"https://patchwork.libcamera.org/series/6053/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27355/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27355/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61A05C3306\n\tfor ;\n\tThu, 9 Jul 2026 11:31:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F242660DD;\n\tThu, 9 Jul 2026 13:31:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F0A465FA2\n\tfor ;\n\tThu, 9 Jul 2026 13:31:05 +0200 (CEST)","from [127.0.1.1]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BEBD6448;\n\tThu, 9 Jul 2026 13:30:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CVGOmxeJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783596614;\n\tbh=99R7e6D0xuuNUs67P0RJ1XvEHYoh+E4qiVJzW5D1wVU=;\n\th=From:Date:Subject:To:Cc:From;\n\tb=CVGOmxeJRLsIHOxonndXv20nYAnlnh1o76F3gSMrKZCMJTYHdG6Wtz/Udbp58ttXd\n\tm/GgTRHOqGzQ3/D6kAIrj1+zfgrPRor1vnro2EIDG700Tipfl44En5Z6xHyFfcfSQv\n\tsxwABPTgWQiDDc2K52Pb9aV1smHYvFEBAcDDrjjY=","From":"Daniel Scally ","Date":"Thu, 09 Jul 2026 12:30:55 +0100","Subject":"[PATCH] ipa: camera_sensor_helper: Add black levels for OV5693","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260709-ov5693-v1-1-a17e72273f43@ideasonboard.com>","X-B4-Tracking":"v=1; b=H4sIAG6GT2oC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n\tvPSU3UzU4B8JSMDIzMDMyML3fwyUzNLY11zY9PURIMUy8SUVEMloOKCotS0zAqwQdGxtbUAdSw\n\tIuFgAAAA=","X-Change-ID":"20260628-ov5693-735ea0d9ade1","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=999;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=99R7e6D0xuuNUs67P0RJ1XvEHYoh+E4qiVJzW5D1wVU=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqT4Z4UyX6W5H8njqn2fBpBIuYEbpdNH8nrv2OB\n\tMeEQWFp1WKJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCak+GeAAKCRDISVd6bEV1\n\tMjn3D/0WROiUXBaZ5oRNmM/SDLe6GBkmFz71EjSX3YjjHM7PG5u0TC0I7pIKB2ptEFEXYeLDAzl\n\tG2E8uT9reLt3S7GXPSnfVERboM4n/JaCuQ6fVPDQPGwxTLiRIvVZezk025GgcqBm7H7FGvv6NIz\n\tFQ8tcgka10z7kjX4lx1nDW0pg1R0ESOJZ0uWNSQrdw6GoQi73kCPizQ0sCkyniZkensqVKJb8GX\n\t1MwyolT5ED0lk771SDC+dX3Zgs1hgDjLO06hQGwZrSRmEQyWPYdib20CMdNo+Ywvmy3k+8a46qQ\n\tTpqv3EYYsnKbbGYyrGX3HSYwwiZKw8xk+bv1DOnzGa26zaUsWwxABNJ5kbaeSUSkundYsWofK6q\n\t6L16uH1L6o/CAdo9M6lU+UMoLX//mRhsYRh82huGTUYWi1i20nUAbRpzL90W1+hznq6Z8TkNFNe\n\t+xJbk4B073FRJcHW51axoqBL+QIsfgdIPX5gwk5qKhKqlWm0TXTbmhuDLBnKjuVgbKM3K6kg2Zn\n\t3Ef0tErMoqVsFTXntuJiN7+4vgPwKJy4NETcrRUYXt+Ks9Rsga3CSzYmFxzaHNDO6IdFQbw1MpQ\n\teq0TJbgXLKtZbWuYuwOF0/+2MsYbs9hJlJhKnXlB4ta+0iay+u0q32nz9qFRadZUsyP8/MtTgNN\n\trilUeRSNOPgcXHw==","X-Developer-Key":"i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The OmniVision OV5693 sensor has a configurable data pedestal that is\nset by default to 0x10 for 10-bit data. Add the 16-bit representation\nof that level to CameraSensorHelperOv5693.\n\nSigned-off-by: Daniel Scally \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 1 +\n 1 file changed, 1 insertion(+)\n\n\n---\nbase-commit: 32b0d940baaf182a9d01d4833e30bd340d4dc918\nchange-id: 20260628-ov5693-735ea0d9ade1\n\nBest regards,","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 9ab7a52f2644c93454520f0a20a4c3e370ce9d15..b73ecae6c1d010aad7a49cb3c1d75b4caad97c01 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -752,6 +752,7 @@ class CameraSensorHelperOv5693 : public CameraSensorHelper\n public:\n \tCameraSensorHelperOv5693()\n \t{\n+\t\tblacklevel_ = 1024;\n \t\tgain_ = AnalogueGainLinear{ 1, 0, 0, 16 };\n \t}\n };\n","prefixes":[]}