[{"id":39697,"web_url":"https://patchwork.libcamera.org/comment/39697/","msgid":"<178404798300.3931061.17175570173215738959@ping.linuxembedded.co.uk>","date":"2026-07-14T16:53:03","subject":"Re: [PATCH v5 22/36] ipa: libipa: lsc: Introduce lsc::FrameContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2026-07-08 16:51:04)\n> Introduce the Lsc algorithm frame context in lsc.h.\n> \n\nI think I'd squash this in to which ever patch is the first user, but\notherwise:\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/ipa/libipa/lsc.cpp | 11 +++++++++++\n> src/ipa/libipa/lsc.h | 5 +++++\n> 2 files changed, 16 insertions(+)\n> \n> diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\n> index 437666855354..382cafc04ab4 100644\n> --- a/src/ipa/libipa/lsc.cpp\n> +++ b/src/ipa/libipa/lsc.cpp\n> @@ -26,6 +26,17 @@ namespace lsc {\n> * \\brief Boolean flag for the LscAlgorithm enable status\n> */\n> \n> +/**\n> + * \\struct FrameContext\n> + * \\brief The LSC frame context\n> + *\n> + * \\var FrameContext::enabled\n> + * \\brief Boolean flag for the LscAlgorithm enable status\n> + *\n> + * \\var FrameContext::update\n> + * \\brief Boolean flag for the LscAlgorithm updated status\n> + */\n> +\n> } /* namespace lsc */\n> \n> } /* namespace ipa */\n> diff --git a/src/ipa/libipa/lsc.h b/src/ipa/libipa/lsc.h\n> index 18c9fa25e53a..73519564feff 100644\n> --- a/src/ipa/libipa/lsc.h\n> +++ b/src/ipa/libipa/lsc.h\n> @@ -17,6 +17,11 @@ struct ActiveState {\n> bool enabled;\n> };\n> \n> +struct FrameContext {\n> + bool enabled;\n> + bool update;\n> +};\n> +\n> } /* namespace lsc */\n> \n> } /* namespace ipa */\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E6ACBF415\n\tfor ;\n\tTue, 14 Jul 2026 16:53:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 584CB66142;\n\tTue, 14 Jul 2026 18:53:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EA9E66137\n\tfor ;\n\tTue, 14 Jul 2026 18:53:06 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B7997103F;\n\tTue, 14 Jul 2026 18:52:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cOxorP4O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784047931;\n\tbh=QAFcHr1of7Gqr0vDE+ddzLGGoQFJg5nxTPs6/70OOT4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=cOxorP4ODAghoaDnPcSM00QbT1uYrrrNGCq+I0nmha/NJihlEKqdlZMraAkLVL7So\n\tPTZTK7dnprLv6ZBHKULDKtzgp8a/1HajiCplQTXKy8jvdbGOSmpLrO23/TOdUpI8ZG\n\t/0QC5ZQOc2njdlTZZbflQAefl5UW34jr4zupHLZs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260708-libipa-algorithms-v5-22-0759d0359f52@ideasonboard.com>","References":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>\n\t<20260708-libipa-algorithms-v5-22-0759d0359f52@ideasonboard.com>","Subject":"Re: [PATCH v5 22/36] ipa: libipa: lsc: Introduce lsc::FrameContext","From":"Kieran Bingham ","Cc":"Jacopo Mondi ","To":"Jacopo Mondi ,\n\tStefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 14 Jul 2026 17:53:03 +0100","Message-ID":"<178404798300.3931061.17175570173215738959@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]