[{"id":39685,"web_url":"https://patchwork.libcamera.org/comment/39685/","msgid":"<178395454452.3603632.12157281562153998975@localhost>","date":"2026-07-13T14:55:44","subject":"Re: [PATCH v5 25/36] ipa: rkisp1: lsc: Port to use LscAlgorithm","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo,\n\nQuoting Jacopo Mondi (2026-07-08 17:51:07)\n> Port the RkISP1 LSC algorithm to use the LscAlgorithm class by\n> composition.\n> \n> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nI like how these calls into libipa now work.\n\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\nBest regards,\nStefan\n\n> ---\n>  src/ipa/rkisp1/algorithms/lsc.cpp | 72 +++++----------------------------------\n>  src/ipa/rkisp1/algorithms/lsc.h   | 13 +++----\n>  src/ipa/rkisp1/ipa_context.h      | 10 ++----\n>  3 files changed, 18 insertions(+), 77 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 7010c97db22e..0d9f1b006107 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -14,12 +14,6 @@\n>  #include <libcamera/base/log.h>\n>  #include <libcamera/base/utils.h>\n>  \n> -#include \"libcamera/internal/value_node.h\"\n> -\n> -#include \"libipa/lsc_polynomial.h\"\n> -#include \"libipa/lsc_table.h\"\n> -#include \"linux/rkisp1-config.h\"\n> -\n>  /**\n>   * \\file lsc.h\n>   */\n> @@ -73,42 +67,8 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n>         xPos_ = sizesListToPositions(xSize_);\n>         yPos_ = sizesListToPositions(ySize_);\n>  \n> -       /* Get all defined sets to apply. */\n> -       const ValueNode &sets = tuningData[\"sets\"];\n> -       if (!sets.isList()) {\n> -               LOG(RkISP1Lsc, Error)\n> -                       << \"'sets' parameter not found in tuning file\";\n> -               return -EINVAL;\n> -       }\n> -\n> -       int ret;\n> -\n> -       std::string type = tuningData[\"type\"].get<std::string>(\"table\");\n> -       if (type == \"table\") {\n> -               LOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n> -               algo_ = std::make_unique<LscTable>();\n> -               ret = algo_->parseLscData(sets);\n> -       } else if (type == \"polynomial\") {\n> -               LOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n> -               /*\n> -                * \\todo: Most likely the reference frame should be native_size.\n> -                * Let's wait how the internal discussions progress.\n> -                */\n> -               algo_ = std::make_unique<LscPolynomial>(context.sensorInfo.activeAreaSize);\n> -               ret = algo_->parseLscData(sets);\n> -       } else {\n> -               LOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n> -                                     << type << \"'\";\n> -               ret = -EINVAL;\n> -       }\n> -\n> -       if (ret)\n> -               return ret;\n> -\n> -       context.ctrlMap[&controls::LensShadingCorrectionEnable] =\n> -               ControlInfo(false, true, true);\n> -\n> -       return 0;\n> +       return lscAlgo_.init(tuningData, context.sensorInfo.activeAreaSize,\n> +                            context.ctrlMap);\n>  }\n>  \n>  std::vector<double> LensShadingCorrection::parseSizes(const ValueNode &tuningData,\n> @@ -199,13 +159,8 @@ int LensShadingCorrection::configure(IPAContext &context,\n>                 yGrad_[i] = std::round(32768 / ySizes_[i]);\n>         }\n>  \n> -       LOG(RkISP1Lsc, Debug) << \"Sample LSC data for \" << configInfo.analogCrop;\n> -       lsc::ComponentsMap shadingData = algo_->sampleForCrop(configInfo.analogCrop,\n> -                                                             xPos_, yPos_);\n> -       sets_.setData(std::move(shadingData));\n> -\n> -       context.activeState.lsc.enabled = true;\n> -       return 0;\n> +       return lscAlgo_.configure(context.activeState.lsc, configInfo.analogCrop,\n> +                                 xPos_, yPos_);\n>  }\n>  \n>  void LensShadingCorrection::setParameters(rkisp1_cif_isp_lsc_config &config)\n> @@ -233,19 +188,8 @@ void LensShadingCorrection::queueRequest(IPAContext &context,\n>                                          IPAFrameContext &frameContext,\n>                                          const ControlList &controls)\n>  {\n> -       auto &lsc = context.activeState.lsc;\n> -\n> -       const auto &lscEnable = controls.get(controls::LensShadingCorrectionEnable);\n> -       if (lscEnable && *lscEnable != lsc.enabled) {\n> -               lsc.enabled = *lscEnable;\n> -\n> -               LOG(RkISP1Lsc, Debug)\n> -                       << (lsc.enabled ? \"Enabling\" : \"Disabling\") << \" Lsc\";\n> -\n> -               frameContext.lsc.update = true;\n> -       }\n> -\n> -       frameContext.lsc.enabled = lsc.enabled;\n> +       lscAlgo_.queueRequest(context.activeState.lsc, frameContext.lsc,\n> +                             controls);\n>  }\n>  \n>  /**\n> @@ -283,7 +227,7 @@ void LensShadingCorrection::prepare([[maybe_unused]] IPAContext &context,\n>  \n>         setParameters(*config);\n>  \n> -       const lsc::Components &set = sets_.getInterpolated(quantizedCt);\n> +       const lsc::Components &set = lscAlgo_.interpolateComponents(quantizedCt);\n>         copyTable(*config, set);\n>  \n>         lastAppliedCt_ = ct;\n> @@ -303,7 +247,7 @@ void LensShadingCorrection::process([[maybe_unused]] IPAContext &context,\n>                                     [[maybe_unused]] const rkisp1_stat_buffer *stats,\n>                                     ControlList &metadata)\n>  {\n> -       metadata.set(controls::LensShadingCorrectionEnable, frameContext.lsc.enabled);\n> +       lscAlgo_.process(frameContext.lsc, metadata);\n>  }\n>  \n>  REGISTER_IPA_ALGORITHM(LensShadingCorrection, \"LensShadingCorrection\")\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index 06aa7a5f133c..e7d3091a36c5 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -7,10 +7,13 @@\n>  \n>  #pragma once\n>  \n> -#include <memory>\n> +#include <vector>\n>  \n> -#include \"libipa/interpolator.h\"\n> -#include \"libipa/lsc_base.h\"\n> +#include <linux/rkisp1-config.h>\n> +\n> +#include \"libcamera/internal/value_node.h\"\n> +\n> +#include \"libipa/lsc.h\"\n>  \n>  #include \"algorithm.h\"\n>  \n> @@ -55,9 +58,7 @@ private:\n>         unsigned int lastAppliedCt_;\n>         unsigned int lastAppliedQuantizedCt_;\n>  \n> -       ipa::Interpolator<lsc::Components> sets_;\n> -\n> -       std::unique_ptr<LscImplementation> algo_;\n> +       LscAlgorithm lscAlgo_;\n>  };\n>  \n>  } /* namespace ipa::rkisp1::algorithms */\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 6698ccfd77cf..7b4346c54ed2 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -30,6 +30,7 @@\n>  #include \"libipa/ccm.h\"\n>  #include \"libipa/fc_queue.h\"\n>  #include \"libipa/fixedpoint.h\"\n> +#include \"libipa/lsc.h\"\n>  \n>  namespace libcamera {\n>  \n> @@ -141,9 +142,7 @@ struct IPAActiveState {\n>                 double strength;\n>         } wdr;\n>  \n> -       struct {\n> -               bool enabled;\n> -       } lsc;\n> +       ipa::lsc::ActiveState lsc;\n>  };\n>  \n>  struct IPAFrameContext : public FrameContext {\n> @@ -217,10 +216,7 @@ struct IPAFrameContext : public FrameContext {\n>                 double gain;\n>         } wdr;\n>  \n> -       struct {\n> -               bool enabled;\n> -               bool update;\n> -       } lsc;\n> +       ipa::lsc::FrameContext lsc;\n>  };\n>  \n>  struct IPAContext {\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4E72C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jul 2026 14:55:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4E356604D;\n\tMon, 13 Jul 2026 16:55:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 275096604D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jul 2026 16:55:47 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6c1f:355d:1c19:aba6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 810711049;\n\tMon, 13 Jul 2026 16:54:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y7oxD/sv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783954493;\n\tbh=EJ8YJJaEkB+rvutUgJhu2co2QMunjhelCD1+mleqiHc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Y7oxD/svSAEdac13Hq6S23CYxNdWIeh8uvY+sfWN0Ux+0sV1q018UOrW1vQYpoKTT\n\t4UnoKhM5ARiqI24Efd/WYbpb14lFGk7ZBG7O8aBYxhbK+bHHI9QJG03Y/E0gGUpFYA\n\t9Lp31QlFNuIBL5shTFHiKAJFYmEzkkQuUS2XQsow=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260708-libipa-algorithms-v5-25-0759d0359f52@ideasonboard.com>","References":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>\n\t<20260708-libipa-algorithms-v5-25-0759d0359f52@ideasonboard.com>","Subject":"Re: [PATCH v5 25/36] ipa: rkisp1: lsc: Port to use LscAlgorithm","From":"Stefan Klug <stefan.klug@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Jul 2026 16:55:44 +0200","Message-ID":"<178395454452.3603632.12157281562153998975@localhost>","User-Agent":"alot/0.12.dev43+g2cacc0d03","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39701,"web_url":"https://patchwork.libcamera.org/comment/39701/","msgid":"<178404930946.3931061.7958947058411448400@ping.linuxembedded.co.uk>","date":"2026-07-14T17:15:09","subject":"Re: [PATCH v5 25/36] ipa: rkisp1: lsc: Port to use LscAlgorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2026-07-13 15:55:44)\n> Hi Jacopo,\n> \n> Quoting Jacopo Mondi (2026-07-08 17:51:07)\n> > Port the RkISP1 LSC algorithm to use the LscAlgorithm class by\n> > composition.\n> > \n> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> \n> I like how these calls into libipa now work.\n\nReducing code duplication throughout the series is fantastic.\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> \n> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> \n> Best regards,\n> Stefan\n> \n> > ---\n> >  src/ipa/rkisp1/algorithms/lsc.cpp | 72 +++++----------------------------------\n> >  src/ipa/rkisp1/algorithms/lsc.h   | 13 +++----\n> >  src/ipa/rkisp1/ipa_context.h      | 10 ++----\n> >  3 files changed, 18 insertions(+), 77 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > index 7010c97db22e..0d9f1b006107 100644\n> > --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > @@ -14,12 +14,6 @@\n> >  #include <libcamera/base/log.h>\n> >  #include <libcamera/base/utils.h>\n> >  \n> > -#include \"libcamera/internal/value_node.h\"\n> > -\n> > -#include \"libipa/lsc_polynomial.h\"\n> > -#include \"libipa/lsc_table.h\"\n> > -#include \"linux/rkisp1-config.h\"\n> > -\n> >  /**\n> >   * \\file lsc.h\n> >   */\n> > @@ -73,42 +67,8 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> >         xPos_ = sizesListToPositions(xSize_);\n> >         yPos_ = sizesListToPositions(ySize_);\n> >  \n> > -       /* Get all defined sets to apply. */\n> > -       const ValueNode &sets = tuningData[\"sets\"];\n> > -       if (!sets.isList()) {\n> > -               LOG(RkISP1Lsc, Error)\n> > -                       << \"'sets' parameter not found in tuning file\";\n> > -               return -EINVAL;\n> > -       }\n> > -\n> > -       int ret;\n> > -\n> > -       std::string type = tuningData[\"type\"].get<std::string>(\"table\");\n> > -       if (type == \"table\") {\n> > -               LOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n> > -               algo_ = std::make_unique<LscTable>();\n> > -               ret = algo_->parseLscData(sets);\n> > -       } else if (type == \"polynomial\") {\n> > -               LOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n> > -               /*\n> > -                * \\todo: Most likely the reference frame should be native_size.\n> > -                * Let's wait how the internal discussions progress.\n> > -                */\n> > -               algo_ = std::make_unique<LscPolynomial>(context.sensorInfo.activeAreaSize);\n> > -               ret = algo_->parseLscData(sets);\n> > -       } else {\n> > -               LOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n> > -                                     << type << \"'\";\n> > -               ret = -EINVAL;\n> > -       }\n> > -\n> > -       if (ret)\n> > -               return ret;\n> > -\n> > -       context.ctrlMap[&controls::LensShadingCorrectionEnable] =\n> > -               ControlInfo(false, true, true);\n> > -\n> > -       return 0;\n> > +       return lscAlgo_.init(tuningData, context.sensorInfo.activeAreaSize,\n> > +                            context.ctrlMap);\n> >  }\n> >  \n> >  std::vector<double> LensShadingCorrection::parseSizes(const ValueNode &tuningData,\n> > @@ -199,13 +159,8 @@ int LensShadingCorrection::configure(IPAContext &context,\n> >                 yGrad_[i] = std::round(32768 / ySizes_[i]);\n> >         }\n> >  \n> > -       LOG(RkISP1Lsc, Debug) << \"Sample LSC data for \" << configInfo.analogCrop;\n> > -       lsc::ComponentsMap shadingData = algo_->sampleForCrop(configInfo.analogCrop,\n> > -                                                             xPos_, yPos_);\n> > -       sets_.setData(std::move(shadingData));\n> > -\n> > -       context.activeState.lsc.enabled = true;\n> > -       return 0;\n> > +       return lscAlgo_.configure(context.activeState.lsc, configInfo.analogCrop,\n> > +                                 xPos_, yPos_);\n> >  }\n> >  \n> >  void LensShadingCorrection::setParameters(rkisp1_cif_isp_lsc_config &config)\n> > @@ -233,19 +188,8 @@ void LensShadingCorrection::queueRequest(IPAContext &context,\n> >                                          IPAFrameContext &frameContext,\n> >                                          const ControlList &controls)\n> >  {\n> > -       auto &lsc = context.activeState.lsc;\n> > -\n> > -       const auto &lscEnable = controls.get(controls::LensShadingCorrectionEnable);\n> > -       if (lscEnable && *lscEnable != lsc.enabled) {\n> > -               lsc.enabled = *lscEnable;\n> > -\n> > -               LOG(RkISP1Lsc, Debug)\n> > -                       << (lsc.enabled ? \"Enabling\" : \"Disabling\") << \" Lsc\";\n> > -\n> > -               frameContext.lsc.update = true;\n> > -       }\n> > -\n> > -       frameContext.lsc.enabled = lsc.enabled;\n> > +       lscAlgo_.queueRequest(context.activeState.lsc, frameContext.lsc,\n> > +                             controls);\n> >  }\n> >  \n> >  /**\n> > @@ -283,7 +227,7 @@ void LensShadingCorrection::prepare([[maybe_unused]] IPAContext &context,\n> >  \n> >         setParameters(*config);\n> >  \n> > -       const lsc::Components &set = sets_.getInterpolated(quantizedCt);\n> > +       const lsc::Components &set = lscAlgo_.interpolateComponents(quantizedCt);\n> >         copyTable(*config, set);\n> >  \n> >         lastAppliedCt_ = ct;\n> > @@ -303,7 +247,7 @@ void LensShadingCorrection::process([[maybe_unused]] IPAContext &context,\n> >                                     [[maybe_unused]] const rkisp1_stat_buffer *stats,\n> >                                     ControlList &metadata)\n> >  {\n> > -       metadata.set(controls::LensShadingCorrectionEnable, frameContext.lsc.enabled);\n> > +       lscAlgo_.process(frameContext.lsc, metadata);\n> >  }\n> >  \n> >  REGISTER_IPA_ALGORITHM(LensShadingCorrection, \"LensShadingCorrection\")\n> > diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> > index 06aa7a5f133c..e7d3091a36c5 100644\n> > --- a/src/ipa/rkisp1/algorithms/lsc.h\n> > +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> > @@ -7,10 +7,13 @@\n> >  \n> >  #pragma once\n> >  \n> > -#include <memory>\n> > +#include <vector>\n> >  \n> > -#include \"libipa/interpolator.h\"\n> > -#include \"libipa/lsc_base.h\"\n> > +#include <linux/rkisp1-config.h>\n> > +\n> > +#include \"libcamera/internal/value_node.h\"\n> > +\n> > +#include \"libipa/lsc.h\"\n> >  \n> >  #include \"algorithm.h\"\n> >  \n> > @@ -55,9 +58,7 @@ private:\n> >         unsigned int lastAppliedCt_;\n> >         unsigned int lastAppliedQuantizedCt_;\n> >  \n> > -       ipa::Interpolator<lsc::Components> sets_;\n> > -\n> > -       std::unique_ptr<LscImplementation> algo_;\n> > +       LscAlgorithm lscAlgo_;\n> >  };\n> >  \n> >  } /* namespace ipa::rkisp1::algorithms */\n> > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> > index 6698ccfd77cf..7b4346c54ed2 100644\n> > --- a/src/ipa/rkisp1/ipa_context.h\n> > +++ b/src/ipa/rkisp1/ipa_context.h\n> > @@ -30,6 +30,7 @@\n> >  #include \"libipa/ccm.h\"\n> >  #include \"libipa/fc_queue.h\"\n> >  #include \"libipa/fixedpoint.h\"\n> > +#include \"libipa/lsc.h\"\n> >  \n> >  namespace libcamera {\n> >  \n> > @@ -141,9 +142,7 @@ struct IPAActiveState {\n> >                 double strength;\n> >         } wdr;\n> >  \n> > -       struct {\n> > -               bool enabled;\n> > -       } lsc;\n> > +       ipa::lsc::ActiveState lsc;\n> >  };\n> >  \n> >  struct IPAFrameContext : public FrameContext {\n> > @@ -217,10 +216,7 @@ struct IPAFrameContext : public FrameContext {\n> >                 double gain;\n> >         } wdr;\n> >  \n> > -       struct {\n> > -               bool enabled;\n> > -               bool update;\n> > -       } lsc;\n> > +       ipa::lsc::FrameContext lsc;\n> >  };\n> >  \n> >  struct IPAContext {\n> > \n> > -- \n> > 2.54.0\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3085BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jul 2026 17:15:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AD2166144;\n\tTue, 14 Jul 2026 19:15:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 078C666137\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jul 2026 19:15:12 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE16B558;\n\tTue, 14 Jul 2026 19:14:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QRBV+SEu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784049257;\n\tbh=FgtLtn1rPKZT/V5TiA8+gSivaSFbeXLbJC5FnJAuftc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=QRBV+SEuNrcYhX5AOLBHDFUJr/nA6t3ubelrCkyYJuRtyfXe6pm+dI6xOBNEXIKZ2\n\tT/LhspAXdH7m/fltVG6sqzEV35EWcOBECfvup08934VxumDTUcNFIJlCtzHT6u2CO3\n\tQsvhB1UNLJ69PVWfMWOK8rJsuQ6ND6goK64jCzSk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<178395454452.3603632.12157281562153998975@localhost>","References":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>\n\t<20260708-libipa-algorithms-v5-25-0759d0359f52@ideasonboard.com>\n\t<178395454452.3603632.12157281562153998975@localhost>","Subject":"Re: [PATCH v5 25/36] ipa: rkisp1: lsc: Port to use LscAlgorithm","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 14 Jul 2026 18:15:09 +0100","Message-ID":"<178404930946.3931061.7958947058411448400@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]