[{"id":39656,"web_url":"https://patchwork.libcamera.org/comment/39656/","msgid":"<178360225916.2174993.3494247871336752955@ping.linuxembedded.co.uk>","date":"2026-07-09T13:04:19","subject":"Re: [PATCH v5 11/36] ipa: libipa: lsc_polynomial: Fix polynomial\n\tparsing error","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2026-07-08 16:50:53)\n> If any of the polynomial component is missing in the tuning file the\n> ValueNode::Accessor specialization emits an\n> error message but continues and dereferences a potentially\n> invalid object.\n> \n> Fix it by returning std::nullopt if a polynomial component is missing.\n> \n> The caller already checks if the returned value is valid or not, causing\n> the algorithm initialization to fail if the tuning file is invalid.\n> \n> Signed-off-by: Jacopo Mondi \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/libipa/lsc_polynomial.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\n> index d7d9ae42e360..a0d27c4b21d6 100644\n> --- a/src/ipa/libipa/lsc_polynomial.h\n> +++ b/src/ipa/libipa/lsc_polynomial.h\n> @@ -94,9 +94,11 @@ struct ValueNode::Accessor {\n> std::optional k3 = obj[\"k3\"].get();\n> std::optional k4 = obj[\"k4\"].get();\n> \n> - if (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n> + if (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n> LOG(LscPolynomial, Error)\n> << \"Polynomial is missing a parameter\";\n> + return std::nullopt;\n> + }\n> \n> return ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n> }\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A144CC3301\n\tfor ;\n\tThu, 9 Jul 2026 13:04:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CD37660EC;\n\tThu, 9 Jul 2026 15:04:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B883E660E3\n\tfor ;\n\tThu, 9 Jul 2026 15:04:21 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C8A14DC;\n\tThu, 9 Jul 2026 15:03:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tG5rS/+D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783602211;\n\tbh=RnG5HbOMwOU1DfndbWSzWec2LU7nvoYAUKyjU5rzy9o=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tG5rS/+DYKQkncbfPaz9lPvRgE1TjdzWPytndxKqLRE9IpAr1E8zbw4hiBd20ewvV\n\tFJfd0iUGK7STHOYvoMxbs1DPXCvMCJRo0qNq8JHy5MAA3LnpZVNtlslV0pD0mSAsw0\n\tvkEuNSgxPCr0lYLMqQdZFsnGd62fQ1mKzZPovrzM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260708-libipa-algorithms-v5-11-0759d0359f52@ideasonboard.com>","References":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>\n\t<20260708-libipa-algorithms-v5-11-0759d0359f52@ideasonboard.com>","Subject":"Re: [PATCH v5 11/36] ipa: libipa: lsc_polynomial: Fix polynomial\n\tparsing error","From":"Kieran Bingham ","Cc":"Jacopo Mondi ","To":"Jacopo Mondi ,\n\tStefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 09 Jul 2026 14:04:19 +0100","Message-ID":"<178360225916.2174993.3494247871336752955@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39675,"web_url":"https://patchwork.libcamera.org/comment/39675/","msgid":"<178394878056.3603632.4941520253954726249@localhost>","date":"2026-07-13T13:19:40","subject":"Re: [PATCH v5 11/36] ipa: libipa: lsc_polynomial: Fix polynomial\n\tparsing error","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo,\n\nQuoting Jacopo Mondi (2026-07-08 17:50:53)\n> If any of the polynomial component is missing in the tuning file the\n> ValueNode::Accessor specialization emits an\n> error message but continues and dereferences a potentially\n> invalid object.\n> \n> Fix it by returning std::nullopt if a polynomial component is missing.\n> \n> The caller already checks if the returned value is valid or not, causing\n> the algorithm initialization to fail if the tuning file is invalid.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/ipa/libipa/lsc_polynomial.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\n> index d7d9ae42e360..a0d27c4b21d6 100644\n> --- a/src/ipa/libipa/lsc_polynomial.h\n> +++ b/src/ipa/libipa/lsc_polynomial.h\n> @@ -94,9 +94,11 @@ struct ValueNode::Accessor {\n> std::optional k3 = obj[\"k3\"].get();\n> std::optional k4 = obj[\"k4\"].get();\n> \n> - if (!(cx && cy && k0 && k1 && k2 && k3 && k4))\n> + if (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n> LOG(LscPolynomial, Error)\n> << \"Polynomial is missing a parameter\";\n> + return std::nullopt;\n\nGood point.\n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> + }\n> \n> return ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n> }\n> \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47872C3264\n\tfor ;\n\tMon, 13 Jul 2026 13:19:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86A9866114;\n\tMon, 13 Jul 2026 15:19:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E31886604D\n\tfor ;\n\tMon, 13 Jul 2026 15:19:42 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6c1f:355d:1c19:aba6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BB84BE;\n\tMon, 13 Jul 2026 15:18:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FMEUn0Ld\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783948729;\n\tbh=9ub1bgRcdR3v+HJt2nK6EMxBfr0L/CExGx+XO51csQo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FMEUn0LdF6YNuDRme0Cu87oGudMskoqno+tnVRDZ3kndTuUiEksvSOrj+uHTYRN2d\n\tlb9sTTLmZyaWKgHL+upBzaTjYoMKbtzrA262FhioNQ45w6fHCNdUFTx7lx05G1k4lZ\n\tATmSRiNnG2Q0+fEDie9dom/FwEJ7CpW6XectjVxo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260708-libipa-algorithms-v5-11-0759d0359f52@ideasonboard.com>","References":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>\n\t<20260708-libipa-algorithms-v5-11-0759d0359f52@ideasonboard.com>","Subject":"Re: [PATCH v5 11/36] ipa: libipa: lsc_polynomial: Fix polynomial\n\tparsing error","From":"Stefan Klug ","Cc":"Jacopo Mondi ","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Jul 2026 15:19:40 +0200","Message-ID":"<178394878056.3603632.4941520253954726249@localhost>","User-Agent":"alot/0.12.dev43+g2cacc0d03","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]