[{"id":3586,"web_url":"https://patchwork.libcamera.org/comment/3586/","msgid":"<32f4c42f-21c4-3817-8f38-0256ac42e4d8@ideasonboard.com>","date":"2020-01-23T10:19:23","subject":"Re: [libcamera-devel] [PATCH 2/2] test: threads: Add wait() timeout\n\ttest","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent\n\nOn 23/01/2020 02:55, Laurent Pinchart wrote:\n> Add a test case to wait with a timeout, testing both a too short and a\n> long enough duration.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nSome discussion below, but this is fine stand-alone anyway.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  test/threads.cpp | 33 ++++++++++++++++++++++++++-------\n>  1 file changed, 26 insertions(+), 7 deletions(-)\n> \n> diff --git a/test/threads.cpp b/test/threads.cpp\n> index 9a2d39dfd106..fc4b07cc6428 100644\n> --- a/test/threads.cpp\n> +++ b/test/threads.cpp\n> @@ -15,24 +15,22 @@\n>  using namespace std;\n>  using namespace libcamera;\n>  \n> -class InstrumentedThread : public Thread\n> +class DelayThread : public Thread\n>  {\n>  public:\n> -\tInstrumentedThread(unsigned int iterations)\n> -\t\t: iterations_(iterations)\n> +\tDelayThread(chrono::steady_clock::duration duration)\n> +\t\t: duration_(duration)\n>  \t{\n>  \t}\n>  \n>  protected:\n>  \tvoid run()\n>  \t{\n> -\t\tfor (unsigned int i = 0; i < iterations_; ++i) {\n> -\t\t\tthis_thread::sleep_for(chrono::milliseconds(50));\n> -\t\t}\n> +\t\tthis_thread::sleep_for(duration_);\n>  \t}\n>  \n>  private:\n> -\tunsigned int iterations_;\n> +\tchrono::steady_clock::duration duration_;\n>  };\n>  \n>  class ThreadTest : public Test\n> @@ -82,6 +80,27 @@ protected:\n>  \n>  \t\tdelete thread;\n>  \n> +\t\t/* Test waiting for completion with a timeout. */\n> +\t\tthread = new DelayThread(chrono::milliseconds(500));\n> +\t\tthread->start();\n> +\t\tthread->exit(0);\n> +\n> +\t\tbool timeout = thread->wait(chrono::milliseconds(100));\n> +\n> +\t\tif (!timeout) {\n> +\t\t\tcout << \"Waiting for thread didn't time out\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ttimeout = thread->wait(chrono::milliseconds(1000));\n> +\n> +\t\tif (timeout) {\n> +\t\t\tcout << \"Waiting for thread timed out\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tdelete thread;\n> +\n\nHow about a test for waiting on a thread that isn't running? (Perhaps\nput in an thread->wait(utils::duration::max()); after we know the thread\nhas already stopped here ?\n\n\nWhat happens if the wait receives a signal while it is waiting?\n\n\n>  \t\treturn TestPass;\n>  \t}\n>  \n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1485B6044F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jan 2020 11:19:27 +0100 (CET)","from [192.168.0.65]\n\t(cpc85452-aztw29-2-0-cust211.18-1.cable.virginm.net [82.38.172.212])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B5BD2E5;\n\tThu, 23 Jan 2020 11:19:26 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579774766;\n\tbh=7jYTTjUwqrAV9wxAURtOYeTVnNnNJ+2driO1A+hLwzw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=duFHWdACcTLidPy1Nl4nn2IDEP5vX7HW1tTIeTRLK37sSL/hpyNetV/Q21N5Pj1bh\n\tdd9FMfk/qUOaC1m+SXBhod7IR5r4ceqFqSsEVB3kItIeF1wGKEn42gP+i6bYlw4X7O\n\t7VmrYGVUFcZkarIwc4VT0PqwuUbckzlMb5ycuqN4=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200123025520.12149-1-laurent.pinchart@ideasonboard.com>\n\t<20200123025520.12149-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<32f4c42f-21c4-3817-8f38-0256ac42e4d8@ideasonboard.com>","Date":"Thu, 23 Jan 2020 10:19:23 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200123025520.12149-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] test: threads: Add wait() timeout\n\ttest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 23 Jan 2020 10:19:27 -0000"}},{"id":3587,"web_url":"https://patchwork.libcamera.org/comment/3587/","msgid":"<20200123131049.GA15437@pendragon.ideasonboard.com>","date":"2020-01-23T13:10:49","subject":"Re: [libcamera-devel] [PATCH 2/2] test: threads: Add wait() timeout\n\ttest","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Jan 23, 2020 at 10:19:23AM +0000, Kieran Bingham wrote:\n> On 23/01/2020 02:55, Laurent Pinchart wrote:\n> > Add a test case to wait with a timeout, testing both a too short and a\n> > long enough duration.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> Some discussion below, but this is fine stand-alone anyway.\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > ---\n> >  test/threads.cpp | 33 ++++++++++++++++++++++++++-------\n> >  1 file changed, 26 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/test/threads.cpp b/test/threads.cpp\n> > index 9a2d39dfd106..fc4b07cc6428 100644\n> > --- a/test/threads.cpp\n> > +++ b/test/threads.cpp\n> > @@ -15,24 +15,22 @@\n> >  using namespace std;\n> >  using namespace libcamera;\n> >  \n> > -class InstrumentedThread : public Thread\n> > +class DelayThread : public Thread\n> >  {\n> >  public:\n> > -\tInstrumentedThread(unsigned int iterations)\n> > -\t\t: iterations_(iterations)\n> > +\tDelayThread(chrono::steady_clock::duration duration)\n> > +\t\t: duration_(duration)\n> >  \t{\n> >  \t}\n> >  \n> >  protected:\n> >  \tvoid run()\n> >  \t{\n> > -\t\tfor (unsigned int i = 0; i < iterations_; ++i) {\n> > -\t\t\tthis_thread::sleep_for(chrono::milliseconds(50));\n> > -\t\t}\n> > +\t\tthis_thread::sleep_for(duration_);\n> >  \t}\n> >  \n> >  private:\n> > -\tunsigned int iterations_;\n> > +\tchrono::steady_clock::duration duration_;\n> >  };\n> >  \n> >  class ThreadTest : public Test\n> > @@ -82,6 +80,27 @@ protected:\n> >  \n> >  \t\tdelete thread;\n> >  \n> > +\t\t/* Test waiting for completion with a timeout. */\n> > +\t\tthread = new DelayThread(chrono::milliseconds(500));\n> > +\t\tthread->start();\n> > +\t\tthread->exit(0);\n> > +\n> > +\t\tbool timeout = thread->wait(chrono::milliseconds(100));\n> > +\n> > +\t\tif (!timeout) {\n> > +\t\t\tcout << \"Waiting for thread didn't time out\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\ttimeout = thread->wait(chrono::milliseconds(1000));\n> > +\n> > +\t\tif (timeout) {\n> > +\t\t\tcout << \"Waiting for thread timed out\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tdelete thread;\n> > +\n> \n> How about a test for waiting on a thread that isn't running? (Perhaps\n> put in an thread->wait(utils::duration::max()); after we know the thread\n> has already stopped here ?\n\nThat's a good idea. I'll add it as a separate patch.\n\n> What happens if the wait receives a signal while it is waiting?\n\nAs in a POSIX signal ? As far as I can tell, nothing.\n\n> >  \t\treturn TestPass;\n> >  \t}\n> >","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB94760455\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jan 2020 14:11:06 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3933D2E5;\n\tThu, 23 Jan 2020 14:11:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579785066;\n\tbh=5EHvR3dDRLjfuyENVLec5wqDydlS6U5siLN7cEq39hc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vn1ZYYRcsKmFqKbaffVwbqlb/goQqDi8H7uh7qTsURjL8AtYpcdSzP05Zj/NW7hWK\n\toXYelDJ9mvEdCiwXHh6q/dmZhOP2ma5vmilWNQuEGCYNZfQp84e+07oejtytZdILxc\n\t7mkbLf9fhUy+JPT9kCRegSorPlpYZNTyYlY5xRj0=","Date":"Thu, 23 Jan 2020 15:10:49 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200123131049.GA15437@pendragon.ideasonboard.com>","References":"<20200123025520.12149-1-laurent.pinchart@ideasonboard.com>\n\t<20200123025520.12149-2-laurent.pinchart@ideasonboard.com>\n\t<32f4c42f-21c4-3817-8f38-0256ac42e4d8@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<32f4c42f-21c4-3817-8f38-0256ac42e4d8@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/2] test: threads: Add wait() timeout\n\ttest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 23 Jan 2020 13:11:06 -0000"}},{"id":3645,"web_url":"https://patchwork.libcamera.org/comment/3645/","msgid":"<20200210211327.GB2429426@oden.dyn.berto.se>","date":"2020-02-10T21:13:27","subject":"Re: [libcamera-devel] [PATCH 2/2] test: threads: Add wait() timeout\n\ttest","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-23 04:55:20 +0200, Laurent Pinchart wrote:\n> Add a test case to wait with a timeout, testing both a too short and a\n> long enough duration.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  test/threads.cpp | 33 ++++++++++++++++++++++++++-------\n>  1 file changed, 26 insertions(+), 7 deletions(-)\n> \n> diff --git a/test/threads.cpp b/test/threads.cpp\n> index 9a2d39dfd106..fc4b07cc6428 100644\n> --- a/test/threads.cpp\n> +++ b/test/threads.cpp\n> @@ -15,24 +15,22 @@\n>  using namespace std;\n>  using namespace libcamera;\n>  \n> -class InstrumentedThread : public Thread\n> +class DelayThread : public Thread\n>  {\n>  public:\n> -\tInstrumentedThread(unsigned int iterations)\n> -\t\t: iterations_(iterations)\n> +\tDelayThread(chrono::steady_clock::duration duration)\n> +\t\t: duration_(duration)\n>  \t{\n>  \t}\n>  \n>  protected:\n>  \tvoid run()\n>  \t{\n> -\t\tfor (unsigned int i = 0; i < iterations_; ++i) {\n> -\t\t\tthis_thread::sleep_for(chrono::milliseconds(50));\n> -\t\t}\n> +\t\tthis_thread::sleep_for(duration_);\n>  \t}\n>  \n>  private:\n> -\tunsigned int iterations_;\n> +\tchrono::steady_clock::duration duration_;\n>  };\n>  \n>  class ThreadTest : public Test\n> @@ -82,6 +80,27 @@ protected:\n>  \n>  \t\tdelete thread;\n>  \n> +\t\t/* Test waiting for completion with a timeout. */\n> +\t\tthread = new DelayThread(chrono::milliseconds(500));\n> +\t\tthread->start();\n> +\t\tthread->exit(0);\n> +\n> +\t\tbool timeout = thread->wait(chrono::milliseconds(100));\n> +\n> +\t\tif (!timeout) {\n> +\t\t\tcout << \"Waiting for thread didn't time out\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ttimeout = thread->wait(chrono::milliseconds(1000));\n> +\n> +\t\tif (timeout) {\n> +\t\t\tcout << \"Waiting for thread timed out\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tdelete thread;\n> +\n>  \t\treturn TestPass;\n>  \t}\n>  \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4D5960990\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Feb 2020 22:13:29 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id b15so5368962lfc.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Feb 2020 13:13:29 -0800 (PST)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tr2sm844637lff.63.2020.02.10.13.13.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 10 Feb 2020 13:13:28 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=srLH+YSMkeaa/gcSDFlzgQLYxBLMxbx0TAo11Hv9/9s=;\n\tb=1WuPeCUW4B0GpkCaTexOJ3vhMsCrwi/cslQ44UElPK/bW19LnJXgFGdZ4+Nf3r+dH0\n\ttlIEuAzWkICdJ3w9i0jVUBTb5dvZNiyRqIRQ8MUF5LrvtP7H4ID+bOb0xGm/JtrPF0Xi\n\tIojurHkxkAkhRG7nMMnnGuk0vFyyxUVq+x8s+l8vOS7OC+7o/eD2U4SlBmU0THSMIRwc\n\tPusq+OhwOHeBkBtfpvTFQNg7GJwB+E+wzUU6UHeZlGA7VfA9BunxpUDw1gNGT8ae791a\n\t+qAdsWBay61iBq2jZ9g2eRJbnp/SaeskWtfEz92/Rrq4lEK/DRzPujikUnnb9kDGk6jf\n\t+slA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=srLH+YSMkeaa/gcSDFlzgQLYxBLMxbx0TAo11Hv9/9s=;\n\tb=ALSi2fB2y/DfPHANUDdyqIZdW+rGeSQrIwMqpkSq2BeOGhpQr2bfSa6yOUteBFmajZ\n\tNaQTw5RbKR9Nw32tzoXivWOJ2FMhK4SBGEFxrKipsOxtoTVyvlsrEujHeyrJNEW8Tp9O\n\t6XEJhJQTY2vP5pfdX6OYG6uU25OztlgAmL6xsKfOlIoIsIfbWjJ6dULAk4jPz019WSxA\n\tWMJKsEqD1mq8e9QMqZlw3vjXwyfPjvrLbWV1HrR+08aJ0rXB6eacrVzWMpvLig8tQsaC\n\tSoWZDDCSrw7XurppYrB2jSUb8ZOayjMWhxbVuA2CnenS5bAf/RJnupewtAwLRaB17lNF\n\tor8g==","X-Gm-Message-State":"APjAAAUnmqiJF+XHpz+hds4Mf1xT6+iR+kF6NCkpavB0lxiDQPl9HKvg\n\txh6QAyUHvVbYRxbQWTWFr46mRnFsA9BmIA==","X-Google-Smtp-Source":"APXvYqx3DAuI9o5/S891nEN6XNgTKgtTAO+nUABrpjlDKVRc8o/j5dWQj+4tf7RYhxr2NjPi0MXxeQ==","X-Received":"by 2002:a19:84d:: with SMTP id 74mr1646535lfi.122.1581369208750; \n\tMon, 10 Feb 2020 13:13:28 -0800 (PST)","Date":"Mon, 10 Feb 2020 22:13:27 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200210211327.GB2429426@oden.dyn.berto.se>","References":"<20200123025520.12149-1-laurent.pinchart@ideasonboard.com>\n\t<20200123025520.12149-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200123025520.12149-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] test: threads: Add wait() timeout\n\ttest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 10 Feb 2020 21:13:29 -0000"}}]