[{"id":39630,"web_url":"https://patchwork.libcamera.org/comment/39630/","msgid":"<178349871488.2174993.10053811433273440848@ping.linuxembedded.co.uk>","date":"2026-07-08T08:18:34","subject":"Re: [PATCH] Documentation: guides: ipa: Rename FileDescriptor to\n\tSharedFD","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2026-07-08 04:45:11)\n> When FileDescriptor was replaced with SharedFD, the documentation in the\n> IPA guide was not updated. Fix this.\n> \n> Signed-off-by: Paul Elder \n\nIndeed, these are the last references to FileDescriptor!\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> Documentation/guides/ipa.rst | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/guides/ipa.rst b/Documentation/guides/ipa.rst\n> index 42993924dd79..28d99acd18aa 100644\n> --- a/Documentation/guides/ipa.rst\n> +++ b/Documentation/guides/ipa.rst\n> @@ -86,7 +86,7 @@ definition, and may be used as function parameter types or struct field types:\n> \n> - libcamera.ControlInfoMap\n> - libcamera.ControlList\n> -- libcamera.FileDescriptor\n> +- libcamera.SharedFD\n> - libcamera.IPABuffer\n> - libcamera.IPACameraSensorInfo\n> - libcamera.IPASettings\n> @@ -124,14 +124,14 @@ The following is an example of a definition of a struct:\n> struct ConfigInput {\n> uint32 op;\n> uint32 transform;\n> - libcamera.FileDescriptor lsTableHandle;\n> + libcamera.SharedFD lsTableHandle;\n> int32 lsTableHandleStatic = -1;\n> map streamConfig;\n> array buffers;\n> };\n> \n> This example has some special things about it. First of all, it uses the\n> -FileDescriptor data type. This type must be used to ensure that the file\n> +SharedFD data type. This type must be used to ensure that the file\n> descriptor that it contains is translated properly across the IPC boundary\n> (when the IPA is in an isolated process).\n> \n> @@ -360,7 +360,7 @@ fills all fields with the default values, and a second constructor that takes\n> a value for every field. The default value constructor will fill in the fields\n> with the specified default value if it exists. In the above example, `gainDelay_`\n> will be initialized to 1. If no default value is specified, then it will be\n> -filled in as zero (or -1 for a FileDescriptor type).\n> +filled in as zero (or -1 for a SharedFD type).\n> \n> All fields and constructors/destructors in these generated structs are public.\n> \n> -- \n> 2.47.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A731BC3304\n\tfor ;\n\tWed, 8 Jul 2026 08:18:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D452666071;\n\tWed, 8 Jul 2026 10:18:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C748866071\n\tfor ;\n\tWed, 8 Jul 2026 10:18:37 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F148CEAA;\n\tWed, 8 Jul 2026 10:17:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k8igvyCD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783498668;\n\tbh=2T2PAAXse7LeX85/yAhirDGjoM1WCQSWcs3D/Q7VkyI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=k8igvyCD0yH8AoM1JBchWcq8lLE2BYbK6rJKEyau6715o21z+KM8Uo2jizjIDXIbx\n\tU1H1qO0HKQOb59qMAjSF0KQ+ofd+DS4/zfKiYnBY/zzFrZ0OSEmJ1WskQUKxMT+dg+\n\tTs8JK/vKw/4IdtQS2o29BZYT7i5u1m4ioO2ZqJ9U=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260708034511.149875-1-paul.elder@ideasonboard.com>","References":"<20260708034511.149875-1-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH] Documentation: guides: ipa: Rename FileDescriptor to\n\tSharedFD","From":"Kieran Bingham ","Cc":"Paul Elder ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 08 Jul 2026 09:18:34 +0100","Message-ID":"<178349871488.2174993.10053811433273440848@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39716,"web_url":"https://patchwork.libcamera.org/comment/39716/","msgid":"<81311dc7-9a38-4b1c-8ab7-234c6c2964e3@ideasonboard.com>","date":"2026-07-15T09:00:11","subject":"Re: [PATCH] Documentation: guides: ipa: Rename FileDescriptor to\n\tSharedFD","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 07. 08. 5:45 keltezéssel, Paul Elder írta:\n> When FileDescriptor was replaced with SharedFD, the documentation in the\n> IPA guide was not updated. Fix this.\n> \n> Signed-off-by: Paul Elder \n> ---\n> Documentation/guides/ipa.rst | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/guides/ipa.rst b/Documentation/guides/ipa.rst\n> index 42993924dd79..28d99acd18aa 100644\n> --- a/Documentation/guides/ipa.rst\n> +++ b/Documentation/guides/ipa.rst\n> @@ -86,7 +86,7 @@ definition, and may be used as function parameter types or struct field types:\n> \n> - libcamera.ControlInfoMap\n> - libcamera.ControlList\n> -- libcamera.FileDescriptor\n> +- libcamera.SharedFD\n\nShould this list be kept in alphabetical order?\n\nReviewed-by: Barnabás Pőcze \n\n\n> - libcamera.IPABuffer\n> - libcamera.IPACameraSensorInfo\n> - libcamera.IPASettings\n> @@ -124,14 +124,14 @@ The following is an example of a definition of a struct:\n> struct ConfigInput {\n> uint32 op;\n> uint32 transform;\n> - libcamera.FileDescriptor lsTableHandle;\n> + libcamera.SharedFD lsTableHandle;\n> int32 lsTableHandleStatic = -1;\n> map streamConfig;\n> array buffers;\n> };\n> \n> This example has some special things about it. First of all, it uses the\n> -FileDescriptor data type. This type must be used to ensure that the file\n> +SharedFD data type. This type must be used to ensure that the file\n> descriptor that it contains is translated properly across the IPC boundary\n> (when the IPA is in an isolated process).\n> \n> @@ -360,7 +360,7 @@ fills all fields with the default values, and a second constructor that takes\n> a value for every field. The default value constructor will fill in the fields\n> with the specified default value if it exists. In the above example, `gainDelay_`\n> will be initialized to 1. If no default value is specified, then it will be\n> -filled in as zero (or -1 for a FileDescriptor type).\n> +filled in as zero (or -1 for a SharedFD type).\n> \n> All fields and constructors/destructors in these generated structs are public.\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90916C3301\n\tfor ;\n\tWed, 15 Jul 2026 09:00:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AF7666167;\n\tWed, 15 Jul 2026 11:00:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E48456614E\n\tfor ;\n\tWed, 15 Jul 2026 11:00:14 +0200 (CEST)","from [192.168.33.27] (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3E38267;\n\tWed, 15 Jul 2026 10:59:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A3H2k0Wv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784105960;\n\tbh=cIOXIsgnOZ13kERqgyFOsYqApvL1Frkd+JbIzpYPqRc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=A3H2k0WvYds+m+JJpg6kBe6nfhxwxQled8Kzvo0aXdzi2mbecZwlUq1y10/WxheRq\n\tMQHgbpavoqcwmZouTFNrf1R686LQ5tJXd0xN2SsC6zGgkb0/X4LuftTvRkKNaYtTUZ\n\t9JhO+BB4keBxzek12PZtPwq5GfcTdQZXyv0OAnWQ=","Message-ID":"<81311dc7-9a38-4b1c-8ab7-234c6c2964e3@ideasonboard.com>","Date":"Wed, 15 Jul 2026 11:00:11 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] Documentation: guides: ipa: Rename FileDescriptor to\n\tSharedFD","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260708034511.149875-1-paul.elder@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260708034511.149875-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]