{"id":27254,"url":"https://patchwork.libcamera.org/api/patches/27254/?format=json","web_url":"https://patchwork.libcamera.org/patch/27254/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260706222245.247396-2-bryan.odonoghue@linaro.org>","date":"2026-07-06T22:22:40","name":"[v6,1/6] libcamera: software_isp: debayer_egl: Pass eglImage as parameter to setShaderVariables","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6cfa7f4ff004a514ed7180481ae8fa4a2a191a73","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27254/mbox/","series":[{"id":6042,"url":"https://patchwork.libcamera.org/api/series/6042/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6042","date":"2026-07-06T22:22:39","name":"libcamera: software_isp: gpu: Add go faster stripes","version":6,"mbox":"https://patchwork.libcamera.org/series/6042/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27254/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27254/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7069FC3308\n\tfor ;\n\tMon, 6 Jul 2026 22:23:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BFA466056;\n\tTue, 7 Jul 2026 00:23:00 +0200 (CEST)","from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5B0B6604D\n\tfor ;\n\tTue, 7 Jul 2026 00:22:57 +0200 (CEST)","by mail-wr1-x431.google.com with SMTP id\n\tffacd0b85a97d-47de0093c42so1610832f8f.3\n\tfor ;\n\tMon, 06 Jul 2026 15:22:57 -0700 (PDT)","from inspiron14p-linux ([109.77.44.220])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-47aa039ad21sm27916413f8f.20.2026.07.06.15.22.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 06 Jul 2026 15:22:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"zgRpm7+z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1783376577; x=1783981377;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to:content-type;\n\tbh=s3J/NrfJsMXq4eaqAQimcvyIokeKF2MgvnNr4M7DXMo=;\n\tb=zgRpm7+zwetMaazuYHbLWQoElIuVqI6ivjc0Y2IeaRgzZ8q7CGImQlvhO+r6B4Ovgy\n\tHBJ0/5ZqbPuqSQdZks6vAxSUSKc3MSDDm8Va0gSu7ftCTeatJnL4FtBdDpPrHqpIhrgw\n\tOfl9xD/TEDOG8MMFeTVyuR0etMErq3uunec57Na1milvc9hOBVh8fczvQBXDSudGGTyU\n\ty8UpSheas46QdN4cjwVmzGNn2Fp0L5AVWhbRv8cpop2dkkX9JXZrhRoylAQtogiWXwI5\n\tzkGnhCB/ySu5+VvJOibP/X10687aPANfd4ZwnqUXrpo2G/JHIXTlWaoQOtpDAWuFLdcz\n\tlJyw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1783376577; x=1783981377;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to:content-type;\n\tbh=s3J/NrfJsMXq4eaqAQimcvyIokeKF2MgvnNr4M7DXMo=;\n\tb=ZfuF1HhgqtEAEJWG+zLXcQzYvBongDalthZpaFqjqXFt2taDRndIvaJidQMyT29UzL\n\t2hVk7jk/rw868hafNEbDO+ty8sWDVTSa+10WTUvxFGaQQdbLi80DY1y5eoqNBPSzzKFI\n\tuoqiiPqUmTtfDSPkq3NjFQ8yAMUqA507cBwGDHGz4CKa7Wk9L5wfQ3IXVxNGeiq5q6hr\n\tC/5oLoFk0C3VFYiGb9Wmbs1dhKfLi/BdGwjz7FcnsodG5g4UY+nmFutD4hdRP/QHwJ3K\n\tjGO52YJAQIUIBHQsn1ft+sPahBFqPXBZeRGvvpO/rSpauCnLJPfMTvcu8F8q1/qlHfoD\n\te94w==","X-Gm-Message-State":"AOJu0Yyr7aodW1O1vOFZ7tKuWmQGmEiwigXaycsOG09SnPd5J/fUMYS4\n\tXb1lb+XuUzxLRZ2MOmvr8YLcSJ+4RMkZ8ItzOUiPoPEharajnstA+dGToDF0x9wCZ6CXrWaA2CI\n\teCrgP","X-Gm-Gg":"AfdE7cnY46BvmcBT8d5goABu9hbwhtOq4H/U8SqG0+UQWVeyN8eTWx3H6VK6cVJqYKk\n\t7biKYMlblrhL2Vb+euxTwF2mvnMqWcbAjo36r0bo8JEwTrf4ngp0p6E0Au/PVMA31DDuVe6m1D5\n\t2EQKkWhwQIPKhTzVfaD9fMkEMSePr0oYHbJp6jm1VSBhY89fAyicv/duR83WB9IjQNBBuLLEh0L\n\tJduXwbC1YdKqp5uFQ17hcRw5EuEMkwUV7q5JpNpJdmfLDqpIwXUUJj7jjw4kjZXa1bcE7MnAyLB\n\tsnIWJ/69nKA7us2DgDtB1owusI7oDz7OtLyRN1nqz7YAl7PFf/DjXaQ8jJQacnBuru8dYhb+veD\n\tLlymg+Euv/n3ExnRD5sBu+s+6LTzky34nKMC8ob1+phBPIAOB5Q0iwnjp01rtUUz1NR5IX1AY7i\n\tgXNpn/dN436sUVEcI3Kk2fTEWoosl8","X-Received":"by 2002:adf:f9cd:0:b0:474:9991:60d0 with SMTP id\n\tffacd0b85a97d-47de6689bc8mr1669724f8f.12.1783376577296; \n\tMon, 06 Jul 2026 15:22:57 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"bryan.odonoghue@linaro.org, pavel@ucw.cz,\n\tRobert Mader ,\n\tMilan Zamazal ","Subject":"[PATCH v6 1/6] libcamera: software_isp: debayer_egl: Pass eglImage\n\tas parameter to setShaderVariables","Date":"Mon, 6 Jul 2026 23:22:40 +0100","Message-ID":"<20260706222245.247396-2-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260706222245.247396-1-bryan.odonoghue@linaro.org>","References":"<20260706222245.247396-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We will create a cache of textures and eGLImages which means the value\nassigned to the shader texture unit will come from one of those now cached\neGLImage objects.\n\nPass eGLImage as a parameter to facilitate future differentiation.\n\nReviewed-by: Robert Mader \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer_egl.cpp | 6 +++---\n src/libcamera/software_isp/debayer_egl.h | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 56545816e..c3a7b7952 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -388,7 +388,7 @@ uint32_t DebayerEGL::preferredInputStride(const PixelFormat &inputFormat, const\n \treturn info.stride(size.width, 0, 256);\n }\n \n-void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n+void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerParams ¶ms)\n {\n \t/*\n \t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n@@ -444,7 +444,7 @@ void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n \t * To simultaneously sample multiple textures we need to use multiple\n \t * texture units\n \t */\n-\tglUniform1i(textureUniformBayerDataIn_, eglImageBayerIn_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformBayerDataIn_, eglImageIn.texture_unit_uniform_id_);\n \n \t/*\n \t * These values are:\n@@ -533,7 +533,7 @@ int DebayerEGL::debayerGPU(FrameBuffer *input, FrameBuffer *output, const Debaye\n \t/* Generate the output render framebuffer as render to texture */\n \tegl_.createOutputDMABufTexture2D(*eglImageBayerOut_, output->planes()[0].fd.get());\n \n-\tsetShaderVariableValues(params);\n+\tsetShaderVariableValues(*eglImageBayerIn_, params);\n \tglViewport(0, 0, width_, height_);\n \tglClear(GL_COLOR_BUFFER_BIT);\n \tglDrawArrays(GL_TRIANGLE_FAN, 0, DEBAYER_OPENGL_COORDS);\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 4c7c86472..348d7305b 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -65,7 +65,7 @@ private:\n \tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n \tint getShaderVariableLocations();\n-\tvoid setShaderVariableValues(const DebayerParams ¶ms);\n+\tvoid setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams ¶ms);\n \tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *mappedInputBuffer, std::optional *inputBufferDmaSyncer);\n \n \t/* Shader program identifiers */\n","prefixes":["v6","1/6"]}