{"id":27238,"url":"https://patchwork.libcamera.org/api/patches/27238/?format=json","web_url":"https://patchwork.libcamera.org/patch/27238/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260706110120.2509826-2-bryan.odonoghue@linaro.org>","date":"2026-07-06T11:01:14","name":"[v4,1/7] libcamera: software_isp: debayer_egl: Pass eglImage as parameter to setShaderVariables","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6cfa7f4ff004a514ed7180481ae8fa4a2a191a73","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27238/mbox/","series":[{"id":6040,"url":"https://patchwork.libcamera.org/api/series/6040/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6040","date":"2026-07-06T11:01:13","name":"libcamera: software_isp: gpu: Add go faster stripes","version":4,"mbox":"https://patchwork.libcamera.org/series/6040/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27238/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27238/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FD9AC330F\n\tfor ;\n\tMon, 6 Jul 2026 11:01:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D84966021;\n\tMon, 6 Jul 2026 13:01:33 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF3C4658E0\n\tfor ;\n\tMon, 6 Jul 2026 13:01:31 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-47122683cf3so1815216f8f.0\n\tfor ;\n\tMon, 06 Jul 2026 04:01:31 -0700 (PDT)","from inspiron14p-linux ([109.77.44.220])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-47aa0960634sm25190846f8f.26.2026.07.06.04.01.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 06 Jul 2026 04:01:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"f6/P395r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1783335691; x=1783940491;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=s3J/NrfJsMXq4eaqAQimcvyIokeKF2MgvnNr4M7DXMo=;\n\tb=f6/P395ryGRD827SoUjiJICy0gjHgBhMxYsGzPIgDh93nIIKAgA9k8H1pXHlc0hOFK\n\tciyBSi1XfCXs+N9BO4ij5HE05Fw07B7zAVssDv2ZhPLlqE/VvDjg4EC13QCxqCNihmxW\n\to+f0RET8IuNLWaPKi7y7r5/zY9wzB8t/Qkw/rmWa4SAyTlLtxt1Kg3m28ZdSa+kN1l+v\n\tmASCzc6lKJaqHI7ZOt52iKXxaeckfB6pBa1kflf34gQ8+Ibg8R45D01fbweyavCYe4fh\n\tt31euJL9egDs9pmLwMZSgb4hjKR7OivDkK1e5BI3Bhv3wq3Plm8as80rbwo1Z6tfLdyj\n\tV4mA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1783335691; x=1783940491;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=s3J/NrfJsMXq4eaqAQimcvyIokeKF2MgvnNr4M7DXMo=;\n\tb=AViIcL+pkoJNj7EAF810io/JFbllG6T/tSTdAiqVbf6aTc1VS82vmrXr/TJzf3rV4y\n\tWjsN4EimKVmiZf/kudpORPugOfCo1Lx1dTYzvGD/q4QLiUM3elDFZQFo7TPJJTaieajc\n\tlbgzNBXZM9yExqcCBHnKXnOxITsEv8J/Y2QtUzd6vzt5HFlts7Ptc62I7p6YvhbblvDZ\n\tIZChoRBc9h7SRTGtwOTP5TFURMPS89PWlQM+z4iE2RuEbjJ6HQ/t7zRLxYvXeTbieQOJ\n\tG5NgYVmaq6Cf6Ykuw3637PSODDS5Vj8/bQKBnmJTmd5IaV+gbl9A+ZM6nnQCkBE/34ir\n\tfaxQ==","X-Gm-Message-State":"AOJu0YzFZvJXrVoenqY9B6sWi2amGDxBFIsSXo7t0lYiiJ9g2zt1oUrA\n\tpVD4YrnVZ14wyf79uhInAEmDdTE09/K4Y+HUg/1Kinw513BIcu6fx9Asrw/eDaAgG0DqlbgO5Di\n\tFwGnr","X-Gm-Gg":"AfdE7cme4sneSMHiAIds83uA/AdObm35ngpK3MxoGOOaatt0CK80tLw7uTotpfIICCK\n\tRBYHGU3ZkOz210jHLyNVrWUEZz0tpe52naCC3bmLVQnaBuYVT7bV/Qvim7RbvkwNa0VgwPb/bWT\n\tv8uzOM1YHnYGolNz2NHQyekCfgMSezBb/e0a5CohnEgEx4gvzu/Z34oHo6/NI8sM8NmU862Nbd/\n\tIp3zP1ozuO/mATASX91Dg2A7aRlLstkeoOUdwTocece2vwEcXXC0Igu9xMF0dSEmsNpgYySvZm+\n\t97ueLf3/5eb74WePga1Qjy4oK375+d9dckBESKoMrIcLQrYcFzmTngzv1WvU9a0kz1VEiJmNcvR\n\togZ3dPNsamQJSSC6dr7vYma3jnsfSMSswgoXeu106VzzmfmAeRVT8KeLFVXHe7AAYKSd/e27Hvy\n\tZszBFl1JSRYCbtEUreMbOl48RE2/48","X-Received":"by 2002:a5d:6f13:0:b0:475:f0f0:9ef0 with SMTP id\n\tffacd0b85a97d-47aaee4cf42mr10114815f8f.53.1783335691319; \n\tMon, 06 Jul 2026 04:01:31 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"bryan.odonoghue@linaro.org, pavel@ucw.cz,\n\tRobert Mader ,\n\tMilan Zamazal ","Subject":"[PATCH v4 1/7] libcamera: software_isp: debayer_egl: Pass eglImage\n\tas parameter to setShaderVariables","Date":"Mon, 6 Jul 2026 12:01:14 +0100","Message-ID":"<20260706110120.2509826-2-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260706110120.2509826-1-bryan.odonoghue@linaro.org>","References":"<20260706110120.2509826-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We will create a cache of textures and eGLImages which means the value\nassigned to the shader texture unit will come from one of those now cached\neGLImage objects.\n\nPass eGLImage as a parameter to facilitate future differentiation.\n\nReviewed-by: Robert Mader \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer_egl.cpp | 6 +++---\n src/libcamera/software_isp/debayer_egl.h | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 56545816e..c3a7b7952 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -388,7 +388,7 @@ uint32_t DebayerEGL::preferredInputStride(const PixelFormat &inputFormat, const\n \treturn info.stride(size.width, 0, 256);\n }\n \n-void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n+void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerParams ¶ms)\n {\n \t/*\n \t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n@@ -444,7 +444,7 @@ void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n \t * To simultaneously sample multiple textures we need to use multiple\n \t * texture units\n \t */\n-\tglUniform1i(textureUniformBayerDataIn_, eglImageBayerIn_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformBayerDataIn_, eglImageIn.texture_unit_uniform_id_);\n \n \t/*\n \t * These values are:\n@@ -533,7 +533,7 @@ int DebayerEGL::debayerGPU(FrameBuffer *input, FrameBuffer *output, const Debaye\n \t/* Generate the output render framebuffer as render to texture */\n \tegl_.createOutputDMABufTexture2D(*eglImageBayerOut_, output->planes()[0].fd.get());\n \n-\tsetShaderVariableValues(params);\n+\tsetShaderVariableValues(*eglImageBayerIn_, params);\n \tglViewport(0, 0, width_, height_);\n \tglClear(GL_COLOR_BUFFER_BIT);\n \tglDrawArrays(GL_TRIANGLE_FAN, 0, DEBAYER_OPENGL_COORDS);\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 4c7c86472..348d7305b 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -65,7 +65,7 @@ private:\n \tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n \tint getShaderVariableLocations();\n-\tvoid setShaderVariableValues(const DebayerParams ¶ms);\n+\tvoid setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams ¶ms);\n \tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *mappedInputBuffer, std::optional *inputBufferDmaSyncer);\n \n \t/* Shader program identifiers */\n","prefixes":["v4","1/7"]}