[{"id":39589,"web_url":"https://patchwork.libcamera.org/comment/39589/","msgid":"","date":"2026-07-06T10:26:35","subject":"Re: [PATCH] pipeline: rpi: pisp: Remove duplicated format entry","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Oops! Thanks for the fix.\n\nOn Mon, 6 Jul 2026 at 11:19, Kieran Bingham\n wrote:\n>\n> In the BayerToMbusCodeMap, the final MEDIA_BUS_FMT_SRGGB16_1X16 entry is\n> duplicated for 16 bit RGGB.\n>\n> Remove the duplicated line.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rpi/pisp/pisp.cpp b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> index c9d89d58bc98..5f7f20ccfb83 100644\n> --- a/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> +++ b/src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> @@ -80,7 +80,6 @@ const std::vector> BayerToMbusCodeMap{\n> { { BayerFormat::GBRG, 16, BayerFormat::Packing::PISP1 }, MEDIA_BUS_FMT_SGBRG16_1X16, },\n> { { BayerFormat::GRBG, 16, BayerFormat::Packing::PISP1 }, MEDIA_BUS_FMT_SGRBG16_1X16, },\n> { { BayerFormat::RGGB, 16, BayerFormat::Packing::PISP1 }, MEDIA_BUS_FMT_SRGGB16_1X16, },\n> - { { BayerFormat::RGGB, 16, BayerFormat::Packing::PISP1 }, MEDIA_BUS_FMT_SRGGB16_1X16, },\n> { { BayerFormat::MONO, 16, BayerFormat::Packing::None }, MEDIA_BUS_FMT_Y16_1X16, },\n> { { BayerFormat::MONO, 16, BayerFormat::Packing::PISP1 }, MEDIA_BUS_FMT_Y16_1X16, },\n> };\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE7FCC3308\n\tfor ;\n\tMon, 6 Jul 2026 10:27:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F170866009;\n\tMon, 6 Jul 2026 12:27:13 +0200 (CEST)","from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com\n\t[IPv6:2607:f8b0:4864:20::a2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7309658E0\n\tfor ;\n\tMon, 6 Jul 2026 12:27:12 +0200 (CEST)","by mail-vk1-xa2c.google.com with SMTP id\n\t71dfb90a1353d-5bd9890604aso64072e0c.0\n\tfor ;\n\tMon, 06 Jul 2026 03:27:12 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"NfIH1xTk\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1783333631; cv=none;\n\td=google.com; s=arc-20260327;\n\tb=j0P5NYXg33D63H5RGxVxD5m7nOPWi1Jc/bcLIMyAlaYcawJxKyax6i+qfEReE68URj\n\tILT0ZSiNgCToSXsVsg3HFdT2hxTufu6Xbi0E21ltBIL9Uz0vZFQkotUo2t6/1g30hh9H\n\tQxFM3UdRNWj0C+IIdCQ+tvklk5vXaFul7UNllIcMQjBK1HBCjQmUfEcHp3Osz5+Krjm6\n\tZRq0Qneuw/8axvbALYxGCrLziWshmh/kh1P7ucliDz6eBHtqfhVHdHSg3+Y+FUE4VuC3\n\t0HnBRvU9lpNnNPQu8CeZf4mikxBczos/uyjsGlzgcwQu2rxl172zlA/BwGWUnRWW6TET\n\tR0xw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20260327; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=kBNI99GdfJXL0TiuRjBfDgfTI5xgXJavVkfC1TrL26Y=;\n\tfh=XLD85mX0z6oRdIm5js4gSpCB7OsItLOAwi97d5KWTwA=;\n\tb=Ka1/ixEWGKHCR+cyievtpqDImxHoqS2d0woEjrwjrBTOTPVVcjdgxBRr9DyxVe4H/X\n\tevuN9shtToQ8kcDjhzExVC+KwtpOpIIGIt5rchq9NmAxU2NZMsZns71a1SdTEWfF7nmb\n\t6UoGCqWzwL5/1rtb4NAZSMYi92gtkJxUGA3TPOI+usOaV8yZDSoyjX04wfd9pFYS0RbY\n\too1QYOZ20N/qwvwgS7hwgVvIeqFGhYq9L5OmlvvZKXD+gJPp3ifa13PC3HHpi2/H9sdC\n\tkE39ad+I5kzCdmFlbNf7pdBS2n8+/IJdeQXD0hGQsdwwdCE6eswJIcCwBMdfS3IlubP2\n\tgLtg==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1783333631; x=1783938431;\n\tdarn=lists.libcamera.org; \n\th=content-type:cc:to:subject:message-id:date:from:in-reply-to\n\t:references:mime-version:from:to:cc:subject:date:message-id:reply-to\n\t:content-type; bh=kBNI99GdfJXL0TiuRjBfDgfTI5xgXJavVkfC1TrL26Y=;\n\tb=NfIH1xTkr+fmfkQ/sMDOGBCtNvHhBbbExbPM7uhCriRpkTJfx2C1ieKuCAb0kYgVAS\n\tMQfMYvGNo/g+L8GY/B8Ue9YwB/Vf3xQF41XGBp9gTvxyMcc6Yw6wdzWfGtx7/7DUGE3+\n\tqYZj6CEH0nmFmTV5bLAwK9j85ETU8peNQkVHg5rTGupw3WXHqMc/cl2xvQpFs0W2nbJT\n\tmUFzuyWbNQpFE2sjMjDcXfUKBQgIT8eOXPLJaCPDSlx8P9SV69lIw4RLeobM4XnNlfGA\n\tQONqViBCeD8IzRsus+AOhOvZbEYJgry1CrpNmUmu2O5cL1XBkL/W1ZkSpEYTkhPwothK\n\tYlTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1783333631; x=1783938431;\n\th=content-type:cc:to:subject:message-id:date:from:in-reply-to\n\t:references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to:content-type;\n\tbh=kBNI99GdfJXL0TiuRjBfDgfTI5xgXJavVkfC1TrL26Y=;\n\tb=Rtj4NnVP3Dc3jDvlnVU7EvnlleyEDjZ+uqW8tPtOTz0q78Cf97qoSXh6NbT6gBPi62\n\teudIJZP0xGd9xerMYvDNIFRcWLn3rYr4RP+hM0FkgK8hVU13Z6dQklsMkgH6ePc6sqMr\n\ta6Hxrhefuf5IB7ZkzWENwNnmpZ7axYJCMUxNqQgaC2JFA2N/TNMVHgTL0ggdGQGdJ/SO\n\t5KnBM3g4bV7ve+gopKhq45pM7qh0Ir45pdmY0gAP3BVDdsKrzCQTC3DuYuZvDS+pvKfi\n\t/UdgrlFuC3PyU3n/b4uQ6o7dLkN4O/WKGPHmnLsrP4rPFYUJP4oy8nfVtH6GAKT07jNp\n\tZA8Q==","X-Gm-Message-State":"AOJu0YxBIeCosDj75D8TDIjh4TxWjqd1xzr7jmAGOi4Tbj9xAlvmmlLh\n\tU2PWublRM0vSFddwbBMQkGU1PdmGSnGpcf7mY6SUle0AT0++KiezQoyVv3XALaOCRraqC8ODAYD\n\txuY4LDyrIv7cXOcyDBncyyC6+hDkbSpAZASDlN1KGMQIrvw/et/1swOU=","X-Gm-Gg":"AfdE7clIqcx93zbQCjWZdMGWt1WjzClKbk1bWnyLu0XoYWL+oun5mrZMSFXme4xlWSS\n\t5TwbA3313+58+zPlXkTmgghx/nglCR4YcZpWjv269aLBr+UNd1MFkbvJGjlHYbX0E8Tv0z2EVEU\n\ttgqoz+SCC+qJbQ+T1rIgT0LcuDEcQR05OUphlJLi4WKWJE+jiaJRuSyZk80zmZP2hJfo54uhWG6\n\tKmTKE1uXR53YMzMu9ESjBrKpsYRq6R5U81L1tB4p52iLtOO0JxvgTlwUAOn5SLlcAWnkMQtkw7W\n\t5WY4yuslVyNbSKe+WYAK4UNnjkn+vN2MZQ1L2E597nhUjXM4a3b6HzXjhDcgxJ3wXAHpDD/g3GT\n\tWtNJw4YEJske4v++ZJhcAX55Rxq9E+9sglAYrNIbx4eg25CdeXL5rZ3Bu/0H0U15odnpZaPO8gy\n\tr+ZLvCij97WnE=","X-Received":"by 2002:a05:6102:32d0:b0:738:a78f:5483 with SMTP id\n\tada2fe7eead31-741f6b090d8mr1208147137.2.1783333631223;\n\tMon, 06 Jul 2026 03:27:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20260706101928.3042026-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20260706101928.3042026-1-kieran.bingham@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 6 Jul 2026 11:26:35 +0100","X-Gm-Features":"AVVi8CfP08u9gPfk0cgM_BamCZbWg48aU0E9HzZ4leDNf4DJ2_Re6AmLk1cqJ-4","Message-ID":"","Subject":"Re: [PATCH] pipeline: rpi: pisp: Remove duplicated format entry","To":"Kieran Bingham ","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]