{"id":27230,"url":"https://patchwork.libcamera.org/api/patches/27230/?format=json","web_url":"https://patchwork.libcamera.org/patch/27230/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260706-libipa-algorithms-v3-30-968757b038bb@ideasonboard.com>","date":"2026-07-06T08:01:50","name":"[v3,30/35] ipa: libipa: lsc_base: Describe the function of lsc_base","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4d6f53105c80c32bfd93b0c3dc1881d383522c88","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27230/mbox/","series":[{"id":6038,"url":"https://patchwork.libcamera.org/api/series/6038/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6038","date":"2026-07-06T08:01:20","name":"ipa: libipa: Introduce libipa algorithms","version":3,"mbox":"https://patchwork.libcamera.org/series/6038/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27230/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27230/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 379B8C330A\n\tfor ;\n\tMon, 6 Jul 2026 08:02:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC6B066060;\n\tMon, 6 Jul 2026 10:02:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 406C866024\n\tfor ;\n\tMon, 6 Jul 2026 10:02:17 +0200 (CEST)","from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D46B83FF5;\n\tMon, 6 Jul 2026 10:01:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kUlFu5Ct\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324889;\n\tbh=wb0bQGsjGojAwnPuRxkfgTB4xkOkV0ZPsl0VfiBQO/U=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=kUlFu5CtDo7/qbFZZ44J1E07X+Bto85HIMcboQx6RagkKCTNbWMlHom1AdhuQPqQO\n\t8O2SQANQEhS+4AveB6HUtYanc2s9kXQPiwqT3aXzo/eRoVi1CTivjfN32p8ISVk+IU\n\t+9hHJVPBDXOw7TfQECVugsMnrH/1y5rxBxpNIAbg=","From":"Jacopo Mondi ","Date":"Mon, 06 Jul 2026 10:01:50 +0200","Subject":"[PATCH v3 30/35] ipa: libipa: lsc_base: Describe the function of\n\tlsc_base","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260706-libipa-algorithms-v3-30-968757b038bb@ideasonboard.com>","References":"<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>","In-Reply-To":"<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1646;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=wb0bQGsjGojAwnPuRxkfgTB4xkOkV0ZPsl0VfiBQO/U=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DysL4dkzzQCpaTw9z+c9CFa3zPozBKTQr47\n\tzYDs71Q3NuJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8gAKCRByNAaPFqFW\n\tPKE1D/40qaGfQ+3tYWk+WWLD6NBnXBQ9s6Rk0hRQFPAdBEttwL5KDM/FSO/Kmhc2LH9WyUjrUzp\n\t0XhGuJCxdP8pKaj8D88C3h6IrIF6Wk1UTcRnHlcw7E7XPuUrulZ0vj8mHhRMP5y9sD5Kbm0RR8X\n\tkWI6aEXB2Xf/aDr0bluVpK2o7p6+0LOPsn3DxcQ80WOxSCK8XJMXfRp189zhKiSF+2zi6IYG9me\n\t7xA3yDZQU2ZvPKUTh+VqdArdqnkYQSYqILCWilgvNvzcsp8eI6hQqnHn8TNEKIlDJx13w9fliYL\n\tQl1nUURk1KoHZMhi8xkPyoAVH5FpIhPqxc5QA7Pf/G1148QH6CNmRjTbANV+ookWlAHRfKuEHfj\n\t+OH5yR3TIzHci0vNdULHJR5rxYaFmGphT5j2N5oLsjJjk4AW+GymhaXh3xqE0rmYhjs7jpqQdq3\n\tZXP3/Hpznp6XaYREnh5Gs3fs/El3sAk3Lgj6ZJr1EKAfcoXkBv3vLSaAjtK+x2quvZkGqFr8UC1\n\tuj2SX01FTaU2xqIR+I4tJw9g2N3IjQW/fwWbIqImfDyoSAM3iK9egTkNeb+FL7kW2UpXJ1fcFGn\n\tGX5TKrdJNPDXgm51pdCtnc5ptTCSfQAEZ+JkbctdOdL1zQykKZdoqOY7i3nLqFl6axYAeyI6OAs\n\t0zZecvnh1t3NBZg==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that the class hierarchy is in place, describe the function\nof the lsc_base header in the file comment.\n\nSigned-off-by: Jacopo Mondi \n---\n src/ipa/libipa/lsc_base.cpp | 16 +++++++++++++++-\n 1 file changed, 15 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 0eeb99f6881a..0c3a10d25cf8 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -10,6 +10,19 @@\n /**\n * \\file lsc_base.h\n * \\brief Base types and definitions for LscImplementation class hierarchy\n+ *\n+ * Split the common classes and types definitions to a dedicated file to avoid\n+ * circular inclusions.\n+ *\n+ * Both LscTable and LscPolynomial inherit from LscImplementation and they are\n+ * instantiated from lsc.h as the LscAlgorithm::init() function is there inlined.\n+ *\n+ * For this reason lsc.h needs to include lsc_table.h and lsc_polynomial.h which\n+ * need the LscImplementation class definition themselves.\n+ *\n+ * Split the LscImplementation interface definition to this file so that it can\n+ * be included by both lsc_table.h and lsc_polynomial.h, which are then included\n+ * by lsc.h.\n */\n \n namespace libcamera {\n@@ -88,7 +101,8 @@ void Interpolator::\n * \\brief Pure virtual base class for lsc algorithm implementations\n * \\tparam U The fixedpoint lsc engine register format\n *\n- * Defines the interface for the lsc algorithm implementation.\n+ * Defines the interface for the lsc algorithm implementation. Currently\n+ * implemented by LscTable and LscPolynomial.\n */\n \n /**\n","prefixes":["v3","30/35"]}