[{"id":409,"web_url":"https://patchwork.libcamera.org/comment/409/","msgid":"<20190118153807.GR6484@bigcity.dyn.berto.se>","date":"2019-01-18T15:38:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: utils: Don't use C++17\n\tnested namespaces","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-18 15:08:23 +0200, Laurent Pinchart wrote:\n> Nesting namespace names in a single namespace declaration is a C++17\n> feature. As libcamera depends on C++11 only, nest two separate namespace\n> declarations instead.\n> \n> Reported-by: Shik Chen \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/utils.h | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n> index a2e450b35372..73fa2e69b029 100644\n> --- a/src/libcamera/include/utils.h\n> +++ b/src/libcamera/include/utils.h\n> @@ -11,7 +11,9 @@\n> \n> #define ARRAY_SIZE(a)\t(sizeof(a) / sizeof(a[0]))\n> \n> -namespace libcamera::utils {\n> +namespace libcamera {\n> +\n> +namespace utils {\n> \n> /* C++11 doesn't provide std::make_unique */\n> template\n> @@ -20,6 +22,8 @@ std::unique_ptr make_unique(Args&&... args)\n> \treturn std::unique_ptr(new T(std::forward(args)...));\n> }\n> \n> -} /* namespace libcamera::utils */\n> +} /* namespace utils */\n> +\n> +} /* namespace libcamera */\n> \n> #endif /* __LIBCAMERA_UTILS_H__ */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B086D60B21\n\tfor ;\n\tFri, 18 Jan 2019 16:38:11 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id t18-v6so12005352ljd.4\n\tfor ;\n\tFri, 18 Jan 2019 07:38:11 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tx18-v6sm869078lji.27.2019.01.18.07.38.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 18 Jan 2019 07:38:07 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=/eABFZ7r4DjAFQ+o/kg2xknY5AMTYdq2eSSYMm/9k7M=;\n\tb=ZQlROUWhNu1MOM4UrwraammWsvTtFgciu4p0Ys3/eh8/EQO597gTazWs2eFo10hHj0\n\tK3vEk+ocJU/ADw8sxb1w+tJfLpoe2qG2eKboRBj1MDtXPMoyRDbic5xLnd36Nh7IXkUP\n\tGBYFHXiwyz1EyOmAfrLZ/KovDIiXizdW5u/5S7o1APJP4S9Q5ggnb7yYtHygtBXaoAU4\n\tosQncLQUuXu4QojiaqtNtvrU4kKZrPUz/kVEiFFT+UN/W68Pxk0HT/eROV4tWtPH3Xje\n\tr8CKp0f5uHu3M2F6jC3QaKecCLYovrQmxe1AGocXHEaI4ELZ3pCOdODtAXRL+3AcOYpM\n\tygkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=/eABFZ7r4DjAFQ+o/kg2xknY5AMTYdq2eSSYMm/9k7M=;\n\tb=Uhyws05QgOnnORNmXkeyf06sbYDw3OTjeLP2+9+Ej3rvXn69aQ1cKPnWCQ92rk7T2w\n\tDy9i480MlQFpZ71eaq1HcMn8ThWRu+K++zKEPu8fs8Gdom6WbilAmXegSQ/6/oeD0bp8\n\t3Pk7MLTIFpzaDmFbsvNMMk8nGOYvUA7wztk1Sty6uujVUJQ29wdQyOHjdOqv7rORgjOi\n\tqsOZ0+8/CZobmR8TqUjVGqoR9csUg+nczsMgsK6qmgak+viw1yu3VxCiQ+Hp7OMLhBYh\n\thKLguL09UNwiDzxab3jPlgFfBfRFkYTjKkQq/IZ4hn5rm/oEVvS2/H0zK+hjqjyiqxvO\n\txw+A==","X-Gm-Message-State":"AJcUukdHlE7MkU+TwMvuDsjGDYfhqJc0ec/oUHTH1KxgkNVTisY8W1D8\n\tsSp2/CFSUDv1PNvusbkX7N9BJA==","X-Google-Smtp-Source":"ALg8bN7z1mSHzCUNuNIWbUtM/SEKCWKXlWK+p625eGk05aE2SihJb9lS0lto4wS9bHk80eyIGw1VmA==","X-Received":"by 2002:a2e:9c52:: with SMTP id\n\tt18-v6mr10985307ljj.149.1547825888649; \n\tFri, 18 Jan 2019 07:38:08 -0800 (PST)","Date":"Fri, 18 Jan 2019 16:38:07 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190118153807.GR6484@bigcity.dyn.berto.se>","References":"<20190118130823.22541-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190118130823.22541-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: utils: Don't use C++17\n\tnested namespaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 18 Jan 2019 15:38:12 -0000"}}]