{"id":27193,"url":"https://patchwork.libcamera.org/api/patches/27193/?format=json","web_url":"https://patchwork.libcamera.org/patch/27193/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260703153819.1088752-15-barnabas.pocze@ideasonboard.com>","date":"2026-07-03T15:38:16","name":"[RFC,v1,14/17] ipa: libipa: agc_mean_luminance: controls(): Return const ref","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"df5661fe0fcb7da8d3ecc43887be2e2b1597d4b3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27193/mbox/","series":[{"id":6036,"url":"https://patchwork.libcamera.org/api/series/6036/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6036","date":"2026-07-03T15:38:02","name":"ipa: libipa: agc rework","version":1,"mbox":"https://patchwork.libcamera.org/series/6036/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27193/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27193/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73823C3318\n\tfor ;\n\tFri, 3 Jul 2026 15:38:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A2B36600F;\n\tFri, 3 Jul 2026 17:38:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2C7365FE0\n\tfor ;\n\tFri, 3 Jul 2026 17:38:25 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE1AE1121\n\tfor ;\n\tFri, 3 Jul 2026 17:37:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NDxKQWmQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783093059;\n\tbh=5WOirKhO6Iav3CeuKawf9yYkxt2wqOKxdj7itOI3kWY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NDxKQWmQ/NB91RoN9LmoOu4yBQEe9eGlJnf7W4TKwjcNszzZcmVL/TMFRCUJRBoXk\n\tpoMru7Lwj65iZDEj1laBiFg6Aoerr6LzIPaxtbsSX5C9kuTom1TPrZWCF0ZnobbqWK\n\twyxfnpLB5XqgoUVLjxnLvxGWph2JsnSswdEWmtmo=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 14/17] ipa: libipa: agc_mean_luminance: controls():\n\tReturn const ref","Date":"Fri, 3 Jul 2026 17:38:16 +0200","Message-ID":"<20260703153819.1088752-15-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>","References":"<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that no users use `std::unordered_map::merge()` to add the controls\nto the control info map, there is no reason to return a copy.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/libipa/agc_mean_luminance.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex 3378ec7faa..e7e2d8ad0d 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -78,7 +78,7 @@ public:\n \t\treturn exposureModeHelpers_;\n \t}\n \n-\tControlInfoMap::Map controls()\n+\tconst ControlInfoMap::Map &controls() const\n \t{\n \t\treturn controls_;\n \t}\n","prefixes":["RFC","v1","14/17"]}