[{"id":3589,"web_url":"https://patchwork.libcamera.org/comment/3589/","msgid":"<20200123202208.wnh3was2eihffdjq@oden.dyn.berto.se>","date":"2020-01-23T20:22:08","subject":"Re: [libcamera-devel] [PATCH v2 03/13] libcamera: camera_manager:\n\tReturn a copy of the vector from cameras()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-22 22:57:13 +0200, Laurent Pinchart wrote:\n> Making CameraManager::cameras() thread-safe requires returning a copy of\n> the cameras vector instead of a reference. This is also required for\n> hot-plugging support and is thus desirable.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/camera_manager.h | 2 +-\n> src/libcamera/camera_manager.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 068afd58762f..079f848aec79 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -30,7 +30,7 @@ public:\n> \tint start();\n> \tvoid stop();\n> \n> -\tconst std::vector> &cameras() const;\n> +\tstd::vector> cameras() const;\n> \tstd::shared_ptr get(const std::string &name);\n> \tstd::shared_ptr get(dev_t devnum);\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index e0a07ec557d3..5fc1bba974c6 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -244,7 +244,7 @@ void CameraManager::stop()\n> *\n> * \\return List of all available cameras\n> */\n> -const std::vector> &CameraManager::cameras() const\n> +std::vector> CameraManager::cameras() const\n> {\n> \treturn p_->cameras_;\n> }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0A29607EF\n\tfor ;\n\tThu, 23 Jan 2020 21:22:10 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id t23so114497lfk.6\n\tfor ;\n\tThu, 23 Jan 2020 12:22:10 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\te17sm1864104ljg.101.2020.01.23.12.22.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 23 Jan 2020 12:22:09 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=cAquwIbYz5Boa38bMgLwR7Q69PJWZKndvjJ0p2SiabA=;\n\tb=Ibg3pLWTBBzfDnUdOdoj+NAokjTPm82sobKqhHk63D1AvwDLXrBBBTYwZbX7qtv4Zk\n\tCkPMq4tWA4aMn1pcUxKBJdZ5mBs+caytlv8JICNtMbogDc+9Dd/FxmzaTeO/B3enyKMh\n\tBhGbcCVKwWr31wg30lfFC7uCRzvIe6Uc6s1hAjBKrVgGon03KPa2LBtDOKzVePW/5uhA\n\tUUT9jflWw7KrHTtZoTr+ijtxFeLaEzsZZzXLfuDhWzoZ7sR/1DBnndw6+uNlOzI4SYpU\n\tRuTg/szptfyStqWmwSQAtreCWzwzkAlYYo53anVmKx9RH7xi8VCNkCwHkjy0fp1wTLm1\n\toUhg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=cAquwIbYz5Boa38bMgLwR7Q69PJWZKndvjJ0p2SiabA=;\n\tb=YsYZNDs+CF+2yRWRD/3VRcFKR2pm8dTcdcJPlyYn75ZRuNhbpa0m51QX/sDodtq6PS\n\td0atYQHqHmdkcs1xfnu+J9tE5Nc6h2QtF76Sy4/5/R1NoRbon+8jMHIKRyCvyJx5sMqj\n\tCW7lLbXQa0a6xNmotYw+xAwMk1l8BON/vcj/wqx9zMtZtcNrUoxyH0Jh9+LZ28mM6zgY\n\t1VFWEaTTM3hyrdfgB6CLn8PpHZbEm8uM5q2fLSw68j99+I54KgyoU7t6ngrijEMgRpp+\n\t7MD0bjv3yIlrgNXqC4VCMVfiIWOAVWxgUwK8YhutHMd/RnTxyP4Fp3QxzSSemr8ItEbI\n\t5Avw==","X-Gm-Message-State":"APjAAAUg5w+e6uQDooWqGgiF3H6quYJWr1cUeQdJ40aCSlovqOap/Py6\n\tGjSGq2VNcL2jwYXn3+iYo/DAwgBQOWk=","X-Google-Smtp-Source":"APXvYqxpFp5nOtWy9zWHDY7aVHN5LphJo2OaG8+ZT9zui/J0Mhdh2v8ac/omXk6tPC1rAlI+8XsrgQ==","X-Received":"by 2002:ac2:5147:: with SMTP id q7mr5602467lfd.87.1579810929962; \n\tThu, 23 Jan 2020 12:22:09 -0800 (PST)","Date":"Thu, 23 Jan 2020 21:22:08 +0100","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200123202208.wnh3was2eihffdjq@oden.dyn.berto.se>","References":"<20200122205723.8865-1-laurent.pinchart@ideasonboard.com>\n\t<20200122205723.8865-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200122205723.8865-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 03/13] libcamera: camera_manager:\n\tReturn a copy of the vector from cameras()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 23 Jan 2020 20:22:11 -0000"}}]