{"id":27120,"url":"https://patchwork.libcamera.org/api/patches/27120/?format=json","web_url":"https://patchwork.libcamera.org/patch/27120/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-41-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:30:03","name":"[RFC,v1,40/54] apps: cam: Use camera buffer pool","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"36c7e00fc7c943bea6c05ea8f96e03a278eceba6","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27120/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27120/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27120/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 943C7C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4049165FBC;\n\tMon, 29 Jun 2026 18:31:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BA3A65F64\n\tfor ;\n\tMon, 29 Jun 2026 18:30:30 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E98A41044\n\tfor ;\n\tMon, 29 Jun 2026 18:29:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kKR63sam\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750587;\n\tbh=rNdZNN7v1xAahbXGvApcE11d2/muHTpm2AxB3CgCdis=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=kKR63samUeUtpGv1xhaZil0lnT4Aql6bzUC/mh+8wqXUOyEnO5MQUfMYV+1kI8QpO\n\thaZN3+TTqTtqDxl6iPO3hR4Ky9LLq2Nv6bbo7w39WEEx0UjVAuB3UzTF13nyrTK+53\n\tEN6Fn6IhDRLrJKI2bIqVWzShWLYe5g1egV6FrIHo=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 40/54] apps: cam: Use camera buffer pool","Date":"Mon, 29 Jun 2026 18:30:03 +0200","Message-ID":"<20260629163017.863145-41-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Convert the `cam` application to use the new buffer pool interface\nof cameras.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/apps/cam/camera_session.cpp | 25 ++++++++++++++++++-------\n 1 file changed, 18 insertions(+), 7 deletions(-)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex f90800caf8..fc91bb312a 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -388,12 +388,7 @@ int CameraSession::startCapture()\n \t\t\t\tallocator_->buffers(stream);\n \t\t\tconst std::unique_ptr &buffer = buffers[i];\n \n-\t\t\tret = request->addBuffer(stream, buffer.get());\n-\t\t\tif (ret < 0) {\n-\t\t\t\tstd::cerr << \"Can't set buffer for request\"\n-\t\t\t\t\t << std::endl;\n-\t\t\t\treturn ret;\n-\t\t\t}\n+\t\t\trequest->enableStream(stream, true);\n \n \t\t\tif (sink_)\n \t\t\t\tsink_->mapBuffer(buffer.get());\n@@ -418,6 +413,15 @@ int CameraSession::startCapture()\n \t\treturn ret;\n \t}\n \n+\tfor (const StreamConfiguration &cfg : *config_) {\n+\t\tStream *stream = cfg.stream();\n+\t\tconst std::vector> &buffers =\n+\t\t\tallocator_->buffers(stream);\n+\n+\t\tfor (const auto &buffer : buffers)\n+\t\t\tcamera_->addBuffer(stream, buffer.get());\n+\t}\n+\n \tfor (std::unique_ptr &request : requests_) {\n \t\tret = queueRequest(request.get());\n \t\tif (ret < 0) {\n@@ -548,6 +552,13 @@ void CameraSession::processRequest(Request *request)\n \n void CameraSession::requeueRequest(Request *request)\n {\n-\trequest->reuse(Request::ReuseBuffers);\n+\tfor (const auto &[stream, buffer] : request->buffers())\n+\t\tcamera_->addBuffer(stream, buffer);\n+\n+\trequest->reuse();\n+\n+\tfor (const auto &cfg : *config_)\n+\t\trequest->enableStream(cfg.stream(), true);\n+\n \tqueueRequest(request);\n }\n","prefixes":["RFC","v1","40/54"]}