{"id":27118,"url":"https://patchwork.libcamera.org/api/patches/27118/?format=json","web_url":"https://patchwork.libcamera.org/patch/27118/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-40-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:30:02","name":"[RFC,v1,39/54] libcamera: camera: queueBuffer(): Reject if it has buffers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2fe281ad44100c371bb673c4d1410c0dcfccb673","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27118/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27118/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27118/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5693FC3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFB7665FD0;\n\tMon, 29 Jun 2026 18:31:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0D9265F38\n\tfor ;\n\tMon, 29 Jun 2026 18:30:29 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C94EE91\n\tfor ;\n\tMon, 29 Jun 2026 18:29:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sNjD2Iwp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750586;\n\tbh=odxPTq4XczUbF5oAC9jgieq8AP5Bba8TWoPc3FRjISk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=sNjD2IwpfMnHpFm/9ETgLyuuxqCMhkzL2v9VWyTGA3sH3l+T9jdUpi8zZWzFE2ERu\n\tnmyPSnBcUK5fJq75NjQF9igbEUqfqjCzKxa4k6hqxegqHaFDcyBjk6b8w5LGQVd+ws\n\tvyknoiaNqGj9ohCKmgCPr4XTLke7rOLJ7+nW2Dxs=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 39/54] libcamera: camera: queueBuffer(): Reject if it\n\thas buffers","Date":"Mon, 29 Jun 2026 18:30:02 +0200","Message-ID":"<20260629163017.863145-40-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If a request has buffers, it means it was not `reuse()`d properly,\nso reject those requests.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/camera.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex a9e6708fbf..a1f90a35c0 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -1459,6 +1459,11 @@ int Camera::queueRequest(Request *request)\n \t\t\tLOG(Camera, Error) << \"Invalid request\";\n \t\t\treturn -EINVAL;\n \t\t}\n+\n+\t\tif (buffer) {\n+\t\t\tLOG(Camera, Error) << \"Request contains buffers\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \t/* Pre-process AeEnable. */\n","prefixes":["RFC","v1","39/54"]}