{"id":27111,"url":"https://patchwork.libcamera.org/api/patches/27111/?format=json","web_url":"https://patchwork.libcamera.org/patch/27111/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-31-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:53","name":"[RFC,v1,30/54] libcamera: camera: acquireBuffer(): Add","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eebc9f817b5f7f992290042317710a675bf5b58c","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27111/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27111/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27111/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 451D4C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1B2C65F6E;\n\tMon, 29 Jun 2026 18:31:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACD1E65F52\n\tfor ;\n\tMon, 29 Jun 2026 18:30:27 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 889AB8D4\n\tfor ;\n\tMon, 29 Jun 2026 18:29:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nRJGZKit\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750584;\n\tbh=6zMfW1QrfaD4094EYcb4KWHpwrWoVkq8ywougfxB1r0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=nRJGZKithasI2eBM2mfWr08BTCsZH6c9lzCKVCn/lFIOrrVgbvI/egBCUd2j+Gzy1\n\tH1OUl/ejL/T+4NYULjB7Q20TdoXtg7ibwdrZ56y1amEwzZc2pojVOrwPQoA0jIeVTG\n\tco2Ojj6xVfIagNIrp1hIDlAdhRS+JsOf082IopdM=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 30/54] libcamera: camera: acquireBuffer(): Add","Date":"Mon, 29 Jun 2026 18:29:53 +0200","Message-ID":"<20260629163017.863145-31-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add an internal function for pipeeline handlers that can be used to\nretrieve a buffer from the pool of a specific stream.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/camera.h | 11 +++++++++\n src/libcamera/camera.cpp | 36 +++++++++++++++++++++++++++++\n 2 files changed, 47 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 6ba77eb882..31914075f0 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -49,6 +49,17 @@ public:\n \n \tconst CameraControlValidator *validator() const { return validator_.get(); }\n \n+#ifndef __DOXYGEN__\n+\tstruct FrameBufferPoolDeleter {\n+\t\tstd::vector *pool = nullptr;\n+\t\tvoid operator()(FrameBuffer *buffer) const;\n+\t};\n+#endif\n+\n+\tusing PooledFrameBuffer = std::unique_ptr;\n+\n+\t[[nodiscard]] PooledFrameBuffer acquireBuffer(const Stream *stream);\n+\n private:\n \tenum State {\n \t\tCameraAvailable,\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 27dae3a403..016f36e796 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -754,6 +754,42 @@ Camera::Private::PendingFence::PendingFence(const Stream *s, FrameBuffer *b)\n \t buffer(b)\n {\n }\n+\n+/**\n+ * \\typedef Camera::Private::PooledFrameBuffer\n+ * \\brief An std::unique_ptr for automatically returning the FrameBuffer to the pool to simplify error handling.\n+ */\n+\n+#ifndef __DOXYGEN__\n+void Camera::Private::FrameBufferPoolDeleter::operator()(FrameBuffer *buffer) const\n+{\n+\tpool->push_back(buffer);\n+}\n+#endif\n+\n+/**\n+ * \\brief Acquire a buffer for a stream\n+ * \\param[in] stream The stream\n+ *\n+ * \\return A buffer or an empty handle if not available\n+ */\n+Camera::Private::PooledFrameBuffer\n+Camera::Private::acquireBuffer(const Stream *stream)\n+{\n+\tauto it = streamData_.find(stream);\n+\tif (it == streamData_.end() || !it->second.active || it->second.buffers.empty())\n+\t\treturn {};\n+\n+\tFrameBuffer *buffer = it->second.buffers.back();\n+\tbuffer->_d()->stream_ = stream;\n+\n+\tLOG(Camera, Debug)\n+\t\t<< \"Camera:\" << LIBCAMERA_O_PTR() << \" acquired buffer:\"\n+\t\t<< buffer << \" for stream:\" << stream;\n+\n+\tit->second.buffers.pop_back();\n+\treturn { buffer, { &it->second.buffers } };\n+}\n #endif /* __DOXYGEN_PUBLIC__ */\n \n /**\n","prefixes":["RFC","v1","30/54"]}