{"id":27110,"url":"https://patchwork.libcamera.org/api/patches/27110/?format=json","web_url":"https://patchwork.libcamera.org/patch/27110/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-33-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:55","name":"[RFC,v1,32/54] libcamera: pipeline_handler: buffersAddedDevice(): New virtual function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ed074e54977b61ad83e96631faccc74b8dda7f53","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27110/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27110/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27110/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86880C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02A8965FB8;\n\tMon, 29 Jun 2026 18:31:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25A4365F5B\n\tfor ;\n\tMon, 29 Jun 2026 18:30:28 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EFD7F8D4\n\tfor ;\n\tMon, 29 Jun 2026 18:29:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hf2e1wMd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750585;\n\tbh=yKt850JBOLibER23MkcXsYZCeB/TFGRIQObBLMLjw4c=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Hf2e1wMdpnCupJ2WlVkxwMZeyYgbjEkALR4cLUwkXHtiO6GnqK21EEckAUS4zpyfd\n\t9WYNixs+FuOfy8/3QC8gQC1ApDyq/6v1yAnniGLAzFwjLGE80BXkmSG806oxsIlYmd\n\tWe103o6HwiBQpja0xJYcjF0A5Eb5+huxDjQLte5E=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 32/54] libcamera: pipeline_handler:\n\tbuffersAddedDevice(): New virtual function","Date":"Mon, 29 Jun 2026 18:29:55 +0200","Message-ID":"<20260629163017.863145-33-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This function allows pipeline handlers to be notified every time\nnew buffers are added to the camera's buffer pool.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/pipeline_handler.h | 2 ++\n src/libcamera/pipeline_handler.cpp | 22 +++++++++++++++++++\n 2 files changed, 24 insertions(+)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex d7544642fb..d5b8fdb730 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -103,6 +103,8 @@ protected:\n \tvirtual bool acquireDevice(Camera *camera);\n \tvirtual void releaseDevice(Camera *camera);\n \n+\tvirtual void buffersAddedDevice(Camera *camera);\n+\n \tCameraManager *manager_;\n \n private:\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 36e1509b2b..16f218831c 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -672,10 +672,32 @@ void PipelineHandler::cancelRequest(Request *request)\n \tcompleteRequest(request);\n }\n \n+/**\n+ * \\brief Notify about buffer addition\n+ * \\param[in] camera The camera\n+ *\n+ * Pipeline handlers may override this function in order to be notified\n+ * after buffers have been added to the camera's buffer pool.\n+ *\n+ * \\note This function is only called if the pipeline handler has opted into\n+ * using the buffer pool at construction time.\n+ *\n+ * \\context This function is called from the CameraManager thread.\n+ *\n+ * \\todo more info?\n+ *\n+ * \\sa Camera::addBuffer()\n+ */\n+void PipelineHandler::buffersAddedDevice([[maybe_unused]] Camera *camera)\n+{\n+}\n+\n void PipelineHandler::buffersAdded(Camera *camera)\n {\n \tif (!options_.usesBufferPool)\n \t\tdoQueueRequests(camera);\n+\telse\n+\t\tbuffersAddedDevice(camera);\n }\n \n /**\n","prefixes":["RFC","v1","32/54"]}