{"id":27097,"url":"https://patchwork.libcamera.org/api/patches/27097/?format=json","web_url":"https://patchwork.libcamera.org/patch/27097/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-19-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:41","name":"[RFC,v1,18/54] libcamera: request: Remove `ReuseBuffers`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8b9fa9963ebfc4e51e14091d63ad2881d7e79cf3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27097/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27097/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27097/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A098C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:31:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D192165F48;\n\tMon, 29 Jun 2026 18:30:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 238EE65F41\n\tfor ;\n\tMon, 29 Jun 2026 18:30:25 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 023C98D4\n\tfor ;\n\tMon, 29 Jun 2026 18:29:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N9O2Ndy5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750582;\n\tbh=CsaT+i0oyShur8yb1g7Oy/M68CtcBChxeQYfFmNsOX8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=N9O2Ndy5uTU/9/ozwkOVFIMKlrCqm9lY+iTdnGCvOYxd12erMcZf8yhPrlD0iA2Re\n\tGGTe3BB+lpdhMCaI3Let+hTa8P0IsSBK0XMIB4+fL5pGQBg/dqS2YECFNisWxnIe/1\n\t4kdRfxntDneaetVGAsCUuuFRvtGU5R2UNQAsOBvc=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 18/54] libcamera: request: Remove `ReuseBuffers`","Date":"Mon, 29 Jun 2026 18:29:41 +0200","Message-ID":"<20260629163017.863145-19-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Remove the implementation of the `ReuseBuffers` flag. With the split\nof requests and buffers, it is no longer that useful, and having it\nwork in any reasonable capacity requires more compatibility code.\n\nFor now only the implementation is removed.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/request.cpp | 13 ++++---------\n 1 file changed, 4 insertions(+), 9 deletions(-)","diff":"diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 022a97f169..b1a81e36ef 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -390,17 +390,12 @@ void Request::reuse(ReuseFlag flags)\n {\n \tLIBCAMERA_TRACEPOINT(request_reuse, this);\n \n-\t_d()->reset();\n+\tif (flags)\n+\t\tLOG(Request, Fatal) << \"NOT IMPLEMENTED\";\n \n-\tif (flags & ReuseBuffers) {\n-\t\tfor (const auto &[stream, buffer] : bufferMap_) {\n-\t\t\tbuffer->_d()->setRequest(this);\n-\t\t\t_d()->pending_.insert(buffer);\n-\t\t}\n-\t} else {\n-\t\tbufferMap_.clear();\n-\t}\n+\t_d()->reset();\n \n+\tbufferMap_.clear();\n \tstatus_ = RequestPending;\n \n \tcontrols_.clear();\n","prefixes":["RFC","v1","18/54"]}