{"id":27092,"url":"https://patchwork.libcamera.org/api/patches/27092/?format=json","web_url":"https://patchwork.libcamera.org/patch/27092/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-15-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:37","name":"[RFC,v1,14/54] v4l2: v4l2_camera: Always clear pending requests","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6b5bc3083fb0456cab9aa2ce4bb9796b910e6c8e","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27092/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27092/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27092/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4360DC3261\n\tfor ;\n\tMon, 29 Jun 2026 16:30:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AD3B65F43;\n\tMon, 29 Jun 2026 18:30:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DE7F65F3C\n\tfor ;\n\tMon, 29 Jun 2026 18:30:24 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E54C2E91;\n\tMon, 29 Jun 2026 18:29:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r4xXrRYc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750581;\n\tbh=/I+305mhXmeCxdVs2UFxxx9WQBByNicLPjGO++BMevY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r4xXrRYcSasJuXzXkGjIXiF9RO2r7AWHCqNQC3owlPBhmKhImboLMJosyxUkCNMsX\n\tGmCjALX/uWq7Tpdp5mPpKrwW22pKcr8LwnHKJl/bBRix3VqngczG6BlKwATUs//A8q\n\t5SMb8iAC6Pl/cut4piARHj4sguTHlN7Ag/00cvP4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tLaurent Pinchart ,\n\tPaul Elder ","Subject":"[RFC PATCH v1 14/54] v4l2: v4l2_camera: Always clear pending\n\trequests","Date":"Mon, 29 Jun 2026 18:29:37 +0200","Message-ID":"<20260629163017.863145-15-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Clear the list of pending requests regardless whether the camera is running\nor not. The list should only contain entries when `!isRunning_`, in which\ncase it was not cleared previously.\n\nConsider the following scenario:\n\n * STREAMOFF\n * QBUF(10)\n * STREAMOFF\n // at this point buffer 10 should be dequeued;\n // but `pendingRequests_` would still have the request\n // that was added due to QBUF\n * QBUF(10)\n // `pendingRequests_` would have the same requests twice\n * STREAMON\n // the same request would be tried to be queued twice\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \n---\n src/v4l2/v4l2_camera.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex e72b73a22a..8c7de8e92b 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -226,6 +226,8 @@ int V4L2Camera::streamOn()\n \n int V4L2Camera::streamOff()\n {\n+\tpendingRequests_.clear();\n+\n \tif (!isRunning_) {\n \t\tfor (std::unique_ptr &req : requestPool_)\n \t\t\treq->reuse();\n@@ -233,8 +235,6 @@ int V4L2Camera::streamOff()\n \t\treturn 0;\n \t}\n \n-\tpendingRequests_.clear();\n-\n \tint ret = camera_->stop();\n \tif (ret < 0)\n \t\treturn ret == -EACCES ? -EBUSY : ret;\n","prefixes":["RFC","v1","14/54"]}