{"id":27090,"url":"https://patchwork.libcamera.org/api/patches/27090/?format=json","web_url":"https://patchwork.libcamera.org/patch/27090/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-12-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:34","name":"[RFC,v1,11/54] v4l2: v4l2_camera: Use actually allocated buffer count","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3e6bb25ad537ab12322c1ae25783e00f52a46a92","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27090/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27090/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27090/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CCEDC3261\n\tfor ;\n\tMon, 29 Jun 2026 16:30:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C58DC65F84;\n\tMon, 29 Jun 2026 18:30:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DEE565F37\n\tfor ;\n\tMon, 29 Jun 2026 18:30:23 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21EAE8D4;\n\tMon, 29 Jun 2026 18:29:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cW4UpPIC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750580;\n\tbh=r3Ov2KlKaxR7pacYvNpNxeN12yMks/mdafjXn3FC/mA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cW4UpPICUqDu943Gtm5G3j3kBQq3agO7JQIumTWAFcgGeHP4GyGhMVQFXxLLHANx/\n\toh53JX9IJQNsSei7Kk95EJCBs48dfRYpGy37QcCd+Ml+RcAxVh0UaBx1pJHByQUg0c\n\tMSHoTNSaOc03VnxmIC4C9kYSxhbHbVr+7/ewjsX8=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[RFC PATCH v1 11/54] v4l2: v4l2_camera: Use actually allocated\n\tbuffer count","Date":"Mon, 29 Jun 2026 18:29:34 +0200","Message-ID":"<20260629163017.863145-12-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make `V4L2Camera::allocBuffers()` simply create as many requests as the\nnumber of buffers allocated instead of taking it as an argument. The two\nshould be the same, so no functional changes intended.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \n---\n src/v4l2/v4l2_camera.cpp | 8 +++++---\n src/v4l2/v4l2_camera.h | 2 +-\n src/v4l2/v4l2_camera_proxy.cpp | 10 +++++-----\n 3 files changed, 11 insertions(+), 9 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 648578c22b..75428b8adc 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -154,7 +154,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n \treturn 0;\n }\n \n-int V4L2Camera::allocBuffers(unsigned int count)\n+int V4L2Camera::allocBuffers()\n {\n \tStream *stream = config_->at(0).stream();\n \n@@ -162,7 +162,9 @@ int V4L2Camera::allocBuffers(unsigned int count)\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tfor (unsigned int i = 0; i < count; i++) {\n+\tconst auto &buffers = bufferAllocator_->buffers(stream);\n+\n+\tfor (size_t i = 0; i < buffers.size(); i++) {\n \t\tstd::unique_ptr request = camera_->createRequest(i);\n \t\tif (!request) {\n \t\t\trequestPool_.clear();\n@@ -171,7 +173,7 @@ int V4L2Camera::allocBuffers(unsigned int count)\n \t\trequestPool_.push_back(std::move(request));\n \t}\n \n-\treturn ret;\n+\treturn buffers.size();\n }\n \n void V4L2Camera::freeBuffers()\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 1528f9aad8..8a58169d89 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -54,7 +54,7 @@ public:\n \tlibcamera::ControlList &controls() { return controls_; }\n \tconst libcamera::ControlInfoMap &controlInfo() { return camera_->controls(); }\n \n-\tint allocBuffers(unsigned int count);\n+\tint allocBuffers();\n \tvoid freeBuffers();\n \tint getBufferFd(unsigned int index);\n \ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 94c0006cf3..ee44767bd3 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -542,16 +542,16 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n \tif (ret < 0)\n \t\treturn -EINVAL;\n \n-\tsetFmtFromConfig(streamConfig_);\n-\n-\targ->count = streamConfig_.bufferCount;\n-\n-\tret = vcam_->allocBuffers(arg->count);\n+\tret = vcam_->allocBuffers();\n \tif (ret < 0) {\n \t\targ->count = 0;\n \t\treturn ret;\n \t}\n \n+\targ->count = ret;\n+\n+\tsetFmtFromConfig(streamConfig_);\n+\n \tbuffers_.resize(arg->count);\n \tfor (unsigned int i = 0; i < arg->count; i++) {\n \t\tstruct v4l2_buffer buf = {};\n","prefixes":["RFC","v1","11/54"]}