[{"id":3549,"web_url":"https://patchwork.libcamera.org/comment/3549/","msgid":"<20200120165651.GJ20122@pendragon.ideasonboard.com>","date":"2020-01-20T16:56:51","subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline_handler: Include system\n\theader for dev_t","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Jan 20, 2020 at 12:55:42PM +0000, Kieran Bingham wrote:\n> Compiling with gcc 9.2.0-r5 identifies the following compile time\n> failure:\n> \n> FAILED: src/libcamera/4ab8042@@camera@sha/camera.cpp.o\n> c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -c ../src/libcamera/camera.cpp\n> In file included from ../src/libcamera/camera.cpp:17:\n> ../src/libcamera/include/pipeline_handler.h:91:42: error: 'dev_t' has not been declared\n> 91 | std::unique_ptr data, dev_t devnum = 0);\n> | ^~~~~\n> \n> Provide the required header to define the dev_t type.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/include/pipeline_handler.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index a6c1e1fbae38..5fa0db51c625 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> \n> #include ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9D2960455\n\tfor ;\n\tMon, 20 Jan 2020 17:56:52 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AAC4A62;\n\tMon, 20 Jan 2020 17:56:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579539412;\n\tbh=G+Z4wQ4w3XT1hpnfDLkUsMEP8azUEMqKrtLMD7sEoQA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sm0zbkaQF2vuE+ZblMU3JlmXT8IUGjhF/e7epUJTXAE5nsoeFdMgqqXRhClngEnQ1\n\tghhtSpteEm0PG/BhoI+lcSc8QOz0HKtZlPigVYBLD3C3cw5G4cjPlDzgz4BOV9snHc\n\t4VCsM88sKorOesBWRbH0M8BKmjxoc8U0KTzPQObk=","Date":"Mon, 20 Jan 2020 18:56:51 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200120165651.GJ20122@pendragon.ideasonboard.com>","References":"<20200120125544.12562-1-kieran.bingham@ideasonboard.com>\n\t<20200120125544.12562-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200120125544.12562-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline_handler: Include system\n\theader for dev_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 20 Jan 2020 16:56:53 -0000"}}]