{"id":2709,"url":"https://patchwork.libcamera.org/api/patches/2709/?format=json","web_url":"https://patchwork.libcamera.org/patch/2709/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200120125544.12562-2-kieran.bingham@ideasonboard.com>","date":"2020-01-20T12:55:42","name":"[libcamera-devel,1/3] pipeline_handler: Include system header for dev_t","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8d13025d054a261bcbb5b73215f2d363faac835d","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/2709/mbox/","series":[{"id":643,"url":"https://patchwork.libcamera.org/api/series/643/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=643","date":"2020-01-20T12:55:41","name":"CI: Initial gitlab ci builder","version":1,"mbox":"https://patchwork.libcamera.org/series/643/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2709/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2709/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFD6360804\n\tfor ;\n\tMon, 20 Jan 2020 13:55:48 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57D0910D6;\n\tMon, 20 Jan 2020 13:55:48 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579524948;\n\tbh=zurCK2/8QqqZHV2dg76g26XT0x/0Pfn52tplk5NyCnc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZIsm69nzM8tiQ3OW5tNXFgUBZs/g2ugIX/F4g0VCmMG0vLX66Ti1yVCrRfEWcAUQ6\n\tkvZ0tpY/PopMm4kjok4jxqkKWUSu8+xUIrcYKRI0LexyjsE+n8Qd7CUp/a3O9vRw3D\n\tezX6Mfia76FsXXiLqS/SuLQMoHwARaWs7264C8TY=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Mon, 20 Jan 2020 12:55:42 +0000","Message-Id":"<20200120125544.12562-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20200120125544.12562-1-kieran.bingham@ideasonboard.com>","References":"<20200120125544.12562-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/3] pipeline_handler: Include system\n\theader for dev_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 20 Jan 2020 12:55:49 -0000"},"content":"Compiling with gcc 9.2.0-r5 identifies the following compile time\nfailure:\n\nFAILED: src/libcamera/4ab8042@@camera@sha/camera.cpp.o\nc++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -c ../src/libcamera/camera.cpp\nIn file included from ../src/libcamera/camera.cpp:17:\n../src/libcamera/include/pipeline_handler.h:91:42: error: 'dev_t' has not been declared\n 91 | std::unique_ptr data, dev_t devnum = 0);\n | ^~~~~\n\nProvide the required header to define the dev_t type.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/include/pipeline_handler.h | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex a6c1e1fbae38..5fa0db51c625 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -13,6 +13,7 @@\n #include \n #include \n #include \n+#include \n #include \n \n #include \n","prefixes":["libcamera-devel","1/3"]}