{"id":27086,"url":"https://patchwork.libcamera.org/api/patches/27086/?format=json","web_url":"https://patchwork.libcamera.org/patch/27086/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260629163017.863145-8-barnabas.pocze@ideasonboard.com>","date":"2026-06-29T16:29:30","name":"[RFC,v1,07/54] libcamera: pipeline_handler: completeBuffer(): Inline and `static`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5ac935592f132e7473c954913e7c02b05d91a94f","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27086/mbox/","series":[{"id":6025,"url":"https://patchwork.libcamera.org/api/series/6025/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6025","date":"2026-06-29T16:29:23","name":"libcamera: Split requests and buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/6025/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27086/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27086/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E188C3261\n\tfor ;\n\tMon, 29 Jun 2026 16:30:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 500C465F78;\n\tMon, 29 Jun 2026 18:30:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5288565F28\n\tfor ;\n\tMon, 29 Jun 2026 18:30:22 +0200 (CEST)","from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A2208D4;\n\tMon, 29 Jun 2026 18:29:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O8z1NAW7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750579;\n\tbh=EeN+aVQ+3EoPK+5UpjBSjnEyhSEN3Q0wcc7VEyo3LaU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=O8z1NAW7BvdRYKeIugp7nEIiqoli4thIwJItHl2ZY7j17ysNRo0VmQ5Q8ECVeM5iY\n\tLKcVND4K5jOs84SPKbNhYWkCgF3kWCDR7/hnMIS1efTbI4yk1BSV1NVbzvgBIL8Xfa\n\tiJMMq1ZjBfLGimSIAYWCilzT0j5AFBbwPlBP4pV8=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ","Subject":"[RFC PATCH v1 07/54] libcamera: pipeline_handler: completeBuffer():\n\tInline and `static`","Date":"Mon, 29 Jun 2026 18:29:30 +0200","Message-ID":"<20260629163017.863145-8-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","References":"<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The function now only calls a method in `Request::Private`, so inline\nit, and also make it `static` since it needs no access to the pipeline\nhandler members.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/pipeline_handler.h | 7 ++++++-\n src/libcamera/pipeline_handler.cpp | 5 +----\n 2 files changed, 7 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 6922ce18ec..cc52c6b045 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -19,6 +19,7 @@\n \n #include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n+#include \"libcamera/internal/request.h\"\n \n namespace libcamera {\n \n@@ -60,7 +61,11 @@ public:\n \tvoid registerRequest(Request *request);\n \tvoid queueRequest(Request *request);\n \n-\tbool completeBuffer(Request *request, FrameBuffer *buffer);\n+\tstatic bool completeBuffer(Request *request, FrameBuffer *buffer)\n+\t{\n+\t\treturn request->_d()->completeBuffer(buffer);\n+\t}\n+\n \tvoid completeRequest(Request *request);\n \tvoid cancelRequest(Request *request);\n \ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 3d49f85cfa..99f35d1e42 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -544,6 +544,7 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n */\n \n /**\n+ * \\fn PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n * \\brief Complete a buffer for a request\n * \\param[in] request The request the buffer belongs to\n * \\param[in] buffer The buffer that has completed\n@@ -560,10 +561,6 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n * \\return True if all buffers contained in the request have completed, false\n * otherwise\n */\n-bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n-{\n-\treturn request->_d()->completeBuffer(buffer);\n-}\n \n /**\n * \\brief Signal request completion\n","prefixes":["RFC","v1","07/54"]}