{"id":27070,"url":"https://patchwork.libcamera.org/api/patches/27070/?format=json","web_url":"https://patchwork.libcamera.org/patch/27070/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260626-ipu3-libipa-rework-v2-10-41546e23de3e@ideasonboard.com>","date":"2026-06-26T13:05:57","name":"[v2,10/12] ipa: ipu3: Don't pass sensorInfo to updateControls()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"960fc3cbe9453d3ddd50e4692bf654931297cd6c","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27070/mbox/","series":[{"id":6022,"url":"https://patchwork.libcamera.org/api/series/6022/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6022","date":"2026-06-26T13:05:47","name":"libipa: Re-work IPU3 IPA to use libipa algorithms","version":2,"mbox":"https://patchwork.libcamera.org/series/6022/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27070/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27070/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66926C3301\n\tfor ;\n\tFri, 26 Jun 2026 13:06:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E3EC65F02;\n\tFri, 26 Jun 2026 15:06:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9975265EF7\n\tfor ;\n\tFri, 26 Jun 2026 15:06:07 +0200 (CEST)","from [127.0.1.1]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9CB71CEF;\n\tFri, 26 Jun 2026 15:05:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z03J81rj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782479126;\n\tbh=KI5tgliKnQMEXyv5fryXUaUERQlQN30zJEGI22nu0SQ=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Z03J81rjHO2kuoBVHEnj3aNwHEKLtS+QnIVFFPiLEk/Hj8D00SAvCSjFqy1nB3uGZ\n\tM91jfZYGjfiRQhgttT9uk+53b/3jNd5PK8SLWgLkmqZ4/QOdr1y3GboWumjso7qJG6\n\t+/EJRqTUdbNWH/mx7AGMo39Uu5xVzLosykVVfppY=","From":"Daniel Scally ","Date":"Fri, 26 Jun 2026 14:05:57 +0100","Subject":"[PATCH v2 10/12] ipa: ipu3: Don't pass sensorInfo to\n\tupdateControls()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260626-ipu3-libipa-rework-v2-10-41546e23de3e@ideasonboard.com>","References":"<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>","In-Reply-To":"<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3929;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=KI5tgliKnQMEXyv5fryXUaUERQlQN30zJEGI22nu0SQ=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqPnk7kzJc6th1kwMjuPdUCnn3MiDgwrCNKggQv\n\to0LDHeT1+WJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaj55OwAKCRDISVd6bEV1\n\tMixFD/4i+UbBsREcZXnseX5XOr6fgvEtbQ+Nfka93xeW+wx5yRg/ZrfcOrr7HxmlJb5PKh23AAt\n\tPk9FDOvjmNK/qFYaIQp7ZuW/92HEzWxiuHYVk1WeTdtq+T+HJxiGXZ7BMzt0OrlW4oxmdK76322\n\tYxylzLP1CiErzwarF52MoIpzymcI+/GdXPLh8Oj+kjOQG3EeO4/xGvinQIHdeMs8TeMR9rAuzaq\n\tr6iRk9EMB/4lEtHlzY840OEPPkNTNDdGx+5mslovq8zEoCAwq3VJpI6oPwVoVnaI9vMbJ35h/K+\n\tiSmgSbOhtk5PnK7WLiseOoO9xqa1u3X8bW10TzcmT9JrbWW5yrF4rUDTU4QOvwKAfCG0Au3JieW\n\tZcuH6tEuqQ/oZMrHUmlursnmeccj45X5FMlETKhRsoIWscbgC97T+WKpaCOPDBc5sZAREQPoBXa\n\tsmQVv/Le0411pUw1ielxeoYveQaCBU2qza48p5eVgKDowMT/Ak0/Qq/HrdBuwqsw46NnYrdO8XE\n\tA9SyxdeBV1p4gkssPxoVlxGm0NOI5/W01vnrUJB4Hr4xe6QZnabpLd6YlPD/WNx8+RgbRSvCQoY\n\txiGnvODfZclddtvdXdpXoCw4XkksFNj9yB7FUqpg7w02NYK8jaEzuYURbKm7ci2wHRnE5Tbw4YY\n\tWS7G1S6eLV+3glA==","X-Developer-Key":"i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The updateControls() function uses the configured output size of the\nsensor to set the ranges for vertical blanking and frame duration\ncontrols. We currently pass sensorInfo as a parameter, but it's also\nstored as a member of class IPAIPU3 and so doesn't need to be passed\nto updateControls at all().\n\nDrop the parameter and just use the class member instead.\n\nSigned-off-by: Daniel Scally \n---\nChanges in v2:\n\n - New patch\n---\n src/ipa/ipu3/ipu3.cpp | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 4bdc4b7677fe9703fb968ca91967c68742454514..b1c176e68098b24d8fd37e7a0e278cabf0e1c3b2 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -165,8 +165,7 @@ protected:\n \tstd::string logPrefix() const override;\n \n private:\n-\tvoid updateControls(const IPACameraSensorInfo &sensorInfo,\n-\t\t\t const ControlInfoMap &sensorControls,\n+\tvoid updateControls(const ControlInfoMap &sensorControls,\n \t\t\t ControlInfoMap *ipaControls);\n \tvoid updateSessionConfiguration(const ControlInfoMap &sensorControls);\n \n@@ -239,8 +238,7 @@ void IPAIPU3::updateSessionConfiguration(const ControlInfoMap &sensorControls)\n * - controls::ExposureTime\n * - controls::FrameDurationLimits\n */\n-void IPAIPU3::updateControls(const IPACameraSensorInfo &sensorInfo,\n-\t\t\t const ControlInfoMap &sensorControls,\n+void IPAIPU3::updateControls(const ControlInfoMap &sensorControls,\n \t\t\t ControlInfoMap *ipaControls)\n {\n \tControlInfoMap::Map controls{};\n@@ -267,19 +265,19 @@ void IPAIPU3::updateControls(const IPACameraSensorInfo &sensorInfo,\n \t */\n \tconst ControlInfo &v4l2HBlank = sensorControls.find(V4L2_CID_HBLANK)->second;\n \tuint32_t hblank = v4l2HBlank.def().get();\n-\tuint32_t lineLength = sensorInfo.outputSize.width + hblank;\n+\tuint32_t lineLength = sensorInfo_.outputSize.width + hblank;\n \n \tconst ControlInfo &v4l2VBlank = sensorControls.find(V4L2_CID_VBLANK)->second;\n \tstd::array frameHeights{\n-\t\tv4l2VBlank.min().get() + sensorInfo.outputSize.height,\n-\t\tv4l2VBlank.max().get() + sensorInfo.outputSize.height,\n-\t\tv4l2VBlank.def().get() + sensorInfo.outputSize.height,\n+\t\tv4l2VBlank.min().get() + sensorInfo_.outputSize.height,\n+\t\tv4l2VBlank.max().get() + sensorInfo_.outputSize.height,\n+\t\tv4l2VBlank.def().get() + sensorInfo_.outputSize.height,\n \t};\n \n \tstd::array frameDurations;\n \tfor (unsigned int i = 0; i < frameHeights.size(); ++i) {\n \t\tuint64_t frameSize = lineLength * frameHeights[i];\n-\t\tframeDurations[i] = frameSize / (sensorInfo.pixelRate / 1000000U);\n+\t\tframeDurations[i] = frameSize / (sensorInfo_.pixelRate / 1000000U);\n \t}\n \tcontrols[&controls::FrameDurationLimits] = ControlInfo(frameDurations[0],\n \t\t\t\t\t\t\t frameDurations[1],\n@@ -313,6 +311,7 @@ int IPAIPU3::init(const IPASettings &settings,\n \tcontext_.configuration = {};\n \tcontext_.configuration.sensor.lineDuration =\n \t\tsensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n+\tsensorInfo_ = sensorInfo;\n \n \t/* Load the tuning data file. */\n \tFile file(settings.configurationFile);\n@@ -346,7 +345,7 @@ int IPAIPU3::init(const IPASettings &settings,\n \t\treturn ret;\n \n \t/* Initialize controls. */\n-\tupdateControls(sensorInfo, sensorControls, ipaControls);\n+\tupdateControls(sensorControls, ipaControls);\n \n \treturn 0;\n }\n@@ -488,7 +487,7 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \tcalculateBdsGrid(configInfo.bdsOutputSize);\n \n \t/* Update the camera controls using the new sensor settings. */\n-\tupdateControls(sensorInfo_, sensorCtrls_, ipaControls);\n+\tupdateControls(sensorCtrls_, ipaControls);\n \n \t/* Update the IPASessionConfiguration using the sensor settings. */\n \tupdateSessionConfiguration(sensorCtrls_);\n","prefixes":["v2","10/12"]}