[{"id":39456,"web_url":"https://patchwork.libcamera.org/comment/39456/","msgid":"<20260626120757.GJ2258794@killaraus.ideasonboard.com>","date":"2026-06-26T12:07:57","subject":"Re: [PATCH 2/3] include: linux: videodev2: Add NV12MT_COL128\n\t8/10-bit pixel formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Jun 26, 2026 at 12:54:02PM +0100, Naushir Patuck wrote:\n> Add the V4L2_PIX_FMT_NV12MT_COL128 and V4L2_PIX_FMT_NV12MT_10_COL128\n> 4CCs. These formats are available from the PiSP Backend hardware.\n\nWhat's the status of upstreaming those formats ? I see them being added\nby the HEVC decoder patch series, but I don't see support for them being\nadded to the PiSP backend driver.\n\n> Signed-off-by: Naushir Patuck \n> ---\n> include/linux/videodev2.h | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index 8bccad84ff83..0c6c4c6831d9 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -670,6 +670,9 @@ struct v4l2_pix_format {\n> #define V4L2_PIX_FMT_NV12MT_16X16 v4l2_fourcc('V', 'M', '1', '2') /* 12 Y/CbCr 4:2:0 16x16 tiles */\n> #define V4L2_PIX_FMT_NV12M_8L128 v4l2_fourcc('N', 'A', '1', '2') /* Y/CbCr 4:2:0 8x128 tiles */\n> #define V4L2_PIX_FMT_NV12M_10BE_8L128 v4l2_fourcc_be('N', 'T', '1', '2') /* Y/CbCr 4:2:0 10-bit 8x128 tiles */\n> +#define V4L2_PIX_FMT_NV12MT_COL128 v4l2_fourcc('N', 'c', '1', '2') /* 12 Y/CbCr 4:2:0 128 pixel wide column */\n> +#define V4L2_PIX_FMT_NV12MT_10_COL128 v4l2_fourcc('N', 'c', '3', '0')\n> +\t\t\t/* Y/CbCr 4:2:0 10bpc, 3x10 packed as 4 bytes in a 128 bytes / 96 pixel wide column */\n> \n> /* Bayer formats - see http://www.siliconimaging.com/RGB%20Bayer.htm */\n> #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 BGBG.. GRGR.. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00031C3264\n\tfor ;\n\tFri, 26 Jun 2026 12:08:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 206FD6590C;\n\tFri, 26 Jun 2026 14:08:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F42F658FA\n\tfor ;\n\tFri, 26 Jun 2026 14:07:58 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 941E6174;\n\tFri, 26 Jun 2026 14:07:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rthEpfR0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782475637;\n\tbh=nu35wr8cpOixfLKsVTOO2fe8BYEpFbpOmu7y2GODRBY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rthEpfR0yAQL8KWoan3IR+9igxAHBZdK/UDLdReSXtpX7n5VHLc5A3aNK4Pwwvhtu\n\teIVaW+I/7PYivyzdA83p3rMTN55t5lV4s/kI34gUviqiFp08y3MuiA4nRogJUiQ9l0\n\t1jckpWOB0WSPDS3XGtzef45VBzemI1fXpgzfXBHo=","Date":"Fri, 26 Jun 2026 15:07:57 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/3] include: linux: videodev2: Add NV12MT_COL128\n\t8/10-bit pixel formats","Message-ID":"<20260626120757.GJ2258794@killaraus.ideasonboard.com>","References":"<20260626120041.627376-1-naush@raspberrypi.com>\n\t<20260626120041.627376-3-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260626120041.627376-3-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39458,"web_url":"https://patchwork.libcamera.org/comment/39458/","msgid":"","date":"2026-06-26T12:12:06","subject":"Re: [PATCH 2/3] include: linux: videodev2: Add NV12MT_COL128\n\t8/10-bit pixel formats","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Adding Dave S.\n\nOn Fri, 26 Jun 2026 at 13:07, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Fri, Jun 26, 2026 at 12:54:02PM +0100, Naushir Patuck wrote:\n> > Add the V4L2_PIX_FMT_NV12MT_COL128 and V4L2_PIX_FMT_NV12MT_10_COL128\n> > 4CCs. These formats are available from the PiSP Backend hardware.\n>\n> What's the status of upstreaming those formats ? I see them being added\n> by the HEVC decoder patch series, but I don't see support for them being\n> added to the PiSP backend driver.\n\n\nOh, good point. I thought Dave might have sent the patch for that as\nwell, but it's only downstream right now. We will push the pisp\ndriver upstream as well.\n\nNaush\n\n\n\n>\n>\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > include/linux/videodev2.h | 3 +++\n> > 1 file changed, 3 insertions(+)\n> >\n> > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> > index 8bccad84ff83..0c6c4c6831d9 100644\n> > --- a/include/linux/videodev2.h\n> > +++ b/include/linux/videodev2.h\n> > @@ -670,6 +670,9 @@ struct v4l2_pix_format {\n> > #define V4L2_PIX_FMT_NV12MT_16X16 v4l2_fourcc('V', 'M', '1', '2') /* 12 Y/CbCr 4:2:0 16x16 tiles */\n> > #define V4L2_PIX_FMT_NV12M_8L128 v4l2_fourcc('N', 'A', '1', '2') /* Y/CbCr 4:2:0 8x128 tiles */\n> > #define V4L2_PIX_FMT_NV12M_10BE_8L128 v4l2_fourcc_be('N', 'T', '1', '2') /* Y/CbCr 4:2:0 10-bit 8x128 tiles */\n> > +#define V4L2_PIX_FMT_NV12MT_COL128 v4l2_fourcc('N', 'c', '1', '2') /* 12 Y/CbCr 4:2:0 128 pixel wide column */\n> > +#define V4L2_PIX_FMT_NV12MT_10_COL128 v4l2_fourcc('N', 'c', '3', '0')\n> > + /* Y/CbCr 4:2:0 10bpc, 3x10 packed as 4 bytes in a 128 bytes / 96 pixel wide column */\n> >\n> > /* Bayer formats - see http://www.siliconimaging.com/RGB%20Bayer.htm */\n> > #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 BGBG.. GRGR.. */\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12500BF415\n\tfor ;\n\tFri, 26 Jun 2026 12:12:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2777665EE0;\n\tFri, 26 Jun 2026 14:12:45 +0200 (CEST)","from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com\n\t[IPv6:2607:f8b0:4864:20::e2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 086CE658FC\n\tfor ;\n\tFri, 26 Jun 2026 14:12:43 +0200 (CEST)","by mail-vs1-xe2c.google.com with SMTP id\n\tada2fe7eead31-735acdad080so34399137.0\n\tfor ;\n\tFri, 26 Jun 2026 05:12:42 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"GHwX97tK\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1782475962; cv=none;\n\td=google.com; s=arc-20260327;\n\tb=qVoV7pmjJRBY7/fSLes7Pd/MtR/YB9VhizS5zN/fRkc4eeE7ITPA1GPHRJHkaAJtu6\n\tLPmUbKa5tImQ1DEt7fJce5L00N8uDXDkVuch1JY6kR9VLlg/+Cp31bNLXYMLnHRV+frb\n\tAZmotMUHHymz/deVI+a9zq7jHfg9ZRDYbl+9s8/kfS0i7j2QzvptILMUjM76assIfBXT\n\tu8U7ooNGdI6cHEyi9wytZIf2wD9a9jyyXzl0Ra1qUDPcSho+Stj8M8eA5iplL8XvZOJv\n\teqJ6v1djK9kGaUdE3ScoeXaRKYCGkCUFLJ9fgr/J9Cs7NOrscQGTjFDCQ6qzSEo/OQlN\n\tziEQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20260327; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=x/3gzKpK3B5sTYMfU7ua5Z2LQurR6VZyrLfu68lCSMI=;\n\tfh=Y1PvN8pz5GIXj1cTtiwSfsrOmNq68F+VZVYH9h5RySU=;\n\tb=h6KWndYHDrXU8ZbMT8qIukMExTVNBA0ZGYlcOE9nn4ngRMoaj3IB2TpQkGP1/4gHUo\n\tALBGQGEvjWrGLMpwRs9137YkCag3U5iSBHtKK7+JCF+oSyVa3mP9PoIidtxOPKZsVSs0\n\toFfoJF/g8wf1AE5NAsmC/l/HOiocKJup60cc3/st6cV5Wdgh2vArTFCApgl3nkExlg4n\n\tIqxzvi4n/zuMb7V5n/7B/daQUIQ+flYd2riK4eAhr8su+nk4qf4NDwYwMF5RT4+4uxau\n\t4y73F9mbCt1An/rZnWS9TymIE51/CGIWVruk8F7j6m2VaTKWVH5H3vVuEyxZpZrw3VGI\n\tqq1Q==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1782475962; x=1783080762;\n\tdarn=lists.libcamera.org; \n\th=content-type:cc:to:subject:message-id:date:from:in-reply-to\n\t:references:mime-version:from:to:cc:subject:date:message-id:reply-to\n\t:content-type; bh=x/3gzKpK3B5sTYMfU7ua5Z2LQurR6VZyrLfu68lCSMI=;\n\tb=GHwX97tK06E5/Al3nmxJs3e9LJZ7kyP4AZZMI1Y5mJCzDax/o77uxDjq3bfWOn/pNT\n\t1Pk+X23meix0lA0V0t7aUKPNStQlJ4aaG3A9dVw1nxpUTSKNd/nivyhkk8CDAp6aiHWE\n\t2apThEBx5b++xj+PXHBgJWMN89CyhM1kdWZ0NekgYzD8mzfP5TeELGHYgv8kWD9Dov7V\n\tobyKqYDAuvvDGrI5K18l6NKllEfdBeN4sE0KJ067zdTAX6y4S/A4luvV2kIm6ZGJf96I\n\thPCbnnjKNBLv3je3weDxM8L2zZtwgXoXIfDkwOwWX3NagDpXuNvrm536MSfjvaQGhvjn\n\tDaBw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782475962; x=1783080762;\n\th=content-type:cc:to:subject:message-id:date:from:in-reply-to\n\t:references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to:content-type;\n\tbh=x/3gzKpK3B5sTYMfU7ua5Z2LQurR6VZyrLfu68lCSMI=;\n\tb=B1yKQjRhPnkC+uESFpjmgqAeYA6he42jWOHhS316DeWAXNuqQBt6s7LfBxK2t6FwPq\n\tsFAez1ow1vIZRIUYDs3ijlk1PY/as4wmeFH4CKWnGPlLqeLJTS8CBEEW+lrDgOSq+GDD\n\t2nvRNSIResXrMBTz9vKVMsn0JZdzguKW9oxXbee1ail1JsnDV5TYX/qwT1HXMVnLp6+z\n\tjZq8naleP3xYafhhHJUTIi3qbwBEIkNN+sjIgDXc5Hv+FAcMrVk4yd1WIYtnv/eZCFwa\n\te3xEcqhcOnWVscsshWw6Ud3s/td/lcWoRLPisAKDsmc+377o4OXLzAcaImOo5hnKmmq0\n\tz9cw==","X-Gm-Message-State":"AOJu0YxHSW36uwYdKJ7SVtCwrpb3i9M2WvYpaeoNhIxP/AmZ3IpHPNEc\n\t4qgCQ55DonKg2C6c6g13LkDFhccCJvZ8kBNvaZuxLDFf+4CnY2lXC4SLNbgRsRnDCbKQJvnZJ8I\n\tC8U8/+Q3F1c8rRP1gKZ3EMikK3sdZFhqITrRooyX7iCfG9vWIIF3+Nvg=","X-Gm-Gg":"AfdE7cnx2+ecTkbidlkYQlTWpv3JlwDd0QFrhQXGBf+Na700+Kp1fYnA2s91FBcWmWI\n\ta+WYadC1bBvPPertXnHQYHXO1ZPn+MyQmFLXc8CrpKi3Mr3Mi0uNtjGEqNgBsfCFhDFBtGxahaD\n\tBDB7eM8Qap6wHfYko4j6Ae6yCU4+sJ3O5niXtMbbBkZjW6UlAB3pFQnfjNvwvU6oEsUoF3cdag2\n\tqIBzzOuc0oxT6f+mVezcp0TWbYi3O3HwP+yoHrJSswynwqAWEJkvjA1zOK6qouSJ7XT5D7quup3\n\tzVUVAybN5SOCImbBmDI/4aGQvHYkZbLtaY7wZGgP8e0PYZj38ZhHVV5ilg3ALXZ6LOvNKAeKjrX\n\tC8VHVmba/XLCWvBsNxsSHanJudMqFGVeQKOHXFpkMxrdDcp967CCueer33p26L+bVGNW5TiTaaL\n\t24rPSI9/LcHSsV","X-Received":"by 2002:a05:6102:3749:b0:726:e608:6651 with SMTP id\n\tada2fe7eead31-73433e32f8dmr1086919137.2.1782475961732;\n\tFri, 26 Jun 2026 05:12:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20260626120041.627376-1-naush@raspberrypi.com>\n\t<20260626120041.627376-3-naush@raspberrypi.com>\n\t<20260626120757.GJ2258794@killaraus.ideasonboard.com>","In-Reply-To":"<20260626120757.GJ2258794@killaraus.ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 26 Jun 2026 13:12:06 +0100","X-Gm-Features":"AVVi8CdOmFEbGgceBymx2bp1Iha3Y8PlrSyXiQXprCrlsHS8IlqFIr0s2oQNyI8","Message-ID":"","Subject":"Re: [PATCH 2/3] include: linux: videodev2: Add NV12MT_COL128\n\t8/10-bit pixel formats","To":"Laurent Pinchart , \n\tDave Stevenson ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]