[{"id":39454,"web_url":"https://patchwork.libcamera.org/comment/39454/","msgid":"<513961a9-28c5-4088-b940-7571b7387323@collabora.com>","date":"2026-06-26T12:03:05","subject":"Re: [PATCH v3 2/8] libcamera: software_isp: debayer_egl: Flag dmabuf\n\tuse once per session not for every frame","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 26.06.26 13:33, Bryan O'Donoghue wrote:\n> Once we get as far a streaming if we have one dmabuf import failure, take\n> that failure as canonical and do not try further imports. Add a flag to\n> debayer_egl which gets reset on any configure() to control this logic, flip\n> the dmabuf bit on the first failure for all subsequent frames.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nI would prefer to see \"libcamera: egl: Drop dmabuf_import_failed_\" \nsquashed into this commit or at least directly follow - and rephrase the \ncommit message to something along the lines of:\n\n\"Instead of tracking dmabuf import failures in eGLImage, do so in \ndebayer_egl. This will avoid unnecessary import attempts once we start \nusing multiple eGLImages later in the series.\n\nStill:\n\nReviewed-by: Robert Mader\n\n> ---\n> src/libcamera/software_isp/debayer_egl.cpp | 13 ++++++-------\n> src/libcamera/software_isp/debayer_egl.h | 2 ++\n> 2 files changed, 8 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 14eeb9a29..53bb67c17 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -316,6 +316,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \tinputPixelFormat_ = inputCfg.pixelFormat;\n> \twidth_ = inputCfg.size.width;\n> \theight_ = inputCfg.size.height;\n> +\tuse_dmabuf_ = true;\n> \n> \tif (outputCfgs.size() != 1) {\n> \t\tLOG(Debayer, Error)\n> @@ -515,21 +516,19 @@ void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerPara\n> \n> int DebayerEGL::debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *inMapped, std::optional *inDmaSyncer)\n> {\n> -\tbool dmabuf_import_succeeded = false;\n> -\n> \t/* eGL context switch */\n> \tegl_.makeCurrent();\n> \n> \t/* Try to create texture for input buffer via dmabuf import */\n> -\tif (!eglImageBayerIn_->dmabuf_import_failed_) {\n> -\t\tif (egl_.createInputDMABufTexture2D(*eglImageBayerIn_, input->planes()[0].fd.get()) == 0)\n> -\t\t\tdmabuf_import_succeeded = true;\n> -\t\telse\n> +\tif (use_dmabuf_) {\n> +\t\tif (egl_.createInputDMABufTexture2D(*eglImageBayerIn_, input->planes()[0].fd.get()) != 0) {\n> +\t\t\tuse_dmabuf_ = false;\n> \t\t\tLOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n> +\t\t}\n> \t}\n> \n> \t/* Otherwise create texture for input buffer via upload from CPU */\n> -\tif (!dmabuf_import_succeeded) {\n> +\tif (!use_dmabuf_) {\n> \t\tinDmaSyncer->emplace(input->planes()[0].fd, DmaSyncer::SyncType::Read);\n> \t\tinMapped->emplace(input, MappedFrameBuffer::MapFlag::Read);\n> \t\tif (!inMapped->value().isValid()) {\n> diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\n> index 348d7305b..d8509e9f2 100644\n> --- a/src/libcamera/software_isp/debayer_egl.h\n> +++ b/src/libcamera/software_isp/debayer_egl.h\n> @@ -68,6 +68,8 @@ private:\n> \tvoid setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams ¶ms);\n> \tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *mappedInputBuffer, std::optional *inputBufferDmaSyncer);\n> \n> +\tbool use_dmabuf_;\n> +\n> \t/* Shader program identifiers */\n> \tGLuint vertexShaderId_ = 0;\n> \tGLuint fragmentShaderId_ = 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F134CBF415\n\tfor ;\n\tFri, 26 Jun 2026 12:03:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D71665EDA;\n\tFri, 26 Jun 2026 14:03:17 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4FAD65878\n\tfor ;\n\tFri, 26 Jun 2026 14:03:14 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1782475388124375.58135826266164; \n\tFri, 26 Jun 2026 05:03:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"dHDBgz/Y\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1782475391; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=Ad1WExnR211qL9rbAANQCT3sWz9xvqr3ntIgY9FLnyF+WJRZIn2bXuiQTvK9Sm5sV8tUV0j/QJozb7FjKPPW7/kwx21MEdximKwmnfjc5T3Vvv+XlByNx6vRRgKqPJUcEtY+zQD2SGuUBVluY0kKDpjlZ9fvOOWgP377z+roFrk=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1782475391;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=JsJ7/0OQbCdxO0lgjPO2zptj6ufyAE9huc4qEakj9V4=; \n\tb=OSoP3F5D15zVCNKKR+CvMRfBsrzaQwLaf/NZi0s/XXDqLGd3IOSpuvCvHv6kWC5UXIRpAn/Y+3kUqZuyh0bjpKvSY0Pbai8LxFTS1II77ZWoMIhGLmVv+tW5hfKqfxb9q0CT0fXjxIbUA8ILRUafcxBr4qzvyzy42V6PYz99o5A=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782475391;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=JsJ7/0OQbCdxO0lgjPO2zptj6ufyAE9huc4qEakj9V4=;\n\tb=dHDBgz/YEz/0cSUPU10ySPp2LfbeHuBwZ+LHuX/+rlgpBxBGkXvm1b///Pt1dq6V\n\t8oK/tm6+2nnlgk512nK6Z29NUMTjcAkYrMeDIOxkFs6YqUzVVIb11MBwF/xtzdDtLxt\n\t+EktbXFda4MLYql9t93KEewlyevo1IiMVWE3FDnM=","Message-ID":"<513961a9-28c5-4088-b940-7571b7387323@collabora.com>","Date":"Fri, 26 Jun 2026 14:03:05 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 2/8] libcamera: software_isp: debayer_egl: Flag dmabuf\n\tuse once per session not for every frame","To":"libcamera-devel@lists.libcamera.org","References":"<20260626113325.3218045-1-bryan.odonoghue@linaro.org>\n\t<20260626113325.3218045-3-bryan.odonoghue@linaro.org>","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader ","In-Reply-To":"<20260626113325.3218045-3-bryan.odonoghue@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39467,"web_url":"https://patchwork.libcamera.org/comment/39467/","msgid":"<85jyrljx6h.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-06-26T12:36:22","subject":"Re: [PATCH v3 2/8] libcamera: software_isp: debayer_egl: Flag\n\tdmabuf use once per session not for every frame","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Once we get as far a streaming if we have one dmabuf import failure, take\n> that failure as canonical and do not try further imports. Add a flag to\n> debayer_egl which gets reset on any configure() to control this logic, flip\n> the dmabuf bit on the first failure for all subsequent frames.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/debayer_egl.cpp | 13 ++++++-------\n> src/libcamera/software_isp/debayer_egl.h | 2 ++\n> 2 files changed, 8 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 14eeb9a29..53bb67c17 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -316,6 +316,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \tinputPixelFormat_ = inputCfg.pixelFormat;\n> \twidth_ = inputCfg.size.width;\n> \theight_ = inputCfg.size.height;\n> +\tuse_dmabuf_ = true;\n> \n> \tif (outputCfgs.size() != 1) {\n> \t\tLOG(Debayer, Error)\n> @@ -515,21 +516,19 @@ void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerPara\n> \n> int DebayerEGL::debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *inMapped, std::optional *inDmaSyncer)\n> {\n> -\tbool dmabuf_import_succeeded = false;\n> -\n> \t/* eGL context switch */\n> \tegl_.makeCurrent();\n> \n> \t/* Try to create texture for input buffer via dmabuf import */\n> -\tif (!eglImageBayerIn_->dmabuf_import_failed_) {\n> -\t\tif (egl_.createInputDMABufTexture2D(*eglImageBayerIn_, input->planes()[0].fd.get()) == 0)\n> -\t\t\tdmabuf_import_succeeded = true;\n> -\t\telse\n> +\tif (use_dmabuf_) {\n> +\t\tif (egl_.createInputDMABufTexture2D(*eglImageBayerIn_, input->planes()[0].fd.get()) != 0) {\n> +\t\t\tuse_dmabuf_ = false;\n> \t\t\tLOG(Debayer, Info) << \"Importing input buffer with DMABuf import failed, falling back to upload\";\n> +\t\t}\n> \t}\n> \n> \t/* Otherwise create texture for input buffer via upload from CPU */\n> -\tif (!dmabuf_import_succeeded) {\n> +\tif (!use_dmabuf_) {\n> \t\tinDmaSyncer->emplace(input->planes()[0].fd, DmaSyncer::SyncType::Read);\n> \t\tinMapped->emplace(input, MappedFrameBuffer::MapFlag::Read);\n> \t\tif (!inMapped->value().isValid()) {\n> diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\n> index 348d7305b..d8509e9f2 100644\n> --- a/src/libcamera/software_isp/debayer_egl.h\n> +++ b/src/libcamera/software_isp/debayer_egl.h\n> @@ -68,6 +68,8 @@ private:\n> \tvoid setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams ¶ms);\n> \tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *mappedInputBuffer, std::optional *inputBufferDmaSyncer);\n> \n> +\tbool use_dmabuf_;\n> +\n> \t/* Shader program identifiers */\n> \tGLuint vertexShaderId_ = 0;\n> \tGLuint fragmentShaderId_ = 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1F79C3264\n\tfor ;\n\tFri, 26 Jun 2026 12:36:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE50865ED9;\n\tFri, 26 Jun 2026 14:36:28 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7341658FA\n\tfor ;\n\tFri, 26 Jun 2026 14:36:27 +0200 (CEST)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-613-B042vUIzP6q49fCs96lBDA-1; Fri, 26 Jun 2026 08:36:25 -0400","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-4926d371224so3354085e9.1\n\tfor ;\n\tFri, 26 Jun 2026 05:36:25 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-4.net.vodafone.cz. [77.48.47.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4926c28673dsm48910375e9.2.2026.06.26.05.36.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2026 05:36:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"VdYitB87\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1782477386;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=vixojD2ShEzuYozQY1RIPwKt1tMl+cfTJXZYuS0bBcU=;\n\tb=VdYitB87zcTyjXhpe7TWCmFuw3Ef1Y4Gpp/h7reQ49Oj4dzZ1DMHclo0hnknco2EXVFfLt\n\tKniWE/EcGxkcY6hxlIASWf9FqSxOsx/poG643TLsHaflhN3a7rI8KHEyRS0DLm6NiYSP2g\n\ttkc+rKO0Z2oW8wco7Z/28i2yZJ9gllc=","X-MC-Unique":"B042vUIzP6q49fCs96lBDA-1","X-Mimecast-MFC-AGG-ID":"B042vUIzP6q49fCs96lBDA_1782477384","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782477384; x=1783082184;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=vixojD2ShEzuYozQY1RIPwKt1tMl+cfTJXZYuS0bBcU=;\n\tb=m+PxnGvS+0hpDn1nCzYMve7xbUBMe5J4kMDqWuD43NUcpfxkSjibEI6BSXWhoyaDm/\n\t6NSwEUnawiWcPGmIa+vHEPQ2szyTvZcCnzlymKEoTkgTZ+N2nSklrcbKNZSgm0KRMXkT\n\tfguj0jlblPx0sn4T+q8iL46+AXmbTNbGX6EJKst0+zkZt23H2p46yK8YU2qDgujeni/7\n\t2qV+Wjnu9hFm9VgimYR3bMsY+T9wDpkDpASxqQIJvOHDkQBXaieAHmtAtt8dqmr+FjkW\n\tJVipDG+R/K6iUfMUs5mmuJ71LD5sRL2T9Nc2Bh3kZ/8k0MXIkE9bODolc2X4Ttksakt2\n\tnUXw==","X-Gm-Message-State":"AOJu0Yx1dDjk0vjKv3CKI6+Fl40ANoa5CgQcJQdxX/6vQphjwClFOlEw\n\tCGCh0Dpxap8D0NiY7LoHgQaiTQ9EPM/QOk/5WRImKMSopteGsF330gQ/1BZhVy2FHVGlcOgKVzx\n\tm5NfP1QdA3KY/XF1IqsW7tlirqQdRCoYTPa4HnYKVxcKLJ3eaV5NeJuutTs7fm4+F8xRvbyaNTz\n\t57HeXqjto=","X-Gm-Gg":"AfdE7cnvOUbNbLiAKZfR+tfEIh083ttjITOuarwNENkosHUK+klBntgGu6NtmbqpTCo\n\teE8BIxFZlWKmYsgDPjjKsf+hejSdmicCnVuh/9Nrm2aWfQSYm0wHkUeZp4M9CoGIxHx5CjNIfjp\n\tXo33+Bqm7CwfFu57WHlk/UFP/tPQa4GTcn3QXx2lBvt83tc1f7M9qTIgJe9Sr9baFlIeAEI5AQJ\n\tmwcIz2K9CzETTEd0F0Jji/71m6yhgvhTkKwr0vLXdPg9s18I1nTtHoIGUbZLX6+Q9zCxnC33vgW\n\tXGadikKjGrLdnTrUu8r3RjR9fo6A1zU7Fjgcj20dcTGyztOkrKFruJ1MKVzGgC5w5Qa+bqa+6ym\n\tMyc0k+C4CGVVeaDcG7lw81xgfPKeWWzkPCA2uFrcrTrltmDeMMvRerTnMQsaaDxiW","X-Received":["by 2002:a05:600c:8411:b0:492:3172:bcf0 with SMTP id\n\t5b1f17b1804b1-4926683880emr90599025e9.3.1782477384084; \n\tFri, 26 Jun 2026 05:36:24 -0700 (PDT)","by 2002:a05:600c:8411:b0:492:3172:bcf0 with SMTP id\n\t5b1f17b1804b1-4926683880emr90598555e9.3.1782477383601; \n\tFri, 26 Jun 2026 05:36:23 -0700 (PDT)"],"From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH v3 2/8] libcamera: software_isp: debayer_egl: Flag\n\tdmabuf use once per session not for every frame","In-Reply-To":"<20260626113325.3218045-3-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Fri, 26 Jun 2026 12:33:19 +0100\")","References":"<20260626113325.3218045-1-bryan.odonoghue@linaro.org>\n\t<20260626113325.3218045-3-bryan.odonoghue@linaro.org>","Date":"Fri, 26 Jun 2026 14:36:22 +0200","Message-ID":"<85jyrljx6h.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"gtGQGM0_IimJC8W-ATiXjIAFZatb1WBBktoc0dAf9LI_1782477384","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]