{"id":27048,"url":"https://patchwork.libcamera.org/api/patches/27048/?format=json","web_url":"https://patchwork.libcamera.org/patch/27048/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260626113325.3218045-2-bryan.odonoghue@linaro.org>","date":"2026-06-26T11:33:18","name":"[v3,1/8] libcamera: software_isp: debayer_egl: Pass eglImage as parameter to setShaderVariables","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6cfa7f4ff004a514ed7180481ae8fa4a2a191a73","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27048/mbox/","series":[{"id":6020,"url":"https://patchwork.libcamera.org/api/series/6020/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6020","date":"2026-06-26T11:33:17","name":"libcamera: software_isp: gpu: Add go faster stripes","version":3,"mbox":"https://patchwork.libcamera.org/series/6020/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27048/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27048/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE158C3301\n\tfor ;\n\tFri, 26 Jun 2026 11:33:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FBD2658FE;\n\tFri, 26 Jun 2026 13:33:39 +0200 (CEST)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B908658F4\n\tfor ;\n\tFri, 26 Jun 2026 13:33:38 +0200 (CEST)","by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-49249707788so7531815e9.2\n\tfor ;\n\tFri, 26 Jun 2026 04:33:38 -0700 (PDT)","from inspiron14p-linux ([109.76.78.98])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-49268fe31b0sm79265985e9.4.2026.06.26.04.33.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2026 04:33:36 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"c6gVsJjA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1782473618; x=1783078418;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=AIHm6rbPGluS8yMRW43DSurymjR5fEjks6iSsfrj5Vg=;\n\tb=c6gVsJjAmjWJxCJq4IAs4H5ipXrfS28VEl7VKtFeqWzd7YKTBpOkobQ5TuW5//NGtF\n\ttQPafbq235f6DBIokt4+Q6n2gJeBX8DlU8O5PgtjbBVu8rWT2tK5H8yRPf/tv46z1Tab\n\t0oCE893puIbu8l1CDZ5XHd/RIFbmizYYhK2rruIXLgPS/8yYRNBg255mln1jJldFD0AE\n\tF3zi2jpnaycZ519SpullhnpzN+46+XNv0TFTD12E5osTPXf62pFkdjGlYCE/Bf8Rfj85\n\tXZZs5zTqSVD4A7a2gVgu4yewYlz55goZmSJFzSqxQgwWGxcqSzYcshYnv5GB5mP+3s12\n\toOdg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782473618; x=1783078418;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=AIHm6rbPGluS8yMRW43DSurymjR5fEjks6iSsfrj5Vg=;\n\tb=VMd50i7WORGk1C0HHPAXeK+Sh/mhculJqtjE1hXr/yKChK1MLYwtsKXhjTOj/YWTXE\n\tMRFAyr/RneIZIcCxdGNxDB2FyjU65hG1AZ6rfq+OHIsnOQKcOKMeiDEqtJQ2AO7Zk3xr\n\tcpZv6Rd1c1yh7guojtM6j6/D0yzjgJdYcp01eaSRJ6wQO/JpbAyUdB7GC0lSqHrRKOye\n\tEhdYFTvzn1+uMaWDwCXI+IdQqZLD2Pe17JsZa+sfGzRtSCVQ2yZkjoyWQokwvHb5h4B0\n\tBoorzNvX4VfwaoV0g7WX0odt1lzEvagUU8kKZHh1SCvCthzj/aR88QE7IYDugJhvZ7IN\n\tyXnw==","X-Gm-Message-State":"AOJu0Yw9ucmWIDsQGD1ecweMKmXFgqcyLiMRAXoOUwR8bfntbHRGHZLO\n\tF0YN+n/G/ywWhmbacunS6dbsMDzKO2E3PbPAeTeEbHYag1A42HgINPyOaoJhgRWvUFuQyiKCTs4\n\tObI2Tu8Q=","X-Gm-Gg":"AfdE7cnONMN18EL3VB4sZc8anuYwnKASnpw2cZieH8yhge3xZi+vWHXwoNrCfaXej4A\n\tb7Qqb3Ek3Dmb0MdX08xYv2Bu6+8W4/lysVOIAiLwc6Xp9P4ahrDAqwGUOBTd9DXXPTZ7qUA1FjE\n\th3W+qwPiG1o3xuj7/dSORJinXhNbhFW+wy9HFFBXlzZAR79C7vEjXKGJp1n2QJ5kS2sZ8gLyATc\n\tKSvUJYd0XOz6DP/HpzKLxh+rEDiOWXkw+s3gixDWSL9Ouy5NRFphGMxdq752agZB/OSzPzyzCOi\n\tpXOmkR/E2OfopVgmOy8t2r5Hk7WRF1EDOd8SM6HTEtKQzKKcJ4UD55QKpP/VDT9C4xa1rwG0VKl\n\t0+rENRakDMIVrfAD8Paj5ei4rWqcm/M8jGp4tOHR5JpcfA0yDt5kM249CswFO6e+sGK0uSj2STa\n\txRqNUTPQWFS1OsDpUx47hJQPQFMQ==","X-Received":"by 2002:a05:600c:4e0b:b0:490:44eb:c1ea with SMTP id\n\t5b1f17b1804b1-4926fc78e30mr6165485e9.24.1782473617839; \n\tFri, 26 Jun 2026 04:33:37 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"bryan.odonoghue@linaro.org, pavel@ucw.cz,\n\tRobert Mader ","Subject":"[PATCH v3 1/8] libcamera: software_isp: debayer_egl: Pass eglImage\n\tas parameter to setShaderVariables","Date":"Fri, 26 Jun 2026 12:33:18 +0100","Message-ID":"<20260626113325.3218045-2-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260626113325.3218045-1-bryan.odonoghue@linaro.org>","References":"<20260626113325.3218045-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We will create a cache of textures and eGLImages which means the value\nassigned to the shader texture unit will come from one of those now cached\neGLImage objects.\n\nPass eGLImage as a parameter to facilitate future differentiation.\n\nReviewed-by: Robert Mader \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer_egl.cpp | 6 +++---\n src/libcamera/software_isp/debayer_egl.h | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 0ec2a98cf..14eeb9a29 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -397,7 +397,7 @@ uint32_t DebayerEGL::preferredInputStride(const PixelFormat &inputFormat, const\n \treturn info.stride(size.width, 0, 256);\n }\n \n-void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n+void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerParams ¶ms)\n {\n \t/*\n \t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n@@ -453,7 +453,7 @@ void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n \t * To simultaneously sample multiple textures we need to use multiple\n \t * texture units\n \t */\n-\tglUniform1i(textureUniformBayerDataIn_, eglImageBayerIn_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformBayerDataIn_, eglImageIn.texture_unit_uniform_id_);\n \n \t/*\n \t * These values are:\n@@ -542,7 +542,7 @@ int DebayerEGL::debayerGPU(FrameBuffer *input, FrameBuffer *output, const Debaye\n \t/* Generate the output render framebuffer as render to texture */\n \tegl_.createOutputDMABufTexture2D(*eglImageBayerOut_, output->planes()[0].fd.get());\n \n-\tsetShaderVariableValues(params);\n+\tsetShaderVariableValues(*eglImageBayerIn_, params);\n \tglViewport(0, 0, width_, height_);\n \tglClear(GL_COLOR_BUFFER_BIT);\n \tglDrawArrays(GL_TRIANGLE_FAN, 0, DEBAYER_OPENGL_COORDS);\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 4c7c86472..348d7305b 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -65,7 +65,7 @@ private:\n \tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n \tint getShaderVariableLocations();\n-\tvoid setShaderVariableValues(const DebayerParams ¶ms);\n+\tvoid setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams ¶ms);\n \tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *mappedInputBuffer, std::optional *inputBufferDmaSyncer);\n \n \t/* Shader program identifiers */\n","prefixes":["v3","1/8"]}