{"id":27044,"url":"https://patchwork.libcamera.org/api/patches/27044/?format=json","web_url":"https://patchwork.libcamera.org/patch/27044/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260626092847.289764-2-robert.mader@collabora.com>","date":"2026-06-26T09:28:46","name":"[v2,1/2] pipeline: virtual: Move libjpeg requirement to libyuv subproject","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7a334b49b56bb6fd51708c717fb760993409581a","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/27044/mbox/","series":[{"id":6018,"url":"https://patchwork.libcamera.org/api/series/6018/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6018","date":"2026-06-26T09:28:45","name":"meson: Build virtual pipeline by default","version":2,"mbox":"https://patchwork.libcamera.org/series/6018/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/27044/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/27044/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57886C3264\n\tfor ;\n\tFri, 26 Jun 2026 09:29:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E96BF658E8;\n\tFri, 26 Jun 2026 11:29:22 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6900B658D4\n\tfor ;\n\tFri, 26 Jun 2026 11:29:18 +0200 (CEST)","by mx.zohomail.com with SMTPS id 178246615329283.0356375782984;\n\tFri, 26 Jun 2026 02:29:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"d7WmNu7I\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1782466155; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=aGBiJRS3LrdATmVDamCng9IwGzPH4f+/24qMXVW3L2EBFwTYzZw2ILf/NyqaB3HouhgnhJ9SgguQ4d0zvC7Cqv/ZSRPaRri/BETwlucf7pn34LTZXE2ObRmNaRNdwiJ3B9AXrGi11KZ83uoXEZrPGdCLvyz7oA1nl1RTYYzzC8w=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1782466155;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=0KyvNufTBQY1gRY4szs7oV6kY1J+8EDmn71U3s1oDPc=; \n\tb=XKx7AadpPpVqkxUd25eM+KdcesJNwC1S+IZVRjvMrlkaWRETCM7wiDt9nNIQu+FVWJdzcwLj5G4eLDmJeMuiT1HhQRU7AVwCbFsf8J75FMz0v/3SrT9y18C0Qt3Vq6YmL9MuC69JBzsHdvJlCfM34fIi9jzWGrQZ1qCEGNhbmZk=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782466155;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=0KyvNufTBQY1gRY4szs7oV6kY1J+8EDmn71U3s1oDPc=;\n\tb=d7WmNu7IclquUcoRPuVW2JBiQgfasoSbZqZ5EihtaA1OES8q+JSLmAxOopJmFUoA\n\tcLKXmw6UGowkAm/Iy8DXTx6L1rnhm0V+G+biUS4DFQ1G04qNZt9PrQcIsv66ZJmEGfB\n\tQRpqHPUd7qWQroSl8NS4YIrS7muXPFHbJhDanbDA=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ","Subject":"[PATCH v2 1/2] pipeline: virtual: Move libjpeg requirement to libyuv\n\tsubproject","Date":"Fri, 26 Jun 2026 11:28:46 +0200","Message-ID":"<20260626092847.289764-2-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260626092847.289764-1-robert.mader@collabora.com>","References":"<20260626092847.289764-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libyuv already depends on libjpeg. The requirement for the later is only\nneeded if libyuv is build from the subproject fallback, thus move the\nrequirement accordingly. This allows the virtual pipeline to be build\nwith only libyuv development files installed - and without libjpeg ones.\n\nSigned-off-by: Robert Mader \n---\n src/libcamera/pipeline/virtual/meson.build | 3 ---\n src/meson.build | 4 +++-\n 2 files changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/meson.build b/src/libcamera/pipeline/virtual/meson.build\nindex c84345936..19fde9cf8 100644\n--- a/src/libcamera/pipeline/virtual/meson.build\n+++ b/src/libcamera/pipeline/virtual/meson.build\n@@ -7,9 +7,6 @@ libcamera_internal_sources += files([\n 'virtual.cpp',\n ])\n \n-libjpeg = dependency('libjpeg', required : true)\n-\n libcamera_deps += [libyuv_dep]\n-libcamera_deps += [libjpeg]\n \n subdir('data')\ndiff --git a/src/meson.build b/src/meson.build\nindex 9b63c8e84..8e23d40c3 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -46,6 +46,8 @@ if (pipelines.contains('virtual') or get_option('android').allowed()) and \\\n not libyuv_dep.found()\n cmake = import('cmake')\n \n+ libjpeg = dependency('libjpeg', required : true)\n+\n libyuv_vars = cmake.subproject_options()\n libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n libyuv_vars.set_override_option('cpp_std', 'c++17')\n@@ -64,7 +66,7 @@ if (pipelines.contains('virtual') or get_option('android').allowed()) and \\\n # Work around the issue by wrapping the libyuv static library into another\n # static library with 'pic' set to true.\n libyuv_static = static_library('libyuv-static',\n- dependencies : libyuv.dependency('yuv'),\n+ dependencies : [libyuv.dependency('yuv'), libjpeg],\n pic : true,\n install : false)\n libyuv_include = libyuv.include_directories('yuv')\n","prefixes":["v2","1/2"]}