[{"id":39423,"web_url":"https://patchwork.libcamera.org/comment/39423/","msgid":"<59078a57-843b-42c1-a37c-c68cd9630903@ideasonboard.com>","date":"2026-06-26T07:48:59","subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 26. 9:40 keltezéssel, Robert Mader írta:\n> It doesn't seem to be used.\n\nI guess it might have been added because there was plans to do something\nor because libyuv itself has a dependency on libjpeg (but of course\nthat shouldn't be needed)?\n\n\n> \n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> ---\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n\n>   src/libcamera/pipeline/virtual/meson.build | 3 ---\n>   1 file changed, 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/meson.build b/src/libcamera/pipeline/virtual/meson.build\n> index c84345936..19fde9cf8 100644\n> --- a/src/libcamera/pipeline/virtual/meson.build\n> +++ b/src/libcamera/pipeline/virtual/meson.build\n> @@ -7,9 +7,6 @@ libcamera_internal_sources += files([\n>       'virtual.cpp',\n>   ])\n> \n> -libjpeg = dependency('libjpeg', required : true)\n> -\n>   libcamera_deps += [libyuv_dep]\n> -libcamera_deps += [libjpeg]\n> \n>   subdir('data')\n> --\n> 2.54.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64315C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 07:49:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56B3E658DF;\n\tFri, 26 Jun 2026 09:49:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6728E658D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 09:49:03 +0200 (CEST)","from [192.168.33.48] (185.221.143.75.nat.pool.zt.hu\n\t[185.221.143.75])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E7BD1E7;\n\tFri, 26 Jun 2026 09:48:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZbZTJwVH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782460102;\n\tbh=jlIC6NqFgSrUieKKRai3BaUNL/Osbzp4oiM+6MiOdUM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ZbZTJwVHU+gZrcPsOsShaFjcBZMBg/MSQP1XyYWE0X6/1zEnGPAfp3wKX4xF7gYPO\n\tBySHOgKXfLulExayrFhrI4AKkO+FyKXfgWN2H42ZbLSfnMfGZ5CI5Y4Xwemq69ovnI\n\tBcbwunjkqCXsI1RLJj5gISsr2EUxm5X7B7bKyRsM=","Message-ID":"<59078a57-843b-42c1-a37c-c68cd9630903@ideasonboard.com>","Date":"Fri, 26 Jun 2026 09:48:59 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org,\n\tHarvey Yang <chenghaoyang@chromium.org>","References":"<20260626074100.272963-1-robert.mader@collabora.com>\n\t<kThAbFj63koNj0t_C_wuYHiUSABSubkowTbmt3LKBINiFB73rOMsol--rcWRY1fBnp-kLXyyL_lpwpTuufHD5A==@protonmail.internalid>\n\t<20260626074100.272963-2-robert.mader@collabora.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260626074100.272963-2-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39424,"web_url":"https://patchwork.libcamera.org/comment/39424/","msgid":"<178246073017.43116.5609028290431469772@ping.linuxembedded.co.uk>","date":"2026-06-26T07:58:50","subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2026-06-26 08:40:59)\n> It doesn't seem to be used.\n> \n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> ---\n>  src/libcamera/pipeline/virtual/meson.build | 3 ---\n>  1 file changed, 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/meson.build b/src/libcamera/pipeline/virtual/meson.build\n> index c84345936..19fde9cf8 100644\n> --- a/src/libcamera/pipeline/virtual/meson.build\n> +++ b/src/libcamera/pipeline/virtual/meson.build\n> @@ -7,9 +7,6 @@ libcamera_internal_sources += files([\n>      'virtual.cpp',\n>  ])\n>  \n> -libjpeg = dependency('libjpeg', required : true)\n> -\n\n\nAha, now I hear that we do support jpegs, but through libyuv which can\ndepend on libjpeg (or whatever jpeg support it desires) so we don't need\nto be explicit here.\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n>  libcamera_deps += [libyuv_dep]\n> -libcamera_deps += [libjpeg]\n>  \n>  subdir('data')\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98BD9C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 07:58:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7091658D3;\n\tFri, 26 Jun 2026 09:58:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6983658D0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 09:58:52 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA70F9A0;\n\tFri, 26 Jun 2026 09:58:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AUOIYLxm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782460691;\n\tbh=vhDxOAngk1Su81L8rqfUH8Vx6ayjDpzxX3lwQZxevHI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=AUOIYLxmtLOmIIGV2WfOdC3VfK4URilsj7l12ItXGXPHMj3tZTL1EBhW+gjVNGDif\n\tQUQRbKnG0oiT4HBKlx9TKH+T04fAXYyiuedlC38RxKr6KjbaPxyf+IG67YTJ+GsiE1\n\tWsC+kCD85sOCq83w8KRFx3gMp7qU8UFx3kno9U00=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260626074100.272963-2-robert.mader@collabora.com>","References":"<20260626074100.272963-1-robert.mader@collabora.com>\n\t<20260626074100.272963-2-robert.mader@collabora.com>","Subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Robert Mader <robert.mader@collabora.com>","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 26 Jun 2026 08:58:50 +0100","Message-ID":"<178246073017.43116.5609028290431469772@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39428,"web_url":"https://patchwork.libcamera.org/comment/39428/","msgid":"<35a0b071-1530-40f6-8def-326e1758ee1e@ideasonboard.com>","date":"2026-06-26T08:48:04","subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 06. 26. 9:48 keltezéssel, Barnabás Pőcze írta:\n> 2026. 06. 26. 9:40 keltezéssel, Robert Mader írta:\n>> It doesn't seem to be used.\n> \n> I guess it might have been added because there was plans to do something\n> or because libyuv itself has a dependency on libjpeg (but of course\n> that shouldn't be needed)?\n> \n> \n>>\n>> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n>> ---\n> \n> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\nNevermind. When libyuv is not available, meson falls back to using\nthe upstream CMakeLists.txt, but as far as I can see that does not\nset the libjpeg dependency up, leading to linker errors:\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/103332638#L1014\n\nSo as far as I can tell, this cannot be merged as is.\n\n\n> \n> \n>>    src/libcamera/pipeline/virtual/meson.build | 3 ---\n>>    1 file changed, 3 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/virtual/meson.build b/src/libcamera/pipeline/virtual/meson.build\n>> index c84345936..19fde9cf8 100644\n>> --- a/src/libcamera/pipeline/virtual/meson.build\n>> +++ b/src/libcamera/pipeline/virtual/meson.build\n>> @@ -7,9 +7,6 @@ libcamera_internal_sources += files([\n>>        'virtual.cpp',\n>>    ])\n>>\n>> -libjpeg = dependency('libjpeg', required : true)\n>> -\n>>    libcamera_deps += [libyuv_dep]\n>> -libcamera_deps += [libjpeg]\n>>\n>>    subdir('data')\n>> --\n>> 2.54.0\n>>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4810C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 08:48:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B2A9658D7;\n\tFri, 26 Jun 2026 10:48:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A50F658D0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 10:48:07 +0200 (CEST)","from [192.168.33.48] (185.221.143.75.nat.pool.zt.hu\n\t[185.221.143.75])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F8CD1E4;\n\tFri, 26 Jun 2026 10:47:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eees2Gw8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782463646;\n\tbh=4mz9mFnoKAuqE4rFyhyG+lnjYi1I+nJvj+AufsKgcBg=;\n\th=Date:Subject:From:To:Reply-To:References:In-Reply-To:From;\n\tb=eees2Gw8Hgj+Fktt1V9EtwqgJ22c0XVPF2sctJSI17kSwAQdTPwDKXaUWqHxCGPu5\n\titl6TAsQaZTMComcu1onS6AfsLiEr2Doi0J74/o+3gpQXyAV8TqegslJxdoKtYoWiW\n\tjyGmg+h4/sLXQanaWuCzBpmH2RoakQRc9RSn5/Sg=","Message-ID":"<35a0b071-1530-40f6-8def-326e1758ee1e@ideasonboard.com>","Date":"Fri, 26 Jun 2026 10:48:04 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org,\n\tHarvey Yang <chenghaoyang@chromium.org>","References":"<20260626074100.272963-1-robert.mader@collabora.com>\n\t<kThAbFj63koNj0t_C_wuYHiUSABSubkowTbmt3LKBINiFB73rOMsol--rcWRY1fBnp-kLXyyL_lpwpTuufHD5A==@protonmail.internalid>\n\t<20260626074100.272963-2-robert.mader@collabora.com>\n\t<fBRHrrmcvd3HFP56k5NA_bKgGhjCgoqsx8lILN_d63QmDgXJZ5-SoliIPpqqz6he97HMa_WZoLG6pJX0ludlSA==@protonmail.internalid>\n\t<59078a57-843b-42c1-a37c-c68cd9630903@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<59078a57-843b-42c1-a37c-c68cd9630903@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39432,"web_url":"https://patchwork.libcamera.org/comment/39432/","msgid":"<20260626093708.GB2258794@killaraus.ideasonboard.com>","date":"2026-06-26T09:37:08","subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jun 26, 2026 at 10:48:04AM +0200, Barnabás Pőcze wrote:\n> 2026. 06. 26. 9:48 keltezéssel, Barnabás Pőcze írta:\n> > 2026. 06. 26. 9:40 keltezéssel, Robert Mader írta:\n> >> It doesn't seem to be used.\n> > \n> > I guess it might have been added because there was plans to do something\n> > or because libyuv itself has a dependency on libjpeg (but of course\n> > that shouldn't be needed)?\n> > \n> >> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> >> ---\n> > \n> > Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> \n> Nevermind. When libyuv is not available, meson falls back to using\n> the upstream CMakeLists.txt, but as far as I can see that does not\n> set the libjpeg dependency up, leading to linker errors:\n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/103332638#L1014\n> \n> So as far as I can tell, this cannot be merged as is.\n\nExplaining this in a comment in meson.build will help avoiding a similar\npatch in the future when everybody will have forgotten.\n\n> >>    src/libcamera/pipeline/virtual/meson.build | 3 ---\n> >>    1 file changed, 3 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/virtual/meson.build b/src/libcamera/pipeline/virtual/meson.build\n> >> index c84345936..19fde9cf8 100644\n> >> --- a/src/libcamera/pipeline/virtual/meson.build\n> >> +++ b/src/libcamera/pipeline/virtual/meson.build\n> >> @@ -7,9 +7,6 @@ libcamera_internal_sources += files([\n> >>        'virtual.cpp',\n> >>    ])\n> >>\n> >> -libjpeg = dependency('libjpeg', required : true)\n> >> -\n> >>    libcamera_deps += [libyuv_dep]\n> >> -libcamera_deps += [libjpeg]\n> >>\n> >>    subdir('data')","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8E22C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 09:37:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5C46658E9;\n\tFri, 26 Jun 2026 11:37:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9689B658D9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 11:37:10 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82B5E1E6;\n\tFri, 26 Jun 2026 11:36:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"am/PZmK2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782466589;\n\tbh=+MBA1AnLaeHb6KkmKyjy0W3X+5/ekQex0rP8UlOmmvw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=am/PZmK2QNZkksSY1VsvR80vEdfr2IUChZxSV30hR0Js4unpbRyCTxJV9667oCj7f\n\tE3RLibr1+bsL+4TmrbxLgkMgd+J0hVQXhlZa0ohC7Z1Q6lQ041LjH1AnHyW/QflrNf\n\tw/6s+yGLszIB52sqh90wiqkoDcyIAHnsZKqxL3Sw=","Date":"Fri, 26 Jun 2026 12:37:08 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Cc":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org,\n\tHarvey Yang <chenghaoyang@chromium.org>","Subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","Message-ID":"<20260626093708.GB2258794@killaraus.ideasonboard.com>","References":"<20260626074100.272963-1-robert.mader@collabora.com>\n\t<kThAbFj63koNj0t_C_wuYHiUSABSubkowTbmt3LKBINiFB73rOMsol--rcWRY1fBnp-kLXyyL_lpwpTuufHD5A==@protonmail.internalid>\n\t<20260626074100.272963-2-robert.mader@collabora.com>\n\t<fBRHrrmcvd3HFP56k5NA_bKgGhjCgoqsx8lILN_d63QmDgXJZ5-SoliIPpqqz6he97HMa_WZoLG6pJX0ludlSA==@protonmail.internalid>\n\t<59078a57-843b-42c1-a37c-c68cd9630903@ideasonboard.com>\n\t<35a0b071-1530-40f6-8def-326e1758ee1e@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<35a0b071-1530-40f6-8def-326e1758ee1e@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":39433,"web_url":"https://patchwork.libcamera.org/comment/39433/","msgid":"<dbe5fbe4-00ad-4f21-badb-1a987dd39b8b@collabora.com>","date":"2026-06-26T09:39:42","subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 26.06.26 11:37, Laurent Pinchart wrote:\n>> Nevermind. When libyuv is not available, meson falls back to using\n>> the upstream CMakeLists.txt, but as far as I can see that does not\n>> set the libjpeg dependency up, leading to linker errors:\n>> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/103332638#L1014\n>>\n>> So as far as I can tell, this cannot be merged as is.\n> Explaining this in a comment in meson.build will help avoiding a similar\n> patch in the future when everybody will have forgotten.\n\nI think the solution in v2 makes that obvious by moving\n\nlibjpeg = dependency('libjpeg', required : true)\n\nclose to the\n\nlibyuv_vars.append_link_args('-ljpeg')\n\nthat is the reason for the dependency.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE574BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 09:39:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 308EF658E7;\n\tFri, 26 Jun 2026 11:39:55 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62538658D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 11:39:53 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1782466787651198.1502831848038;\n\tFri, 26 Jun 2026 02:39:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"JE/GWRmj\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1782466789; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=bXznn8Wt0MO29w3p6gr4pJBP5J9bC6DIMIQAfa3AsZ+jILff2+DnqMYhwJLASJNgErQkCsXKTrPEJpR9NsFuqZa6QAi6ZE4lX51YIn66KLcbQ/hU2Uv2lk++WyQHY3bSisQQLbmOUrTVAYVHyncaK1JphRMlMWQZSE4kBDXFfy8=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1782466789;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=AcOLVFTUVbGEXi2xp4WYKobXD5IApf8g7ulgsmgsB7k=; \n\tb=S6da+J63LVTqOWMCYRMXfhYG3x7jMiUIQXjTYe6VFcl+06KWUqsoszgUrHytSpxMGiqMIm2EODy+DoMeDXaCFJ/5QMLUSMiO0KRJPCz5z3UCNFZdVF7YzuZsdwgQdbprnPfUjV4RYiZwjWStIk8iSy8ovPwe/EwjCZB41uFgaSM=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass  header.i=collabora.com;\n\tspf=pass  smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782466789;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=AcOLVFTUVbGEXi2xp4WYKobXD5IApf8g7ulgsmgsB7k=;\n\tb=JE/GWRmjGjU9k9BrGTnCsnWoBbzvQ1mw+wtGK/0m283f4IlroI6U5x38oeNWFKnC\n\t+vRzG5qRMtqwA9xWnrQlnt1PH5jMSMOKYr2c9AJn6ow6FDT3hp6dqsszLISi8H+Ko2e\n\tykeHn1WoKxq9bpu7+LQWxgwBHsBJNQQn6z8ektZ0=","Message-ID":"<dbe5fbe4-00ad-4f21-badb-1a987dd39b8b@collabora.com>","Date":"Fri, 26 Jun 2026 11:39:42 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/2] pipeline: virtual: Remove libjpeg dependency","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>, =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= <barnabas.pocze@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tHarvey Yang <chenghaoyang@chromium.org>","References":"<20260626074100.272963-1-robert.mader@collabora.com>\n\t<kThAbFj63koNj0t_C_wuYHiUSABSubkowTbmt3LKBINiFB73rOMsol--rcWRY1fBnp-kLXyyL_lpwpTuufHD5A==@protonmail.internalid>\n\t<20260626074100.272963-2-robert.mader@collabora.com>\n\t<fBRHrrmcvd3HFP56k5NA_bKgGhjCgoqsx8lILN_d63QmDgXJZ5-SoliIPpqqz6he97HMa_WZoLG6pJX0ludlSA==@protonmail.internalid>\n\t<59078a57-843b-42c1-a37c-c68cd9630903@ideasonboard.com>\n\t<35a0b071-1530-40f6-8def-326e1758ee1e@ideasonboard.com>\n\t<20260626093708.GB2258794@killaraus.ideasonboard.com>","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader <robert.mader@collabora.com>","In-Reply-To":"<20260626093708.GB2258794@killaraus.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]