[{"id":39379,"web_url":"https://patchwork.libcamera.org/comment/39379/","msgid":"<30f9b655-5cf1-4514-8412-67aac76d0c95@collabora.com>","date":"2026-06-24T11:58:12","subject":"Re: [PATCH 03/10] libcamera: egl: Extend eGL::createTexture2D to\n\tunderstand floats","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 24.06.26 10:58, Bryan O'Donoghue wrote:\n> We want to have the option to use floats as an intermediary format between\n> different stages of a multi-pass pipeline. Adding floats means also\n> plumbing the infrastructure to differentiate on data-type on the input to\n> texture creation.\n>\n> Add the floats and the plumbing.\n\nI understand that this patch simplified the rebase from the multi-pass \nseries, however I would prefer if it was dropped here, given that it's \notherwise unrelated.\n\nNo strong opinion though and the code itself looks good to me, thus I'll \nleave that decision to you / others:\n\nReviewed-by: Robert Mader \n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/egl.cpp | 18 +++++++++++++++++-\n> 1 file changed, 17 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index e83e24606..8d80a6d1a 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -268,13 +268,29 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n> */\n> void eGL::createTexture2D(eGLImage &eglImage, void *data)\n> {\n> +\tGLenum format;\n> +\tGLenum type = GL_UNSIGNED_BYTE;\n> +\n> \tASSERT(tid_ == Thread::currentId());\n> \n> \tglActiveTexture(eglImage.texture_unit_);\n> \tglBindTexture(GL_TEXTURE_2D, eglImage.texture_);\n> \n> +\tswitch (eglImage.format_) {\n> +\tcase GL_R16F:\n> +\t\tformat = GL_RED;\n> +\t\ttype = GL_HALF_FLOAT;\n> +\t\tbreak;\n> +\tcase GL_RG8:\n> +\t\tformat = GL_RG;\n> +\t\tbreak;\n> +\tcase GL_LUMINANCE:\n> +\t\tformat = GL_LUMINANCE;\n> +\t\tbreak;\n> +\t}\n> +\n> \t// Generate texture, bind, associate image to texture, configure, unbind\n> -\tglTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, eglImage.format_, GL_UNSIGNED_BYTE, data);\n> +\tglTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, format, type, data);\n> \n> \t// Nearest filtering\n> \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81F1BC3306\n\tfor ;\n\tWed, 24 Jun 2026 11:58:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B825F658A6;\n\tWed, 24 Jun 2026 13:58:23 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1FAA65891\n\tfor ;\n\tWed, 24 Jun 2026 13:58:21 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1782302294895758.0769797509626;\n\tWed, 24 Jun 2026 04:58:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"kY9vITke\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1782302298; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=XnbufPc0OX+F7GRs/Ut7MSDLrpknsSeSxQlzr5IV90LWB4QQdAEI/rttgcMJwG1qxPf6Pa5I7A5oxxxg5eZIEStGRkgibQTr7sQY/f6ajeRNiNbkzCYdcDewzbOQ5KoAOLJKuW0kjzzTYBiT0VfDIqPdUk5AMCMVM0i+LpLZDlM=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1782302298;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=THg5xSTuDCOXDMkjmvsWIKsu0/kCtnADlSLcddozUSw=; \n\tb=fjCoY2X5EVOD/ABqU1IxoRfyycscUMmhCDOGpfxUV7s9fHFt181h/orQCFdO9t9BxM5hc24SQ5aHxvjaEIo2hd0WKLLjdEse+AUB9i/6LCq9qPTemMmCsFVfSSoxiZ2ab1bY2FdmfoVVNGKO5uQRp4lcZxwt6gshlllCYoLDqBU=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782302298;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=THg5xSTuDCOXDMkjmvsWIKsu0/kCtnADlSLcddozUSw=;\n\tb=kY9vITkeoSddfQON8eEzjdCFPDbuXWNYgARlItSBovzboboXR2JZHZFomPJkUo9h\n\tL55qcyfmZbI9h39xXvTiqWTceackUVXpMC+rNuSn5nQpSSOdU2MKDsvYUE3DUVuQT0d\n\te21s+KMRgonTZZCQzy5wCWYiRi2Cv9nJO+UQ6yvo=","Message-ID":"<30f9b655-5cf1-4514-8412-67aac76d0c95@collabora.com>","Date":"Wed, 24 Jun 2026 13:58:12 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 03/10] libcamera: egl: Extend eGL::createTexture2D to\n\tunderstand floats","To":"libcamera-devel@lists.libcamera.org","References":"<20260624085849.873784-1-bryan.odonoghue@linaro.org>\n\t<20260624085849.873784-4-bryan.odonoghue@linaro.org>","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader ","In-Reply-To":"<20260624085849.873784-4-bryan.odonoghue@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39413,"web_url":"https://patchwork.libcamera.org/comment/39413/","msgid":"","date":"2026-06-25T15:59:14","subject":"Re: [PATCH 03/10] libcamera: egl: Extend eGL::createTexture2D to\n\tunderstand floats","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 24/06/2026 12:58, Robert Mader wrote:\n>> Add the floats and the plumbing.\n> I understand that this patch simplified the rebase from the multi-pass\n> series, however I would prefer if it was dropped here, given that it's\n> otherwise unrelated.\n> \n> No strong opinion though and the code itself looks good to me, thus I'll\n> leave that decision to you / others:\n> \n> Reviewed-by: Robert Mader\n\nUnless its a hard-NAK though, I'd rather get this in than rewrite \neverything and then rewrite everything again for multipass.\n\nI'll abuse your RB tyvm.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11F53C3301\n\tfor ;\n\tThu, 25 Jun 2026 15:59:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F370B658CA;\n\tThu, 25 Jun 2026 17:59:19 +0200 (CEST)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA7BF623CB\n\tfor ;\n\tThu, 25 Jun 2026 17:59:17 +0200 (CEST)","from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 92254600AE\n\tfor ;\n\tThu, 25 Jun 2026 15:59:16 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0875A1F000E9\n\tfor ;\n\tThu, 25 Jun 2026 15:59:15 +0000 (UTC)"],"Message-ID":"","Date":"Thu, 25 Jun 2026 16:59:14 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 03/10] libcamera: egl: Extend eGL::createTexture2D to\n\tunderstand floats","To":"libcamera-devel@lists.libcamera.org","References":"<20260624085849.873784-1-bryan.odonoghue@linaro.org>\n\t<20260624085849.873784-4-bryan.odonoghue@linaro.org>\n\t\n\t<30f9b655-5cf1-4514-8412-67aac76d0c95@collabora.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<30f9b655-5cf1-4514-8412-67aac76d0c95@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39441,"web_url":"https://patchwork.libcamera.org/comment/39441/","msgid":"<85v7b5lgch.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-06-26T10:57:02","subject":"Re: [PATCH 03/10] libcamera: egl: Extend eGL::createTexture2D to\n\tunderstand floats","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> We want to have the option to use floats as an intermediary format between\n> different stages of a multi-pass pipeline. Adding floats means also\n> plumbing the infrastructure to differentiate on data-type on the input to\n> texture creation.\n>\n> Add the floats and the plumbing.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/egl.cpp | 18 +++++++++++++++++-\n> 1 file changed, 17 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index e83e24606..8d80a6d1a 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -268,13 +268,29 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n> */\n> void eGL::createTexture2D(eGLImage &eglImage, void *data)\n> {\n> +\tGLenum format;\n\nThis is still left uninitialised, resulting in a compiler warning on the\nswitch below.\n\n> +\tGLenum type = GL_UNSIGNED_BYTE;\n> +\n> \tASSERT(tid_ == Thread::currentId());\n> \n> \tglActiveTexture(eglImage.texture_unit_);\n> \tglBindTexture(GL_TEXTURE_2D, eglImage.texture_);\n> \n> +\tswitch (eglImage.format_) {\n> +\tcase GL_R16F:\n> +\t\tformat = GL_RED;\n> +\t\ttype = GL_HALF_FLOAT;\n> +\t\tbreak;\n> +\tcase GL_RG8:\n> +\t\tformat = GL_RG;\n> +\t\tbreak;\n> +\tcase GL_LUMINANCE:\n> +\t\tformat = GL_LUMINANCE;\n> +\t\tbreak;\n> +\t}\n> +\n> \t// Generate texture, bind, associate image to texture, configure, unbind\n> -\tglTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, eglImage.format_, GL_UNSIGNED_BYTE, data);\n> +\tglTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, format, type, data);\n> \n> \t// Nearest filtering\n> \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC1EAC3264\n\tfor ;\n\tFri, 26 Jun 2026 10:57:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE8B3658F2;\n\tFri, 26 Jun 2026 12:57:09 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CFC3658E5\n\tfor ;\n\tFri, 26 Jun 2026 12:57:08 +0200 (CEST)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-532-juSBzv_5OIS-rL3Ipqm-cQ-1; Fri, 26 Jun 2026 06:57:05 -0400","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-46e4153b193so886125f8f.1\n\tfor ;\n\tFri, 26 Jun 2026 03:57:05 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-4.net.vodafone.cz. [77.48.47.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-492690988e0sm74495565e9.14.2026.06.26.03.57.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2026 03:57:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"KISfuPuS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1782471427;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+ZJbw1YJmTGWH9J7hERvhPHMoeOLQR6iX03njJ5xQMU=;\n\tb=KISfuPuS4TSPwXo2Vi8MP3vOhBMQdTEV9b75aNJaHbK/r5i4QRR64NJOs6PBmLrsgF/Ism\n\tR/GRRB8ECI7uTQmiWAkIQ7UtvwMRloqpTcEXhSVEha4jD9tQUmNkyqSIdtTttThvgZb2qj\n\tjG/T45//IFko4c7cUxcpoXduLOh1SfM=","X-MC-Unique":"juSBzv_5OIS-rL3Ipqm-cQ-1","X-Mimecast-MFC-AGG-ID":"juSBzv_5OIS-rL3Ipqm-cQ_1782471425","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782471424; x=1783076224;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=+ZJbw1YJmTGWH9J7hERvhPHMoeOLQR6iX03njJ5xQMU=;\n\tb=CGqZbo7S1s39deoZwVUvFrcryGai/P2IGob1gjLuANKFntWrGbSCVpFzb4BNANHiIE\n\tktL8BcwRpL3FSAJHVv3tY0D30e5JpSbz5GESjqzTAXdh46QM9o39QB6cboBarVe2K62f\n\tg6kvwNUEop/4+Apqmpr8cUWmC15YK8+nozMzSJES9Q1Vrhqeu5vMvQR8tBxMigWAFkkK\n\tpS3rZfJSVI6ehEK7Q/XDS3P93D+2D3M2SiSSysYwYOcdaYAkOSC66KtJs//kSP6SfdkB\n\tSFfr0Th++AEP55Jc9N7cufgGHc65Jt5UvWEj6sPE3z8gnPo0kBDgWOgyq8dbEl6mKLM9\n\tgEmA==","X-Gm-Message-State":"AOJu0YzWk2ARvPYLyirHrEyysDU6Q/qFiwmgGpT7tD9S+fAcpThr2VNp\n\t4sCGxYLSvDZzV8xnR8nRc4UR2rA/uyjjp5pDTSMd6qXLtZqeGTfR6fGin5+7HLDaGxkVz+g4Kk7\n\tRmRCOcTaXQKx3YGTtxTgnAnE3r+0zGBBWYj5kh0VheiE7VVcWFChbyTw/Wm+WkJf1cEgtcC1Fh0\n\t0=","X-Gm-Gg":"AfdE7cmrGPQliJDaULyabLyNbjlyUtHDltO8A5m9IUJltVMQW+PxWZjfBYrqNvCUMNe\n\tml459CreIWEY6SZn5ttu0aJqNYiILIFjx27N6UNlQS7ADsTtnIk3kJds6xHs8hNzLY5JgoE1J9Q\n\tkNbDfiDurhF0XCGWgFJLHpjUpTbdhh8yRGXHHxJy6RMEvVfEVLCvlkxn+rEyeH1qepcgDTFNV09\n\tvu+x5bseZlx4NTF0v5IvaPK6IDoLGl4DIgqyOT4YtWNK7IW2DQjUmNjGofZlcaTNVqEX6tEfzRi\n\t9gkTEeKhj00AJN7rKeB4P9X98K1BrPOYS0sVY9mxSNPmxMNjGuIfnBPu1X5Vb/oOjkoLMeoI8x9\n\t1zNSiG7OAPJ1DqmJ35syuaTGun/mZZIaTSFnfdima0OdW75u3lvSjRw/OJTE4y1+m","X-Received":["by 2002:a05:600c:524a:b0:490:bbc1:c9be with SMTP id\n\t5b1f17b1804b1-49266192a51mr78036755e9.0.1782471424554; \n\tFri, 26 Jun 2026 03:57:04 -0700 (PDT)","by 2002:a05:600c:524a:b0:490:bbc1:c9be with SMTP id\n\t5b1f17b1804b1-49266192a51mr78036505e9.0.1782471424001; \n\tFri, 26 Jun 2026 03:57:04 -0700 (PDT)"],"From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH 03/10] libcamera: egl: Extend eGL::createTexture2D to\n\tunderstand floats","In-Reply-To":"<20260624085849.873784-4-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 24 Jun 2026 09:58:42 +0100\")","References":"<20260624085849.873784-1-bryan.odonoghue@linaro.org>\n\t<20260624085849.873784-4-bryan.odonoghue@linaro.org>","Date":"Fri, 26 Jun 2026 12:57:02 +0200","Message-ID":"<85v7b5lgch.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"g4wohRJsG0br-xYvJbjsr5T3SQGgzGx-fWAGZgBPS_8_1782471425","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]