{"id":26983,"url":"https://patchwork.libcamera.org/api/patches/26983/?format=json","web_url":"https://patchwork.libcamera.org/patch/26983/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260618123844.656396-20-barnabas.pocze@ideasonboard.com>","date":"2026-06-18T12:38:36","name":"[RFC,v1,19/27] py: cam: Remove unnecessary check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b264e055cdc690deae3142ccab0aba73607ae619","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26983/mbox/","series":[{"id":6006,"url":"https://patchwork.libcamera.org/api/series/6006/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6006","date":"2026-06-18T12:38:17","name":"Misc. changes before request-buffer split","version":1,"mbox":"https://patchwork.libcamera.org/series/6006/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26983/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26983/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E74BEC3302\n\tfor ;\n\tThu, 18 Jun 2026 12:39:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F59465707;\n\tThu, 18 Jun 2026 14:39:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41264656C6\n\tfor ;\n\tThu, 18 Jun 2026 14:38:52 +0200 (CEST)","from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E82B2F8\n\tfor ;\n\tThu, 18 Jun 2026 14:38:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M4p6egLj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786297;\n\tbh=sVZCK5DrKyV2wHgXoq5/9A5spH9uovod9Cma3px3fMU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=M4p6egLjXJt/KKhiF3z66I9QaZs0lXCEz8gMItHySOIK0mre2T991sjuZt49zuJnx\n\tFd3bCjNavqBwbQM99BqfjsBq4jnnatWbp2vD3N4UpDXPluTEkoQXivaosQa1yyfIwQ\n\tFs0qAbKWMayrjmci/WDiQuQ7aNfSUyzkz/q4mZdA=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1 19/27] py: cam: Remove unnecessary check","Date":"Thu, 18 Jun 2026 14:38:36 +0200","Message-ID":"<20260618123844.656396-20-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","References":"<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The `create_request` method will throw an exception if the request\ncould not be created, it never returns `None`.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/py/cam/cam.py | 4 ----\n 1 file changed, 4 deletions(-)","diff":"diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex ff4b7f663e..73764a8af7 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -206,10 +206,6 @@ class CameraContext:\n for buf_num in range(num_bufs):\n request = self.camera.create_request(self.idx)\n \n- if request is None:\n- print('Can not create request')\n- exit(-1)\n-\n for stream in self.streams:\n buffers = self.allocator.buffers(stream)\n buffer = buffers[buf_num]\n","prefixes":["RFC","v1","19/27"]}